Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp5614659ybv; Tue, 11 Feb 2020 19:58:32 -0800 (PST) X-Google-Smtp-Source: APXvYqyzMuohYIrutkVUII2/VRpCJUPLfEASintwc3jHnLBy/aLS6eP+50OTiyJCh8YPh38ntgv2 X-Received: by 2002:a05:6830:1e2d:: with SMTP id t13mr8028262otr.128.1581479912670; Tue, 11 Feb 2020 19:58:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581479912; cv=none; d=google.com; s=arc-20160816; b=xXJTiy++LmbS/G7wA+Htt1IS8PBJid4qtq16inM4DF1suPEWxKHeAm+WWuZ3/cLEzP cTdCQK97CDnqh3nJRGI3Y03F6zY602QJtgLTV+qhhHp2XHsxqMVL3mDTyjf8VH4ErQ3i 0Oe20DzqTwqiwd8rtXt8mrcfBXp4nCpWS1NgJbqprEvem29hHaFpb6j2e6wyKVKQNi1W ClY+Mg1hcCL81aUX5qayIElo/t7xkGpYkJ+eVfRUOpp0oYyYbBU2igmKns1bqMBdaPoV gW29iXtE2tlu8uxma4A815ypdkwaCVqBdl7tgI9MbEilGvZRPeU4YQDFT06TZCb/v61p Omkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=83fhIJoXHGyKFWR0u7GybPdUeA+T811CmfH2NEzMBKs=; b=eBw0EPUUPE1b5VLJ1KXFx1h9zesyer+pGR6faS6Z5A7da0BIOXG9CJLPLO+/hGo9rK zecHLmJpPdYfmrhJIQ2/TnXO7cUGclWK3G4kq9yaKOj+6SiUIVLZTbwIF+j9xMOzitbk gauZipmRaQisdxwiM1Phqa6qHeaUDGiSvNMOD2AECKKxgpCqOc3o6J3OraQPeysgePxc /AP1PjBDUwYrSKbsFBgETrZlWQt9wbi9KRkI2SAEVIh+p+KiZ/wNYIpj2jW6mSieYzRt aX2SxWPAyKUBk+g8utnLKgCSqg8QJ56N6sCWnW2b4+OTDlBVfZexJ9Z3rPizJqALrPyo Mxjg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=qQb1eqz1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d19si2950158ote.3.2020.02.11.19.58.20; Tue, 11 Feb 2020 19:58:32 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=qQb1eqz1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727927AbgBLD6Q (ORCPT + 99 others); Tue, 11 Feb 2020 22:58:16 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:46666 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726755AbgBLD6Q (ORCPT ); Tue, 11 Feb 2020 22:58:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=83fhIJoXHGyKFWR0u7GybPdUeA+T811CmfH2NEzMBKs=; b=qQb1eqz1vnxMwy5irhYz9tECh5 H1c/xd8lbLfnFVuL0y5zQoQEGaW1KcYvkjvwtZR7TnE2Mod+7IFSEjbpmcWTUQ2ZWGCtU789JNBVv BckOqsWP9F/S2Q/E3otdfd8pp5Ng2vxwkHxXpcTr84EDxSrfskHK/Rj3BqlWMWYFVwUGn+qUuiHuo Zvw3CIG10BrMfVVTdjMbRr7O4XNYQAPDTl3EQW6dnXmF+erO8yFnsRAQZ164bdr5DaWuqqAA+tMin nY8MULH8b3gpX49NSgYLQQW065vTn0UZYKzeJvlNAnAr3OmdfnOvYCxo2pQ4182h6SfshHGPk/BkG zJ59Pprg==; Received: from willy by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1j1jAC-0007pr-BC; Wed, 12 Feb 2020 03:58:12 +0000 Date: Tue, 11 Feb 2020 19:58:12 -0800 From: Matthew Wilcox To: Linus Torvalds Cc: Andrew Morton , Johannes Weiner , Rik van Riel , linux-fsdevel , Linux-MM , Linux Kernel Mailing List , Dave Chinner , Yafang Shao , Michal Hocko , Roman Gushchin , Al Viro , kernel-team@fb.com Subject: Re: [PATCH] vfs: keep inodes with page cache off the inode shrinker LRU Message-ID: <20200212035812.GB7778@bombadil.infradead.org> References: <20200211175507.178100-1-hannes@cmpxchg.org> <29b6e848ff4ad69b55201751c9880921266ec7f4.camel@surriel.com> <20200211193101.GA178975@cmpxchg.org> <20200211154438.14ef129db412574c5576facf@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 11, 2020 at 04:28:39PM -0800, Linus Torvalds wrote: > On Tue, Feb 11, 2020 at 3:44 PM Andrew Morton wrote: > > Testing this will be a challenge, but the issue was real - a 7GB > > highmem machine isn't crazy and I expect the inode has become larger > > since those days. > > Hmm. I would say that in the intening years a 7GB highmem machine has > indeed become crazy. > > It used to be something we kind of supported. > > But we really should consider HIGHMEM to be something that is on the > deprecation list. In this day and age, there is no excuse for running > a 32-bit kernel with lots of physical memory. > > And if you really want to do that, and have some legacy hardware with > a legacy use case, maybe you should be using a legacy kernel. > > I'd personally be perfectly happy to start removing HIGHMEM support again. Do we have a use case where people want to run modern 32-bit guest kernels with more than 896MB of memory to support some horrendous legacy app? Or is our 32-bit compat story good enough that nobody actually does this? (Contrariwise, maybe those people are also fine with running a ten year old kernel because a `uname -r` starting with '3' breaks said app)