Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Wed, 12 Feb 2020 11:53:29 +0530
From:   bgodavar@codeaurora.org
To:     Matthias Kaehlcke <mka@chromium.org>
Cc:     linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, agross@kernel.org,
        bjorn.andersson@linaro.org, hemantg@codeaurora.org,
        robh+dt@kernel.org, mark.rutland@arm.com, gubbaven@codeaurora.org
Subject: Re: [PATCH v1] arm64: dts: qcom: sc7180: Add node for bluetooth soc
 wcn3990
In-Reply-To: <20200211173323.GE18972@google.com>
References: <20200211121612.29075-1-bgodavar@codeaurora.org>
 <20200211173323.GE18972@google.com>
Message-ID: <bacac82fbdfcc920e5982c5e1c629549@codeaurora.org>
User-Agent: Roundcube Webmail/1.3.9
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Matthias,


On 2020-02-11 23:03, Matthias Kaehlcke wrote:
> On Tue, Feb 11, 2020 at 05:46:12PM +0530, Balakrishna Godavarthi wrote:
> 
>> subject: arm64: dts: qcom: sc7180: Add node for bluetooth soc wcn3990
> 
> Preferably say in the subjct that the node is added for the IDP board.
> 
[Bala]: will update

>> Add node for bluetooth soc wcn3990.
>> 
>> Signed-off-by: Balakrishna Godavarthi <bgodavar@codeaurora.org>
>> ---
>>  arch/arm64/boot/dts/qcom/sc7180-idp.dts | 11 +++++++++++
>>  1 file changed, 11 insertions(+)
>> 
>> diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts 
>> b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
>> index 388f50ad4fde..19f82ddc1f09 100644
>> --- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts
>> +++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
>> @@ -19,6 +19,7 @@
>>  	aliases {
>>  		hsuart0 = &uart3;
>>  		serial0 = &uart8;
>> +		bluetooth0 = &bluetooth;
>>  	};
>> 
>>  	chosen {
>> @@ -256,6 +257,16 @@
>> 
>>  &uart3 {
>>  	status = "okay";
> 
> nit: add a blank line
> 

[Bala]: will update

>> +	bluetooth: wcn3990-bt {
>> +		compatible = "qcom,wcn3990-bt";
>> +		vddio-supply = <&vreg_l10a_1p8>;
>> +		vddxo-supply = <&vreg_l1c_1p8>;
>> +		vddrf-supply = <&vreg_l2c_1p3>;
>> +		vddch0-supply = <&vreg_l10c_3p3>;
>> +		max-speed = <3200000>;
>> +		clocks = <&rpmhcc RPMH_RF_CLK2>;
>> +		status = "okay";
> 
> status is not needed here AFAIK.
[Bala]: true, will update