Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 12 Feb 2020 19:14:14 +1100
From:   Aleksa Sarai <cyphar@cyphar.com>
To:     shuah <shuah@kernel.org>
Cc:     linux-kselftest@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Dmitry Safonov <dima@arista.com>
Subject: Re: Linux 5.6-rc1 kselftest build failures
Message-ID: <20200212081414.7bwkndf6qxg2p35a@yavin>
References: <ff16537e-febc-1b98-0cf8-1aa23e0c29b0@kernel.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="xhe55iz3x7b3lfsi"
Content-Disposition: inline
In-Reply-To: <ff16537e-febc-1b98-0cf8-1aa23e0c29b0@kernel.org>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--xhe55iz3x7b3lfsi
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 2020-02-11, shuah <shuah@kernel.org> wrote:
> openat2:
>=20
> tools/testing/selftests/openat2'
> gcc -Wall -O2 -g -fsanitize=3Daddress -fsanitize=3Dundefined openat2_test=
=2Ec
> helpers.c  -o tools/testing/selftests/openat2/openat2_test
> In file included from /usr/include/fcntl.h:301,
>                  from helpers.c:9:
> In function =E2=80=98openat=E2=80=99,
>     inlined from =E2=80=98touchat=E2=80=99 at helpers.c:49:11:
> /usr/include/x86_64-linux-gnu/bits/fcntl2.h:126:4: error: call to
> =E2=80=98__openat_missing_mode=E2=80=99 declared with attribute error: op=
enat with O_CREAT
> or O_TMPFILE in third argument needs 4 arguments
>   126 |    __openat_missing_mode ();
>       |    ^~~~~~~~~~~~~~~~~~~~~~~~

Yeah, that's a brain-o -- it looks like you have a newer glibc than
me which gives you a warning when you don't set the mode. The fix should
be just the following:

--8<-----------------------------------------------------------------------
Subject: [PATCH] selftests: openat2: fix build error on newer glibc

It appears that newer glibcs check that openat(O_CREAT) was provided a
fourth argument (rather than passing garbage), resulting in the
following build error:

  In file included from /usr/include/fcntl.h:301,
                   from helpers.c:9:
  In function =E2=80=98openat=E2=80=99,
      inlined from =E2=80=98touchat=E2=80=99 at helpers.c:49:11:
  /usr/include/x86_64-linux-gnu/bits/fcntl2.h:126:4: error: call to
  =E2=80=98__openat_missing_mode=E2=80=99 declared with attribute error: op=
enat with O_CREAT
  or O_TMPFILE in third argument needs 4 arguments
    126 |    __openat_missing_mode ();
        |    ^~~~~~~~~~~~~~~~~~~~~~~~

Reported-by: Shuah Khan <shuah@kernel.org>
Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
---
 tools/testing/selftests/openat2/helpers.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/openat2/helpers.c b/tools/testing/self=
tests/openat2/helpers.c
index e9a6557ab16f..5074681ffdc9 100644
--- a/tools/testing/selftests/openat2/helpers.c
+++ b/tools/testing/selftests/openat2/helpers.c
@@ -46,7 +46,7 @@ int sys_renameat2(int olddirfd, const char *oldpath,
=20
 int touchat(int dfd, const char *path)
 {
-	int fd =3D openat(dfd, path, O_CREAT);
+	int fd =3D openat(dfd, path, O_CREAT, 0700);
 	if (fd >=3D 0)
 		close(fd);
 	return fd;
--=20
2.25.0


--xhe55iz3x7b3lfsi
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQSxZm6dtfE8gxLLfYqdlLljIbnQEgUCXkOzzwAKCRCdlLljIbnQ
EraKAQC/qMKYRdSDHKJDWUIVTk4FHJi8YDwEcnu4LjqgbyslhwD/TgRqDCBjUmG4
DYIqXhuIMKKZchvwgGkdIRL6Kdua2wk=
=XJmq
-----END PGP SIGNATURE-----

--xhe55iz3x7b3lfsi--