Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp5827787ybv; Wed, 12 Feb 2020 00:47:52 -0800 (PST) X-Google-Smtp-Source: APXvYqzHm4317Zu5Hbzt3o7b4jIvW8tecnXeruWGqdcCBpuR0jbZxgPm3c/J0C0wCN7kw9UyG5J/ X-Received: by 2002:aca:ab53:: with SMTP id u80mr5365955oie.94.1581497272143; Wed, 12 Feb 2020 00:47:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581497272; cv=none; d=google.com; s=arc-20160816; b=ypHTC+/2BVa7fTyShdk1hMdToLYzJy+KzNotst8XFU9Tu2VvCeSrxmQBx+2Q7WaF3G nmlIcneBJZDipEAlZufEQrEbZN5epFOfaGHr0/nz48Z+UH1A8RfiBxamr1iJdDE40G5b 6+ZgMGfeTo8jGxViKIAvp8s+YoKZ+uRkomV4uZ0ocyMOuGUarlGapvJvrxHzggzEA86M sh8Phgygof3y+wOwG0EcVok0UC5ZuHZyx8jkcI88CJmNLeHvWGOfFQ3j1I1ULk2kQogO shIqqEVUkZRXLMHCb0/+MEXylTeq8KEEABxYhRRXpqhosarBNJyhtr7W2ucebKs5t9rf m2uA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:ironport-sdr:ironport-sdr; bh=knAkk6fzSqHzKQWxe8m98eI13peptXgqSCtDwklJ4Zc=; b=0vnASYrXVmqflXgKtrCPqQHwzdzu+B/EUNEFf92/LlwJv4QkkZJeHIUx8Z68ZQQVC7 0tVKINL8SCbvdKCM7sUK+q//0GNpYjFQPGqcSrTg4DgVwwv87Z4A/ujvnCrHGeQl01U0 8BBnBpl8C2ZlBp0pX81pv1SLjN8/MB8AuQoX4Yvqf/5a38T1cV9bZP7zx9MHVhrqaRUG UhZZNo/ihEq2SNvyoRoFyZc7osPor4lGjb/jOX/4vIKg/yq+fwmCISRtwBnTMjM+Nf+a Gkvu944HryxeFescstX+phbjt7f6LRxg6TxR5l2wklFCRdguKuEwMq7qto03/XGqKeLJ N8Kw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z26si2963978oid.247.2020.02.12.00.47.39; Wed, 12 Feb 2020 00:47:52 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728538AbgBLIrN (ORCPT + 99 others); Wed, 12 Feb 2020 03:47:13 -0500 Received: from esa2.mentor.iphmx.com ([68.232.141.98]:5140 "EHLO esa2.mentor.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728544AbgBLIrM (ORCPT ); Wed, 12 Feb 2020 03:47:12 -0500 IronPort-SDR: fOy+vc4Ykexg2rAn6t6sQkNfPHvzThpPXw6PxvNBfTtRu7wk/WjDS1Dxl9pRXrTUE9am4q7bMT ay8z1X/aNFZwlNi191v9qKQCQReddtiFBzev8tF8ZR+8KckmhR58UcKVINiOcNsvxvEDJb6oEp U4+Xzjfin/u4Dyb3TC1vjsa08xmOuIV2dM6Lmet8kv6ngpgolG93WvIg8OGLcfm/5XiJcX1ffJ zucVErb9SDWsZcgMjY2oYzbvwr4Qikl3MrtW9mCtMSjRKWQ68H8MLqd0hOna2QsJRxOhmZZWYq dic= X-IronPort-AV: E=Sophos;i="5.70,428,1574150400"; d="scan'208";a="45686299" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa2.mentor.iphmx.com with ESMTP; 12 Feb 2020 00:47:11 -0800 IronPort-SDR: OPjzyoNIehf1LkwreltCylrx4xOql3bqx2e5u85F6EwqZlt+QYDwNVjI07oOc/s50PF9QMleG8 kRjQK4bhs8/DAVqaQXmsWbNx2uGR0DTmx0VVFS6tzc33KsJc7CsEZmwzJxfUAJisRBr+R1459U m6FPhM+UcODwGNTrnyCTKwzgbGLFgYBYTSGjTX6AMaItABH+F/dL3l8BGe+uVTY7MXtU9xKkra +QRDvbQf9hcyZnbMXzD2dCW6Iae3egSus5lHOWtTy4Jlw65sXh79Ug8ZmLLo8xNPU0ZY0zwTEs s3w= From: Jiada Wang To: , , , , , CC: , , , , Subject: [PATCH v7 40/48] Input: Atmel: improve error handling in mxt_update_cfg() Date: Wed, 12 Feb 2020 00:42:10 -0800 Message-ID: <20200212084218.32344-41-jiada_wang@mentor.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200212084218.32344-1-jiada_wang@mentor.com> References: <20200212084218.32344-1-jiada_wang@mentor.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Deepak Das mxt_update_cfg() failed to propagate the error code from mxt_init_t7_power_cfg() so return the error code. Signed-off-by: Deepak Das Signed-off-by: George G. Davis Signed-off-by: Jiada Wang --- drivers/input/touchscreen/atmel_mxt_ts.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c index 07228df847e3..3654f4b399d9 100644 --- a/drivers/input/touchscreen/atmel_mxt_ts.c +++ b/drivers/input/touchscreen/atmel_mxt_ts.c @@ -2183,7 +2183,9 @@ static int mxt_update_cfg(struct mxt_data *data, const struct firmware *fw) dev_info(dev, "Config successfully updated\n"); /* T7 config may have changed */ - mxt_init_t7_power_cfg(data); + ret = mxt_init_t7_power_cfg(data); + if (ret) + dev_warn(dev, "Power Config failed to update\n"); release_mem: kfree(cfg.mem); -- 2.17.1