Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp5852278ybv; Wed, 12 Feb 2020 01:18:04 -0800 (PST) X-Google-Smtp-Source: APXvYqyCJRs1koRsy8xKMKcxwdc4pmnqLi/60PMuTiiT/ouWYlMH+lwdafmN0R8+gCXdNtTpUpAG X-Received: by 2002:aca:889:: with SMTP id 131mr5342388oii.3.1581499084679; Wed, 12 Feb 2020 01:18:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581499084; cv=none; d=google.com; s=arc-20160816; b=LiPabjiOf5qbRfSbifwzxmOopAxD6EwUgORzG+p9f1iWbzp1cHZn9YZcm6odZ9E8ob IwIi9Z0j2iniWRzTlWEWl5fIuLdPkicDCJEVBRqPnstRMYnjaSW5ZCFRHQbf27u0cX9a 7WTKEix0bu3Dhbx66OhJhnn5UzGHWhfKu2OlmDKeGqPo2nwUMA4PHIizrQ13tDHqvugH ij87RaOrNwZJH5wqT844Np0Gur7b0IVXK7d01NoAurZSYMJP9Fif3EacB3SIMO6o8sP+ Jl/09vET3xId5CKOmeWhMpeu0cuD68sBbZIT5cE1guP5oARq8v4Jp8ZCLKxjYIpcToKQ e54w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version; bh=UFykYmpeqq57o6fsy3lLQgTxgLUBdF0//2jzAtV9jNI=; b=0GbBTRGCE2lEr7ztSNNpnNkH71x8KUfJfu9hE5g4iSgaRx7XrYKZzahxNizGUVTjM5 i6lfGFuVGGX15lD+y5SOcG75Rjl/2N3Vwa6tDQnDhoPfFv4ABfyFKYJ3ot23MpK0MjZS Uhuv9iJhrd92peBdn/SA2dh1GSJfJBkXSBM1J7kltQk8jAQaUVQ0OYWEbSSoEgDRY3lJ m6Ykur4mvm2dyakoy/8qtUaClls9BhW5wN5KbKnvgSsKInh1tN1GQKL2AW7/s9h+VqRs Hk/zRDReD+R9T3VE2K4X8fMg7H+SCKHmoO8ZB4t+OgxlMEkHyeyKZc9JwxiBEIndRCHX tIXQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w26si3437430otl.213.2020.02.12.01.17.51; Wed, 12 Feb 2020 01:18:04 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728731AbgBLJRW (ORCPT + 99 others); Wed, 12 Feb 2020 04:17:22 -0500 Received: from mail-oi1-f193.google.com ([209.85.167.193]:37227 "EHLO mail-oi1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728150AbgBLJRV (ORCPT ); Wed, 12 Feb 2020 04:17:21 -0500 Received: by mail-oi1-f193.google.com with SMTP id q84so1371183oic.4; Wed, 12 Feb 2020 01:17:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UFykYmpeqq57o6fsy3lLQgTxgLUBdF0//2jzAtV9jNI=; b=oHqav0W9EJMmXoN2QtfEobnDgt5oyffWex9D0gqZjWBhvps765zyokW19FXeE6r/+P BwBWvNTotuxxQiyPFFKnbeHym3f2B3/+ae6sEnRI3DOLQSXzigpK301ptNNtdNGnf7hk QZZm2axThTABIY3JmQYYxWg9PdDIyVJt+bFHG83lw8S5aOCejaUgp5XiitZ0DW0z8Ooh dRqBUt/x4C5cPhXGGxA5bJvejyVqvoaZLu1A5kCjKf0gIb5J2siZ1Tcv1hBaOk8OIYYE xeN546t0tn2l3/Maf+ZKkiYeHX2EQLp0Xm0Y50rjXh7OYVfVeRcZaofkz2SNSXKvzBjr 9YVQ== X-Gm-Message-State: APjAAAW04Fh1J6YR2fMwK7K0TaAHQEHB3lNqY5xXrlFqBDXaZdO3IFYf ey1wiuVCnusxMeFI5D9mhUDY0qZgBdXc+Fa5dLBKEA== X-Received: by 2002:aca:d6c8:: with SMTP id n191mr5789883oig.103.1581499040711; Wed, 12 Feb 2020 01:17:20 -0800 (PST) MIME-Version: 1.0 References: <1654227.8mz0SueHsU@kreacher> In-Reply-To: From: "Rafael J. Wysocki" Date: Wed, 12 Feb 2020 10:17:08 +0100 Message-ID: Subject: Re: [PATCH 00/28] PM: QoS: Get rid of unuseful code and rework CPU latency QoS interface To: Ulf Hansson Cc: "Rafael J. Wysocki" , Linux PM , LKML , Amit Kucheria Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 12, 2020 at 9:38 AM Ulf Hansson wrote: > > On Wed, 12 Feb 2020 at 00:39, Rafael J. Wysocki wrote: > > > > Hi All, > > > > This series of patches is based on the observation that after commit > > c3082a674f46 ("PM: QoS: Get rid of unused flags") the only global PM QoS class > > in use is PM_QOS_CPU_DMA_LATENCY, but there is still a significant amount of > > code dedicated to the handling of global PM QoS classes in general. That code > > takes up space and adds overhead in vain, so it is better to get rid of it. > > > > Moreover, with that unuseful code removed, the interface for adding QoS > > requests for CPU latency becomes inelegant and confusing, so it is better to > > clean it up. > > > > Patches [01/28-12/28] do the first part described above, which also includes > > some assorted cleanups of the core PM QoS code that doesn't go away. > > > > Patches [13/28-25/28] rework the CPU latency QoS interface (in the classic > > "define stubs, migrate users, change the API proper" manner), patches > > [26-27/28] update the general comments and documentation to match the code > > after the previous changes and the last one makes the CPU latency QoS depend > > on CPU_IDLE (because cpuidle is the only user of its target value today). > > > > The majority of the patches in this series don't change the functionality of > > the code at all (at least not intentionally). > > > > Please refer to the changelogs of individual patches for details. > > > > Thanks! > > A big thanks for cleaning this up! The PM_QOS_CPU_DMA_LATENCY and > friends, has been annoying me for a long time. This certainly makes > the code far better and more understandable! > > I have looked through the series and couldn't find any obvious > mistakes, so feel free to add: > > Reviewed-by: Ulf Hansson Thanks for the review, much appreciated! > Note, the review tag also means, that's fine for you to pick the mmc > patch via your tree. Thank you!