Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp5856844ybv; Wed, 12 Feb 2020 01:23:49 -0800 (PST) X-Google-Smtp-Source: APXvYqwj40l4ry+AUOQRueYueFnMUpw5f6swld9vetES/e/FeBGXoGS1HbkgKHGfRKMIlz32bt22 X-Received: by 2002:aca:6543:: with SMTP id j3mr5508090oiw.150.1581499428977; Wed, 12 Feb 2020 01:23:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581499428; cv=none; d=google.com; s=arc-20160816; b=MeYYJVKD7mvDrVb/pGcvCcYB6DzE4+xg/2qvZZ79sNDzkcvIkMfAQZgy72ip0VobAn ByS5N2L43ji1Y37cwDZSdGCT7+/rCBIvM9mmqpl32heOQtR1mXlxsSRw8H3LUw8hBP4u w+Vn3ZCbo2v1O3EkoUtLI28N5jit1urzGASYT4DmcaPomwESrurH/idlMmYCYnsXjtV4 XXlA0hvzojvoJ24MgtB4841yuvy2XWIzyPZmDQ7pdQVr0Q2UNhFDiJ8tjtsrQ+o90NPH KwzXjUxxOTXk+tyqXBi+gaTLNvMFHTDeC68hbHKNnG1CG76jmW+MrWQtyxmnrk+8Eh7L 1bCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version; bh=LUJglwWT4yeZe9Lh+O1oa+CnC/XnwAm/Q6YITICL3Zc=; b=o6Kr6j8xEs7BWjbhcxZPhJt3+zhhRjvKHcYagMCctJk0pq8pUhP42FZCnOFPlMHycu TQHmlf9OfljOD/WBT0Ta6wl1zRecJBedNrPuDCtZ+FxrEO6gNYKGUdsBOwdMdvmrDPOg e8QCQHTCGd+OcQUyNIOATSAq7OHFun17aWuyfPD5m9tGLWa3FMdaM7X+E1do/tUsxR6j ogCIWmsm2QBcm7aJqBqZYsbU6D+2mgjzQHwJ5YwweOgADbzC+/3TzfTGmwwtIBjFn1JQ /9mmSdrZYqdg6n6NybCrLvJC7J9Bq8euo1v2ItKDHgQ0zR4vqGzcgT76PWnvcda0O/kH ppfg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q26si2858523oij.38.2020.02.12.01.23.36; Wed, 12 Feb 2020 01:23:48 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728728AbgBLJXb (ORCPT + 99 others); Wed, 12 Feb 2020 04:23:31 -0500 Received: from mail-ot1-f68.google.com ([209.85.210.68]:33748 "EHLO mail-ot1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728595AbgBLJXa (ORCPT ); Wed, 12 Feb 2020 04:23:30 -0500 Received: by mail-ot1-f68.google.com with SMTP id b18so1256835otp.0; Wed, 12 Feb 2020 01:23:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LUJglwWT4yeZe9Lh+O1oa+CnC/XnwAm/Q6YITICL3Zc=; b=SOHEwdzfaaBBc0PoHoPgoluP35AeVpHiG5cEZjNJqXxrmFgZ1wRVb5QuB82/3ThgPx K0O2AB/BLVmf+r6CDJwUFieNXqlg+4DPowAiwhcXi4n9Yoh+4DOnQdxGZ3sN8TyvTyPi 3u7Nvvl30DDhkuG6qzOcsPLUDcVvFg70DzcZd78OuG1+j5pj6tb/pM/FT0Jk5DsZtCJ1 Rwhru4WWqi/by+ebt4x8fzIrrwZTWfP+dGdNC/UI0THwv3it6pAbhSE/5ePNMVgV8m+v q+AnW6xkG/1OIxK/KIH+otSduxNJENZTZHrrQFeWRCRbka1Q9iyE5/ahoDyJA0EQJY61 8DEw== X-Gm-Message-State: APjAAAXZYUqAEYbGSwUH7b66/c7+gzuX/9fbHpLsedYhpe6Z6M29/4cq UAoOY55QGXsZdXxX9kI8J9vMkvbGAc+gq/NlFlk= X-Received: by 2002:a05:6830:1d55:: with SMTP id p21mr8474526oth.145.1581499409612; Wed, 12 Feb 2020 01:23:29 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Geert Uytterhoeven Date: Wed, 12 Feb 2020 10:23:07 +0100 Message-ID: Subject: Re: [PATCH v2] asm-generic: Fix unistd_32.h generation format To: Michal Simek Cc: Linux Kernel Mailing List , Michal Simek , git@xilinx.com, Arnd Bergmann , Andrew Morton , Stefan Asserhall , Chris Zankel , "David S. Miller" , Fenghua Yu , Helge Deller , Ivan Kokshaysky , "James E.J. Bottomley" , Matt Turner , Max Filippov , Rich Felker , Richard Henderson , Tony Luck , Yoshinori Sato , alpha , "linux-ia64@vger.kernel.org" , linux-m68k , Parisc List , Linux-sh list , linux-xtensa@linux-xtensa.org, sparclinux Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Michal, On Wed, Feb 12, 2020 at 10:16 AM Michal Simek wrote: > Generated files are also checked by sparse that's why add newline > to remove sparse (C=1) warning. > > The issue was found on Microblaze and reported like this: > ./arch/microblaze/include/generated/uapi/asm/unistd_32.h:438:45: > warning: no newline at end of file > > Signed-off-by: Michal Simek > Reviewed-by: Stefan Asserhall Thanks for your patch! > arch/alpha/kernel/syscalls/syscallhdr.sh | 1 + > arch/ia64/kernel/syscalls/syscallhdr.sh | 1 + > arch/m68k/kernel/syscalls/syscallhdr.sh | 1 + Bummer, I had noticed that before https://lore.kernel.org/lkml/CAMuHMdVsBwL9vcqejfc47GN793wMXdQ=SwEsSUP1fbpMt-OoWw@mail.gmail.com/ and even claimed I fixed it while applying https://lore.kernel.org/lkml/CAMuHMdW6JiponxLiGNEXUX4xJk3hK4b8dTOCNvVBr7s2LyfhJw@mail.gmail.com/ but something must have gone wrong... > arch/microblaze/kernel/syscalls/syscallhdr.sh | 1 + > arch/parisc/kernel/syscalls/syscallhdr.sh | 1 + > arch/sh/kernel/syscalls/syscallhdr.sh | 1 + > arch/sparc/kernel/syscalls/syscallhdr.sh | 1 + > arch/xtensa/kernel/syscalls/syscallhdr.sh | 1 + > 8 files changed, 8 insertions(+) > > diff --git a/arch/alpha/kernel/syscalls/syscallhdr.sh b/arch/alpha/kernel/syscalls/syscallhdr.sh > index e5b99bd2e5e7..524c69fbcab7 100644 > --- a/arch/alpha/kernel/syscalls/syscallhdr.sh > +++ b/arch/alpha/kernel/syscalls/syscallhdr.sh > @@ -33,4 +33,5 @@ grep -E "^[0-9A-Fa-fXx]+[[:space:]]+${my_abis}" "$in" | sort -n | ( > printf "#endif\n" > printf "\n" > printf "#endif /* %s */" "${fileguard}" > + printf "\n" Why not add the "\n" to the end of the previous line? Anyway, Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds