Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1581501228-5393-1-git-send-email-wang.yi59@zte.com.cn>
In-Reply-To: <1581501228-5393-1-git-send-email-wang.yi59@zte.com.cn>
From:   Alexander Potapenko <glider@google.com>
Date:   Wed, 12 Feb 2020 10:56:16 +0100
Message-ID: <CAG_fn=UGmEMyjASasZTK3cXAZzJ4tb9wCGsW1FoA+kPNJiW1Gw@mail.gmail.com>
Subject: Re: [PATCH] lib: Use kzalloc() instead of kmalloc() with flag GFP_ZERO.
To:     Yi Wang <wang.yi59@zte.com.cn>
Cc:     Andrey Ryabinin <aryabinin@virtuozzo.com>,
        Dmitriy Vyukov <dvyukov@google.com>,
        kasan-dev <kasan-dev@googlegroups.com>,
        LKML <linux-kernel@vger.kernel.org>, xue.zhihong@zte.com.cn,
        wang.liang82@zte.com.cn, Huang Zijiang <huang.zijiang@zte.com.cn>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Feb 12, 2020 at 10:54 AM Yi Wang <wang.yi59@zte.com.cn> wrote:
>
> From: Huang Zijiang <huang.zijiang@zte.com.cn>
>
> Use kzalloc instead of manually setting kmalloc
> with flag GFP_ZERO since kzalloc sets allocated memory
> to zero.
>
> Change in v2:
>     add indation
>
> Signed-off-by: Huang Zijiang <huang.zijiang@zte.com.cn>
> Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
Reviewed-by: Alexander Potapenko <glider@google.com>
> ---
>  lib/test_kasan.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/lib/test_kasan.c b/lib/test_kasan.c
> index 328d33b..79be158 100644
> --- a/lib/test_kasan.c
> +++ b/lib/test_kasan.c
> @@ -599,7 +599,7 @@ static noinline void __init kasan_memchr(void)
>         size_t size =3D 24;
>
>         pr_info("out-of-bounds in memchr\n");
> -       ptr =3D kmalloc(size, GFP_KERNEL | __GFP_ZERO);
> +       ptr =3D kzalloc(size, GFP_KERNEL);
>         if (!ptr)
>                 return;
>
> @@ -614,7 +614,7 @@ static noinline void __init kasan_memcmp(void)
>         int arr[9];
>
>         pr_info("out-of-bounds in memcmp\n");
> -       ptr =3D kmalloc(size, GFP_KERNEL | __GFP_ZERO);
> +       ptr =3D kzalloc(size, GFP_KERNEL);
>         if (!ptr)
>                 return;
>
> @@ -629,7 +629,7 @@ static noinline void __init kasan_strings(void)
>         size_t size =3D 24;
>
>         pr_info("use-after-free in strchr\n");
> -       ptr =3D kmalloc(size, GFP_KERNEL | __GFP_ZERO);
> +       ptr =3D kzalloc(size, GFP_KERNEL);
>         if (!ptr)
>                 return;
>
> --
> 1.9.1
>
> --
> You received this message because you are subscribed to the Google Groups=
 "kasan-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an=
 email to kasan-dev+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgi=
d/kasan-dev/1581501228-5393-1-git-send-email-wang.yi59%40zte.com.cn.


--=20
Alexander Potapenko
Software Engineer

Google Germany GmbH
Erika-Mann-Stra=C3=9Fe, 33
80636 M=C3=BCnchen

Gesch=C3=A4ftsf=C3=BChrer: Paul Manicle, Halimah DeLaine Prado
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg