Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 12 Feb 2020 19:20:00 +0800
From:   Baoquan He <bhe@redhat.com>
To:     Dan Williams <dan.j.williams@intel.com>,
        David Hildenbrand <david@redhat.com>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux MM <linux-mm@kvack.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Wei Yang <richardw.yang@linux.intel.com>
Subject: Re: [PATCH 3/7] mm/sparse.c: only use subsection map in VMEMMAP case
Message-ID: <20200212112000.GH8965@MiWiFi-R3L-srv>
References: <CAPcyv4hh5PmF8qU+p7Q903PhX+ho9yHMzLFncmh6psW5YOLU_w@mail.gmail.com>
 <B23A05D9-40E2-4862-979D-C6DA69DDDC80@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <B23A05D9-40E2-4862-979D-C6DA69DDDC80@redhat.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 02/12/20 at 10:39am, David Hildenbrand wrote:
>=20
>=20
> > Am 11.02.2020 um 21:15 schrieb Dan Williams <dan.j.williams@intel.com=
>:
> >=20
> > =EF=BB=BFOn Sun, Feb 9, 2020 at 2:48 AM Baoquan He <bhe@redhat.com> w=
rote:
> >>=20
> >> Currently, subsection map is used when SPARSEMEM is enabled, includi=
ng
> >> VMEMMAP case and !VMEMMAP case. However, subsection hotplug is not
> >> supported at all in SPARSEMEM|!VMEMMAP case, subsection map is unnec=
essary
> >> and misleading. Let's adjust code to only allow subsection map being
> >> used in SPARSEMEM|VMEMMAP case.
> >>=20
> >> Signed-off-by: Baoquan He <bhe@redhat.com>
> >> ---
> >> include/linux/mmzone.h |   2 +
> >> mm/sparse.c            | 231 ++++++++++++++++++++++-----------------=
--
> >> 2 files changed, 124 insertions(+), 109 deletions(-)
> >>=20
> >> diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
> >> index 462f6873905a..fc0de3a9a51e 100644
> >> --- a/include/linux/mmzone.h
> >> +++ b/include/linux/mmzone.h
> >> @@ -1185,7 +1185,9 @@ static inline unsigned long section_nr_to_pfn(=
unsigned long sec)
> >> #define SUBSECTION_ALIGN_DOWN(pfn) ((pfn) & PAGE_SUBSECTION_MASK)
> >>=20
> >> struct mem_section_usage {
> >> +#ifdef CONFIG_SPARSEMEM_VMEMMAP
> >>        DECLARE_BITMAP(subsection_map, SUBSECTIONS_PER_SECTION);
> >> +#endif
> >=20
> > This was done deliberately so that the SPARSEMEM_VMEMMAP=3Dn case ran=
 as
> > a subset of the SPARSEMEM_VMEMMAP=3Dy case.

Thanks for checking this, Dan.

Taking away the subsection part, won't affect the classic sparse being a
subset of VMEMMAP case, I would say.


> >=20
> > The diffstat does not seem to agree that this is any clearer:
> >=20
> >    124 insertions(+), 109 deletions(-)
> >=20
>=20
> I don=E2=80=98t see a reason to work with subsections (+store them) if =
subsections are not supported.
>=20
> I do welcome this cleanup. Diffstats don=E2=80=98t tell the whole story=
.

Thanks for clarifying this, David, I agree.

If applying the patch, it should be easier to observe that the code
is simpler to follow, at least won't be confusing on subsection handling
part.