Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp6002947ybv; Wed, 12 Feb 2020 04:19:29 -0800 (PST) X-Google-Smtp-Source: APXvYqxCkXgwKGShFY3O+QiMsmrkWLvBkE3Pvp6QHXOt2WS5r4MoVeF4pRc1UAI8fKZFUabE7hnw X-Received: by 2002:aca:120e:: with SMTP id 14mr5697160ois.135.1581509969143; Wed, 12 Feb 2020 04:19:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581509969; cv=none; d=google.com; s=arc-20160816; b=J6qCfMJ8JrdvQ8RRSDnowg/pHZ7so8QnFnZFut4+qMuQko6uk6mxuQApNEvqoAQ4iC p5bUO8sjXStq0Y7WJaIDGnsCBsjndn4A5zCtavf5vj/uU+i6+CZlCXIXl2jvN5Yu/hRr wGJ9AoKrN+JAmEwlVOnK7HuxSx49ay3cSmPGwZNC0vdVDpTMFNDsWincwUGUE8MVCb0T ZRWOutyT5QNQTmEltiKDLDekiouiu83Go8iP4+vF20ATymxydq9D+VrXFEMbqyAfDOLj VrRCZiVoGeCcK4rbTHzqR9tj/jVmIzkvYraXieeywgMU2fyP6zj8wqP7kusLzUrhkgiL 0TXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:from:references:cc:to:subject:dkim-signature; bh=R2NyxXoUW9Cj8Ba0zPl8bE0kVh7j7MxxmAH4rY3eAb0=; b=XG0WueseuNqW3dgx7BZVU0uLajrwRpxRudipfQWQYOlmmufBiGiKGjg4fyqGt2fhne 2JGuid+kntNS3Mkys4CljbWe7U2o8iAYoIffWxqGP1kzOIh2mQXGxtBo6Wkvxunvf2tb u7dfOWRzfB5sT5RpyI/ALOHh7dgQbFZ8YJQ2cR6gkc8pUhH652tJmASxeemEfXSbDS2x 8ixqtrUADjgeAkQ5hjQ3qs7tz24jV479w+lPRYFmOm7/FfnIDlqZrdM2fmR4YH1V/ZXb QDPLnr872Gfsb3beu/TTSVyj0RSQ/E18LnPwC8PYyoLp1qNXcoisIkbN62xI+SLNnSbA 4gPQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="DKa6qf/3"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n18si128967otf.231.2020.02.12.04.19.16; Wed, 12 Feb 2020 04:19:29 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="DKa6qf/3"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727511AbgBLMSC (ORCPT + 99 others); Wed, 12 Feb 2020 07:18:02 -0500 Received: from mail-wr1-f65.google.com ([209.85.221.65]:42640 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725945AbgBLMSB (ORCPT ); Wed, 12 Feb 2020 07:18:01 -0500 Received: by mail-wr1-f65.google.com with SMTP id k11so2036335wrd.9; Wed, 12 Feb 2020 04:18:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:autocrypt:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=R2NyxXoUW9Cj8Ba0zPl8bE0kVh7j7MxxmAH4rY3eAb0=; b=DKa6qf/3AypN6lR+wJ+uw5bX/Rb8qi0D5CaEMOISzOAfVqMC70VprqQt7jiq3t2Iaj /IBtXI+V+RtI+4HA7LdrnQScPp5WsAgFnmnk7/CyMzz34ehkA/9I6GZjDVcj0ou2NghX U4KkNq1VvKA3UfWnMGwaHLCq8EbTL1YHwvrhhgL0V7/0X2zPS+a0gs9vNWxNv7f7rMbG u5Rja/L/jYv8SqfFk2Moss7QB0fFfCCznPANsRzxLjUoNEyA4H+TgcQnOX86tU1MHGyY RBqnLxD4jKnL5rFF3IsE0DruSaWk6sKel19G2TcfvFIc4D6dih3bBO5Z95aCORzzvNPZ 7aUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=R2NyxXoUW9Cj8Ba0zPl8bE0kVh7j7MxxmAH4rY3eAb0=; b=deqzDfOS/7ojXBBMLV8xN+LCCFmoW6tFKPx8LDmWrcKO1SB3t3G8fQ5KEDfUchG3F5 26muIwj/wKd8iZ6UX8wU+LF2x0k+5aXnswlq225BpbnslR2YsrlET2uFwtHgh1W+EJqS Ns/EaUAAewsE9ClAD4w/3BJA5WZE0yAWVfmfBDemliR5KMSBoXnWXuQCk62RptiBm6zb LdekM7sncfKq7aIW6l550CcyYrGArbg0UA2FdQJegWjYzSr7XyL1ebO43aQ0E8dEzel5 tdHVrnYVWgcxnsK4JZcHyGHud407oewn53nhd2e9+5V3zqQ7jYP4OX9Iq/pr5Zbi/FQk VZwA== X-Gm-Message-State: APjAAAVGqcsB3wS1nHYBpoBwzBgfdFSgA+EXFjZNDh8OjLNCZvS99PQD VpHBbZ/6I4psO5XtnjNsJ+o= X-Received: by 2002:adf:db84:: with SMTP id u4mr15284660wri.317.1581509879181; Wed, 12 Feb 2020 04:17:59 -0800 (PST) Received: from ziggy.stardust ([37.223.145.31]) by smtp.gmail.com with ESMTPSA id k13sm388830wrx.59.2020.02.12.04.17.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Feb 2020 04:17:57 -0800 (PST) Subject: Re: [PATCH v3 3/3] memory: mtk-smi: Add bandwidth initial golden setting To: Ming-Fan Chen , Rob Herring Cc: Yong Wu , Evan Green , Joerg Roedel , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, wsd_upstream@mediatek.com References: <1578465691-30692-1-git-send-email-ming-fan.chen@mediatek.com> <1578465691-30692-5-git-send-email-ming-fan.chen@mediatek.com> From: Matthias Brugger Autocrypt: addr=matthias.bgg@gmail.com; prefer-encrypt=mutual; keydata= mQINBFP1zgUBEAC21D6hk7//0kOmsUrE3eZ55kjc9DmFPKIz6l4NggqwQjBNRHIMh04BbCMY fL3eT7ZsYV5nur7zctmJ+vbszoOASXUpfq8M+S5hU2w7sBaVk5rpH9yW8CUWz2+ZpQXPJcFa OhLZuSKB1F5JcvLbETRjNzNU7B3TdS2+zkgQQdEyt7Ij2HXGLJ2w+yG2GuR9/iyCJRf10Okq gTh//XESJZ8S6KlOWbLXRE+yfkKDXQx2Jr1XuVvM3zPqH5FMg8reRVFsQ+vI0b+OlyekT/Xe 0Hwvqkev95GG6x7yseJwI+2ydDH6M5O7fPKFW5mzAdDE2g/K9B4e2tYK6/rA7Fq4cqiAw1+u EgO44+eFgv082xtBez5WNkGn18vtw0LW3ESmKh19u6kEGoi0WZwslCNaGFrS4M7OH+aOJeqK fx5dIv2CEbxc6xnHY7dwkcHikTA4QdbdFeUSuj4YhIZ+0QlDVtS1QEXyvZbZky7ur9rHkZvP ZqlUsLJ2nOqsmahMTIQ8Mgx9SLEShWqD4kOF4zNfPJsgEMB49KbS2o9jxbGB+JKupjNddfxZ HlH1KF8QwCMZEYaTNogrVazuEJzx6JdRpR3sFda/0x5qjTadwIW6Cl9tkqe2h391dOGX1eOA 1ntn9O/39KqSrWNGvm+1raHK+Ev1yPtn0Wxn+0oy1tl67TxUjQARAQABtClNYXR0aGlhcyBC cnVnZ2VyIDxtYXR0aGlhcy5iZ2dAZ21haWwuY29tPokCUgQTAQIAPAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AWIQTmuZIYwPLDJRwsOhfZFAuyVhMC8QUCWt3scQIZAQAKCRDZFAuy VhMC8WzRD/4onkC+gCxG+dvui5SXCJ7bGLCu0xVtiGC673Kz5Aq3heITsERHBV0BqqctOEBy ZozQQe2Hindu9lasOmwfH8+vfTK+2teCgWesoE3g3XKbrOCB4RSrQmXGC3JYx6rcvMlLV/Ch YMRR3qv04BOchnjkGtvm9aZWH52/6XfChyh7XYndTe5F2bqeTjt+kF/ql+xMc4E6pniqIfkv c0wsH4CkBHqoZl9w5e/b9MspTqsU9NszTEOFhy7p2CYw6JEa/vmzR6YDzGs8AihieIXDOfpT DUr0YUlDrwDSrlm/2MjNIPTmSGHH94ScOqu/XmGW/0q1iar/Yr0leomUOeeEzCqQtunqShtE 4Mn2uEixFL+9jiVtMjujr6mphznwpEqObPCZ3IcWqOFEz77rSL+oqFiEA03A2WBDlMm++Sve 9jpkJBLosJRhAYmQ6ey6MFO6Krylw1LXcq5z1XQQavtFRgZoruHZ3XlhT5wcfLJtAqrtfCe0 aQ0kJW+4zj9/So0uxJDAtGuOpDYnmK26dgFN0tAhVuNInEVhtErtLJHeJzFKJzNyQ4GlCaLw jKcwWcqDJcrx9R7LsCu4l2XpKiyxY6fO4O8DnSleVll9NPfAZFZvf8AIy3EQ8BokUsiuUYHz wUo6pclk55PZRaAsHDX/fNr24uC6Eh5oNQ+v4Pax/gtyybkCDQRd1TkHARAAt1BBpmaH+0o+ deSyJotkrpzZZkbSs5ygBniCUGQqXpWqgrc7Uo/qtxOFL91uOsdX1/vsnJO9FyUv3ZNI2Thw NVGCTvCP9E6u4gSSuxEfVyVThCSPvRJHCG2rC+EMAOUMpxokcX9M2b7bBEbcSjeP/E4KTa39 q+JJSeWliaghUfMXXdimT/uxpP5Aa2/D/vcUUGHLelf9TyihHyBohdyNzeEF3v9rq7kdqamZ Ihb+WYrDio/SzqTd1g+wnPJbnu45zkoQrYtBu58n7u8oo+pUummOuTR2b6dcsiB9zJaiVRIg OqL8p3K2fnE8Ewwn6IKHnLTyx5T/r2Z0ikyOeijDumZ0VOPPLTnwmb780Nym3LW1OUMieKtn I3v5GzZyS83NontvsiRd4oPGQDRBT39jAyBr8vDRl/3RpLKuwWBFTs1bYMLu0sYarwowOz8+ Mn+CRFUvRrXxociw5n0P1PgJ7vQey4muCZ4VynH1SeVb3KZ59zcQHksKtpzz2OKhtX8FCeVO mHW9u4x8s/oUVMZCXEq9QrmVhdIvJnBCqq+1bh5UC2Rfjm/vLHwt5hes0HDstbCzLyiA0LTI ADdP77RN2OJbzBkCuWE21YCTLtc8kTQlP+G8m23K5w8k2jleCSKumprCr/5qPyNlkie1HC4E GEAfdfN+uLsFw6qPzSAsmukAEQEAAYkEbAQYAQgAIBYhBOa5khjA8sMlHCw6F9kUC7JWEwLx BQJd1TkHAhsCAkAJENkUC7JWEwLxwXQgBBkBCAAdFiEEUdvKHhzqrUYPB/u8L21+TfbCqH4F Al3VOQcACgkQL21+TfbCqH79RRAAtlb6oAL9y8JM5R1T3v02THFip8OMh7YvEJCnezle9Apq C6Vx26RSQjBV1JwSBv6BpgDBNXarTGCPXcre6KGfX8u1r6hnXAHZNHP7bFGJQiBv5RqGFf45 OhOhbjXCyHc0jrnNjY4M2jTkUC+KIuOzasvggU975nolC8MiaBqfgMB2ab5W+xEiTcNCOg3+ 1SRs5/ZkQ0iyyba2FihSeSw3jTUjPsJBF15xndexoc9jpi0RKuvPiJ191Xa3pzNntIxpsxqc ZkS1HSqPI63/urNezeSejBzW0Xz2Bi/b/5R9Hpxp1AEC3OzabOBATY/1Bmh2eAVK3xpN2Fe1 Zj7HrTgmzBmSefMcSXN0oKQWEI5tHtBbw5XUj0Nw4hMhUtiMfE2HAqcaozsL34sEzi3eethZ IvKnIOTmllsDFMbOBa8oUSoaNg7GzkWSKJ59a9qPJkoj/hJqqeyEXF+WTCUv6FcA8BtBJmVf FppFzLFM/QzF5fgDZmfjc9czjRJHAGHRMMnQlW88iWamjYVye57srNq9pUql6A4lITF7w00B 5PXINFk0lMcNUdkWipu24H6rJhOO6xSP4n6OrCCcGsXsAR5oH3d4TzA9iPYrmfXAXD+hTp82 s+7cEbTsCJ9MMq09/GTCeroTQiqkp50UaR0AvhuPdfjJwVYZfmMS1+5IXA/KY6DbGBAAs5ti AK0ieoZlCv/YxOSMCz10EQWMymD2gghjxojf4iwB2MbGp8UN4+++oKLHz+2j+IL08rd2ioFN YCJBFDVoDRpF/UnrQ8LsH55UZBHuu5XyMkdJzMaHRVQc1rzfluqx+0a/CQ6Cb2q7J2d45nYx 8jMSCsGj1/iU/bKjMBtuh91hsbdWCxMRW0JnGXxcEUklbhA5uGj3W4VYCfTQxwK6JiVt7JYp bX7JdRKIyq3iMDcsTXi7dhhwqsttQRwbBci0UdFGAG4jT5p6u65MMDVTXEgYfZy0674P06qf uSyff73ivwvLR025akzJui8MLU23rWRywXOyTINz8nsPFT4ZSGT1hr5VnIBs/esk/2yFmVoc FAxs1aBO29iHmjJ8D84EJvOcKfh9RKeW8yeBNKXHrcOV4MbMOts9+vpJgBFDnJeLFQPtTHuI kQXT4+yLDvwOVAW9MPLfcHlczq/A/nhGVaG+RKWDfJWNSu/mbhqUQt4J+RFpfx1gmL3yV8NN 7JXABPi5M97PeKdx6qc/c1o3oEHH8iBkWZIYMS9fd6rtAqV3+KH5Ors7tQVtwUIDYEvttmeO ifvpW6U/4au4zBYfvvXagbyXJhG9mZvz+jN1cr0/G2ZC93IbjFFwUmHtXS4ttQ4pbrX6fjTe lq5vmROjiWirpZGm+WA3Vx9QRjqfMdS5Ag0EXdU5SAEQAJu/Jk58uOB8HSGDSuGUB+lOacXC bVOOSywZkq+Ayv+3q/XIabyeaYMwhriNuXHjUxIORQoWHIHzTCqsAgHpJFfSHoM4ulCuOPFt XjqfEHkA0urB6S0jnvJ6ev875lL4Yi6JJO7WQYRs/l7OakJiT13GoOwDIn7hHH/PGUqQoZlA d1n5SVdg6cRd7EqJ+RMNoud7ply6nUSCRMNWbNqbgyWjKsD98CMjHa33SB9WQQSQyFlf+dz+ dpirWENCoY3vvwKJaSpfeqKYuqPVSxnqpKXqqyjNnG9W46OWZp+JV5ejbyUR/2U+vMwbTilL cIUpTgdmxPCA6J0GQjmKNsNKKYgIMn6W4o/LoiO7IgROm1sdn0KbJouCa2QZoQ0+p/7mJXhl tA0XGZhNlI3npD1lLpjdd42lWboU4VeuUp4VNOXIWU/L1NZwEwMIqzFXl4HmRi8MYbHHbpN5 zW+VUrFfeRDPyjrYpax+vWS+l658PPH+sWmhj3VclIoAU1nP33FrsNfp5BiQzao30rwe4ntd eEdPENvGmLfCwiUV2DNVrmJaE3CIUUl1KIRoB5oe7rJeOvf0WuQhWjIU98glXIrh3WYd7vsf jtbEXDoWhVtwZMShMvp7ccPCe2c4YBToIthxpDhoDPUdNwOssHNLD8G4JIBexwi4q7IT9lP6 sVstwvA5ABEBAAGJAjYEGAEIACAWIQTmuZIYwPLDJRwsOhfZFAuyVhMC8QUCXdU5SAIbDAAK CRDZFAuyVhMC8bXXD/4xyfbyPGnRYtR0KFlCgkG2XWeWSR2shSiM1PZGRPxR888zA2WBYHAk 7NpJlFchpaErV6WdFrXQjDAd9YwaEHucfS7SAhxIqdIqzV5vNFrMjwhB1N8MfdUJDpgyX7Zu k/Phd5aoZXNwsCRqaD2OwFZXr81zSXwE2UdPmIfTYTjeVsOAI7GZ7akCsRPK64ni0XfoXue2 XUSrUUTRimTkuMHrTYaHY3544a+GduQQLLA+avseLmjvKHxsU4zna0p0Yb4czwoJj+wSkVGQ NMDbxcY26CMPK204jhRm9RG687qq6691hbiuAtWABeAsl1AS+mdS7aP/4uOM4kFCvXYgIHxP /BoVz9CZTMEVAZVzbRKyYCLUf1wLhcHzugTiONz9fWMBLLskKvq7m1tlr61mNgY9nVwwClMU uE7i1H9r/2/UXLd+pY82zcXhFrfmKuCDmOkB5xPsOMVQJH8I0/lbqfLAqfsxSb/X1VKaP243 jzi+DzD9cvj2K6eD5j5kcKJJQactXqfJvF1Eb+OnxlB1BCLE8D1rNkPO5O742Mq3MgDmq19l +abzEL6QDAAxn9md8KwrA3RtucNh87cHlDXfUBKa7SRvBjTczDg+HEPNk2u3hrz1j3l2rliQ y1UfYx7Vk/TrdwUIJgKS8QAr8Lw9WuvY2hSqL9vEjx8VAkPWNWPwrQ== Message-ID: <8d168fcc-3b85-a893-316b-8d7b4d29dea4@gmail.com> Date: Wed, 12 Feb 2020 13:17:56 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <1578465691-30692-5-git-send-email-ming-fan.chen@mediatek.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/01/2020 07:41, Ming-Fan Chen wrote: > SMI bandwidth initial golden setting for MT6779 make sure > better performance of memory control for multimedia modules. > > changelog since v2: > Define local variable from long to short > Merge writel_relaxed into one line > Remove SMI_LARB_SW_FLAG in smi-larb > > Signed-off-by: Ming-Fan Chen > --- > drivers/memory/mtk-smi.c | 118 +++++++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 117 insertions(+), 1 deletion(-) > > diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c > index d0b747a..222ac7e 100644 > --- a/drivers/memory/mtk-smi.c > +++ b/drivers/memory/mtk-smi.c > @@ -41,21 +41,47 @@ > #define SMI_LARB_NONSEC_CON(id) (0x380 + ((id) * 4)) > #define F_MMU_EN BIT(0) > > +#define SMI_LARB_CMD_THRT_CON 0x24 > +#define SMI_LARB_OSTDL_PORT 0x200 > +#define SMI_LARB_OSTDL_PORTx(id) (SMI_LARB_OSTDL_PORT + (((id) & 0x1f) << 2)) > + > /* SMI COMMON */ > +#define SMI_L1LEN 0x100 > +#define SMI_L1ARB0 0x104 > +#define SMI_L1ARB(id) (SMI_L1ARB0 + (((id) & 0x7) << 2)) > + > #define SMI_BUS_SEL 0x220 > #define SMI_BUS_LARB_SHIFT(larbid) ((larbid) << 1) > /* All are MMU0 defaultly. Only specialize mmu1 here. */ > #define F_MMU1_LARB(larbid) (0x1 << SMI_BUS_LARB_SHIFT(larbid)) > > +#define SMI_M4U_TH 0x234 > +#define SMI_FIFO_TH1 0x238 > +#define SMI_FIFO_TH2 0x23c > +#define SMI_DCM 0x300 > +#define SMI_DUMMY 0x444 > + > +#define SMI_LARB_PORT_NR_MAX 32 > +#define SMI_LARB_MISC_NR 1 > + > enum mtk_smi_gen { > MTK_SMI_GEN1, > MTK_SMI_GEN2 > }; > > +struct mtk_smi_reg_pair { > + u16 offset; > + u32 value; > +}; > + > struct mtk_smi_common_plat { > enum mtk_smi_gen gen; > bool has_gals; > u32 bus_sel; /* Balance some larbs to enter mmu0 or mmu1 */ > + bool has_bwc; bwc = bandwith configuration ? > + u8 larb_nr; > + const u16 *l1arb; > + const struct mtk_smi_reg_pair *misc; maybe encapsulate this in a new struct mtk_smi_common_bwidth_config or something like this? > }; > > struct mtk_smi_larb_gen { > @@ -63,6 +89,9 @@ struct mtk_smi_larb_gen { > void (*config_port)(struct device *); > unsigned int larb_direct_to_common_mask; > bool has_gals; > + bool has_bwc; > + const u8 (*ostdl)[SMI_LARB_PORT_NR_MAX]; array of pointers? maybe: const u8 *ostdl[SMI_LARB_PORT_NR_MAX]; or even better const u8 **ostdl; > + const struct mtk_smi_reg_pair (*misc)[SMI_LARB_MISC_NR]; Same here. > }; > > struct mtk_smi { > @@ -159,6 +188,8 @@ void mtk_smi_larb_put(struct device *larbdev) > static void mtk_smi_larb_config_port_gen2_general(struct device *dev) > { > struct mtk_smi_larb *larb = dev_get_drvdata(dev); > + const struct mtk_smi_reg_pair *misc; > + const u8 *ostdl; > u32 reg; > int i; > > @@ -170,6 +201,18 @@ static void mtk_smi_larb_config_port_gen2_general(struct device *dev) > reg |= F_MMU_EN; > writel(reg, larb->base + SMI_LARB_NONSEC_CON(i)); > } > + > + if (!larb->larb_gen->has_bwc) I'd prefer if (larb->larb_gen->has_bwc) { ... } > + return; > + > + for (i = 0, ostdl = larb->larb_gen->ostdl[larb->larbid]; > + i < SMI_LARB_PORT_NR_MAX; i++) ostdl = larb->larb_gen->ostdl[larb->larbid]; for (i = 0, ; i < SMI_LARB_PORT_NR_MAX; i++) > + writel_relaxed(ostdl[i], larb->base + SMI_LARB_OSTDL_PORTx(i)); > + > + for (i = 0, misc = larb->larb_gen->misc[larb->larbid]; > + i < SMI_LARB_MISC_NR; i++) same here. > + writel_relaxed(misc[i].value, larb->base + misc[i].offset); new line here. > + wmb(); /* make sure settings are written */ > } > > static void mtk_smi_larb_config_port_mt8173(struct device *dev) > @@ -239,11 +282,53 @@ static void mtk_smi_larb_config_port_gen1(struct device *dev) > .larb_direct_to_common_mask = BIT(8) | BIT(9), /* bdpsys */ > }; > > +static const u8 mtk_smi_larb_mt6779_ostdl[][SMI_LARB_PORT_NR_MAX] = { static const u8 mtk_smi_larb_mt6779_ostdl[MTK_LARB_NR_MAX][SMI_LARB_PORT_NR_MAX] otherwise if we forget a line, the driver could access random memory. > + {0x28, 0x28, 0x01, 0x28, 0x01, 0x01, 0x0a, 0x0a, 0x28,}, > + {0x28, 0x01, 0x28, 0x28, 0x0a, 0x01, 0x01, 0x0d, 0x0d, 0x07, > + 0x01, 0x07, 0x01, 0x28,}, > + {0x18, 0x01, 0x08, 0x01, 0x01, 0x01, 0x01, 0x01, 0x01, 0x02, > + 0x01, 0x01}, > + {0x01, 0x03, 0x02, 0x01, 0x01, 0x01, 0x01, 0x04, 0x02, 0x01, > + 0x04, 0x01, 0x01, 0x01, 0x01, 0x04, 0x0b, 0x13, 0x14,}, > + {}, > + {0x13, 0x0f, 0x0d, 0x07, 0x07, 0x04, 0x03, 0x01, 0x03, 0x01, > + 0x05, 0x0c, 0x01, 0x01, 0x08, 0x06, 0x02, 0x01, 0x08, 0x08, > + 0x01, 0x01, 0x01, 0x01, 0x01, 0x01,}, > + {0x01, 0x01, 0x01,}, > + {0x01, 0x01, 0x01, 0x01,}, > + {0x01, 0x01, 0x01, 0x01, 0x01, 0x01, 0x01, 0x01, 0x01, 0x01,}, > + {0x1f, 0x1a, 0x02, 0x04, 0x1f, 0x02, 0x14, 0x01, 0x1f, 0x04, > + 0x04, 0x01, 0x01, 0x01, 0x02, 0x02, 0x04, 0x02, 0x01, 0x02, > + 0x04, 0x02, 0x02, 0x01,}, > + {0x1f, 0x1a, 0x02, 0x04, 0x1f, 0x02, 0x14, 0x01, 0x1f, 0x1a, > + 0x02, 0x04, 0x1f, 0x02, 0x14, 0x01, 0x01, 0x02, 0x02, 0x04, > + 0x02, 0x0a, 0x02, 0x02, 0x04, 0x02, 0x0a, 0x02, 0x04, 0x02, 0x04,}, > + {0x01, 0x01, 0x01, 0x01, 0x01,}, > +}; > + > +static const struct mtk_smi_reg_pair > +mtk_smi_larb_mt6779_misc[][SMI_LARB_MISC_NR] = { same here. > + {{SMI_LARB_CMD_THRT_CON, 0x370256},}, > + {{SMI_LARB_CMD_THRT_CON, 0x300256},}, > + {{SMI_LARB_CMD_THRT_CON, 0x370256},}, > + {}, > + {{SMI_LARB_CMD_THRT_CON, 0x300256},}, > + {{SMI_LARB_CMD_THRT_CON, 0x300256},}, > + {{SMI_LARB_CMD_THRT_CON, 0x300256},}, > + {{SMI_LARB_CMD_THRT_CON, 0x300256},}, > + {{SMI_LARB_CMD_THRT_CON, 0x370256},}, > + {{SMI_LARB_CMD_THRT_CON, 0x370256},}, > + {{SMI_LARB_CMD_THRT_CON, 0x370256},}, > +}; > + > static const struct mtk_smi_larb_gen mtk_smi_larb_mt6779 = { > .config_port = mtk_smi_larb_config_port_gen2_general, > .larb_direct_to_common_mask = > BIT(4) | BIT(6) | BIT(11) | BIT(12) | BIT(13), > /* DUMMY | IPU0 | IPU1 | CCU | MDLA */ > + .has_bwc = true, > + .ostdl = mtk_smi_larb_mt6779_ostdl, > + .misc = mtk_smi_larb_mt6779_misc, > }; > > static const struct mtk_smi_larb_gen mtk_smi_larb_mt8183 = { > @@ -397,11 +482,30 @@ static int __maybe_unused mtk_smi_larb_suspend(struct device *dev) > .gen = MTK_SMI_GEN2, > }; > > +static const u16 mtk_smi_common_mt6779_l1arb[] = { > + 0x1000, 0x1000, 0x1000, 0x1000, 0x1000, 0x1000, 0x1000, 0x1000, > +}; > + > +static const struct > +mtk_smi_reg_pair mtk_smi_common_mt6779_misc[SMI_COMMON_MISC_NR] = { > + {SMI_L1LEN, 0xb}, > + {SMI_M4U_TH, 0xe100e10}, > + {SMI_FIFO_TH1, 0x506090a}, > + {SMI_FIFO_TH2, 0x506090a}, > + {SMI_DCM, 0x4f1}, > + {SMI_DUMMY, 0x1}, > +}; > + > static const struct mtk_smi_common_plat mtk_smi_common_mt6779 = { > .gen = MTK_SMI_GEN2, > .has_gals = true, > .bus_sel = F_MMU1_LARB(1) | F_MMU1_LARB(2) | F_MMU1_LARB(4) | > F_MMU1_LARB(5) | F_MMU1_LARB(6) | F_MMU1_LARB(7), > + .has_bwc = true, > + .larb_nr = ARRAY_SIZE(mtk_smi_common_mt6779_l1arb), > + .l1arb = mtk_smi_common_mt6779_l1arb, > + .misc_nr = ARRAY_SIZE(mtk_smi_common_mt6779_misc), > + .misc = mtk_smi_common_mt6779_misc, > }; > > static const struct mtk_smi_common_plat mtk_smi_common_mt8183 = { > @@ -506,7 +610,7 @@ static int __maybe_unused mtk_smi_common_resume(struct device *dev) > { > struct mtk_smi *common = dev_get_drvdata(dev); > u32 bus_sel = common->plat->bus_sel; > - int ret; > + int i, ret; > > ret = mtk_smi_clk_enable(common); > if (ret) { > @@ -516,6 +620,18 @@ static int __maybe_unused mtk_smi_common_resume(struct device *dev) > > if (common->plat->gen == MTK_SMI_GEN2 && bus_sel) > writel(bus_sel, common->base + SMI_BUS_SEL); > + > + if (!common->plat->has_bwc) > + return 0; > + if (common->plat->has_bwc) { ... } return 0; > + for (i = 0; i < common->plat->larb_nr; i++) > + writel_relaxed(common->plat->l1arb[i], > + common->base + SMI_L1ARB(i)); > + > + for (i = 0; i < common->plat->misc_nr; i++) > + writel_relaxed(common->plat->misc[i].value, > + common->base + common->plat->misc[i].value); > + wmb(); /* make sure settings are written */ > return 0; > } > >