Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-SDR: 4tDKme4gk+e/6KCjbBhr68l8abtwgE1ipkY75vJzIfbSbYtBuMtgxwTVeZoGa3cieeZzyzll/U
 e0z0MpXvlffbBqdQih21NtvL1zJUNRxKISd7HihnkB+gMD28CudTlXmI6Pt7NYGqmxftzla/Bp
 /jUPAcm9hlriUZ3X4NUZ+UiTgPS35wUuyd1XginGQ3wDChGpUZHpoNYhZUpengC1eo6kGJ0W6I
 +UhInvvtpagIrG3Ca8l/8IlavvkrXrt46PYgCTD1JWo4pkYLJKuWG3lX2hL5/+9OVOhZTr+Ngq
 RY4=
From:   Avri Altman <Avri.Altman@wdc.com>
To:     Can Guo <cang@codeaurora.org>,
        "asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
        "nguyenb@codeaurora.org" <nguyenb@codeaurora.org>,
        "hongwus@codeaurora.org" <hongwus@codeaurora.org>,
        "rnayak@codeaurora.org" <rnayak@codeaurora.org>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "kernel-team@android.com" <kernel-team@android.com>,
        "saravanak@google.com" <saravanak@google.com>,
        "salyzyn@google.com" <salyzyn@google.com>
CC:     Alim Akhtar <alim.akhtar@samsung.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Bean Huo <beanhuo@micron.com>,
        Stanley Chu <stanley.chu@mediatek.com>,
        Bart Van Assche <bvanassche@acm.org>,
        Venkat Gopalakrishnan <venkatg@codeaurora.org>,
        Tomas Winkler <tomas.winkler@intel.com>,
        open list <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v1 1/2] scsi: ufs: Use ufshcd_config_pwr_mode() when scale
 gear
Thread-Topic: [PATCH v1 1/2] scsi: ufs: Use ufshcd_config_pwr_mode() when
 scale gear
Thread-Index: AQHV4Wa4/7BeUknJikSF1o9Bj2JpaKgXdp1Q
Date:   Wed, 12 Feb 2020 12:21:43 +0000
Message-ID: <MN2PR04MB6991136AD340D28D930F27F3FC1B0@MN2PR04MB6991.namprd04.prod.outlook.com>
References: <1581485910-8307-1-git-send-email-cang@codeaurora.org>
 <1581485910-8307-2-git-send-email-cang@codeaurora.org>
In-Reply-To: <1581485910-8307-2-git-send-email-cang@codeaurora.org>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: ed26d036-ac11-489a-a5d3-08d7afb61f4a
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Feb 2020 12:21:43.9392
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: X4HuL70Bgzfl0C+fJlE29sBxthKn3qMA8B5ohWtd2Aleu6MIh1DZg0q9f4eFOsnIMVDJiBb2Xwf6CGK8Av6MaA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR04MB6976
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

>=20
> When scale gear, use ufshcd_config_pwr_mode() instead of
> ufshcd_change_power_mode() so that
> vops_pwr_change_notify(PRE_CHANGE)
> can be utilized to allow vendors use customized settings before change
> the power mode.
>=20
> Signed-off-by: Can Guo <cang@codeaurora.org>
> ---
>  drivers/scsi/ufs/ufshcd.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>=20
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index adcce41..67bd4f2 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -1059,8 +1059,7 @@ static int ufshcd_scale_gear(struct ufs_hba *hba,
> bool scale_up)
>         }
>=20
>         /* check if the power mode needs to be changed or not? */
> -       ret =3D ufshcd_change_power_mode(hba, &new_pwr_info);
> -
> +       ret =3D ufshcd_config_pwr_mode(hba, &new_pwr_info);

You might want to inform ufshcd_config_pwr_mode() of the caller,
As now it will be called much more frequently, and you want/don't want
To call your vops on probe but not on scale_gear?

Also, Alim exported ufshcd_config_pwr_mode a while ago,
In commit 0d846e703dc8 "scsi: ufs: make ufshcd_config_pwr_mode of non-stati=
c func"),
But nobody uses it outside ufshcd - so maybe revert this commit as part of =
this series?


>         if (ret)
>                 dev_err(hba->dev, "%s: failed err %d, old gear: (tx %d rx=
 %d), new
> gear: (tx %d rx %d)",
>                         __func__, ret,
> @@ -4126,8 +4125,6 @@ int ufshcd_config_pwr_mode(struct ufs_hba *hba,
>                 memcpy(&final_params, desired_pwr_mode, sizeof(final_para=
ms));
>=20
>         ret =3D ufshcd_change_power_mode(hba, &final_params);
> -       if (!ret)
> -               ufshcd_print_pwr_info(hba);
>=20
>         return ret;
>  }
> @@ -7157,6 +7154,7 @@ static int ufshcd_probe_hba(struct ufs_hba *hba,
> bool async)
>                                         __func__, ret);
>                         goto out;
>                 }
> +               ufshcd_print_pwr_info(hba);
>         }
>=20
>         /* set the state as operational after switching to desired gear *=
/
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
> Forum,
> a Linux Foundation Collaborative Project