Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp6008206ybv; Wed, 12 Feb 2020 04:25:37 -0800 (PST) X-Google-Smtp-Source: APXvYqw0cZMw8McjpfH9EweDhiOCe4MyPylPsE1j3L5KuQb/jhbAN+TInVPkuoCJDiXpRvVpiZnM X-Received: by 2002:a9d:7386:: with SMTP id j6mr8860173otk.336.1581510336910; Wed, 12 Feb 2020 04:25:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581510336; cv=none; d=google.com; s=arc-20160816; b=hiOqiTWVr/1kUdJXOfBAeyl8lVttdB3H8h9C6kso8EiLDPCJoKWaMu5OGO8o6dh9Yz 5y6nyJIe/rrelzFVXO+qywvBzEPiLRurece4eKV7j+wMLpzzjg0J6ppUQr5o1PFDnxnQ NOvjD2CfdgPDkM7B6+tTZ8mCDAib0R7VVo0XIMjj+5oLuC+Z7fbLfYNmP0TCe14e2HPw chHrdfoP739s2bU1CfSRvEic8tEezowCnycKErviQCrfbC0x5XtA25h9No5t+4vJ5cqy EVsbm1ywW7v30VRuJpQqh4327an2k2pWr7Huy3+hhsLEh8Tl0E+WRFzgP5wPOsKgnIGw r8kA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:content-disposition :mime-version:message-id:subject:to:from:date:dkim-signature; bh=x/nxEaTTP4mdZANLaqJuiHgW2OIpQlw3HGG1GiDrG8k=; b=b0XzkcGabwzDTrX9nVT/tqadD42Cu4FZJ4FvBr5wihzsFmNVKVNEOMAxD5oeMGibjS U/nYhPhRS3uC0+JoN6PR14pK4aNg3YEvIoCOzbHpdor/SBuXBi49BGKdAPMNUQ1oheYq DJsipZD1IqvDPsKcWACwFK3KUwcInqcLQupMgUwiuidQeR9LQMj+PrGhrnyCAigCJ/ux 5z3LqkIjBFS5yLt2KxbGSV7l3b0kZ2SxBN5dn8AwFA54BgdTTJiGBzY9Cow+kXqAiUq7 LcWw7MUvl+euX1YqfpcyBr88LjRa+mhEqGZj8Cm7Z7+4894zle7/Q2fC0fuLkqtiDJqf jPTQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@es-iitr-ac-in.20150623.gappssmtp.com header.s=20150623 header.b=ITMK8LOA; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=iitr.ac.in Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d14si3177333oic.201.2020.02.12.04.25.24; Wed, 12 Feb 2020 04:25:36 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@es-iitr-ac-in.20150623.gappssmtp.com header.s=20150623 header.b=ITMK8LOA; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=iitr.ac.in Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727732AbgBLMYp (ORCPT + 99 others); Wed, 12 Feb 2020 07:24:45 -0500 Received: from mail-pf1-f194.google.com ([209.85.210.194]:45866 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725887AbgBLMYo (ORCPT ); Wed, 12 Feb 2020 07:24:44 -0500 Received: by mail-pf1-f194.google.com with SMTP id 2so1154918pfg.12 for ; Wed, 12 Feb 2020 04:24:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=es-iitr-ac-in.20150623.gappssmtp.com; s=20150623; h=date:from:to:subject:message-id:mime-version:content-disposition :user-agent; bh=x/nxEaTTP4mdZANLaqJuiHgW2OIpQlw3HGG1GiDrG8k=; b=ITMK8LOAm4w9qmTRfMOeA37gwDDOLpQQ/8a2Z3SRrSpfdlsQ0/vxwhtmYgNTGgR1Cz tlws5/87h5rm8Z6PQJxpFd3ov2vMJxFSM6bJG79plkbEjDjDO+E3/CHiUJ+n6tI/QUhI FUTwdI6r/grSgrkn7EX0gxaQ9scjqFcMdX++7fjMNzPIZ6jPcAGLq2Uiwy7OC8o+nUzE FCNvivZNq57PWuE1TFEhD1sbp0hJSUSxcwXUIfRKVayNitJ5/uS5XbA9EDDaXizHEcWo 3lQukAIR08TiHoHzX4cy9Y1tBOHDl6ebDOCZ0NwN0duE2dhdG4LMiV1x2EO+aVhdgR5q c4Qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:mime-version :content-disposition:user-agent; bh=x/nxEaTTP4mdZANLaqJuiHgW2OIpQlw3HGG1GiDrG8k=; b=p1oFkU0XxERrT9MufpVmHjBwkxk6ZUtraHmS5zPkfABbriX7OZooM+LntbOk6uwwq5 Xe/AQ6s02WRKdDorwgHySVLOfIkh1j2g7yRHqeUfPWhkzgI1ARfCjcVKwhKbpGUqZFG1 4DcmNnRTL00PWiSCig4OjRrpgQcxBUUqmYvj5POjIUkqp4/mxnm7iNlwj37121r8PQPb mWNJ9+oAVDQ7zp5ndJe2FUy/U2czJJfeYlOpFLTZKGt906OxdfZiuabjkcYXJrTrSqRP IaJiB+dKPaQMrDNEZ59ZCbmXf3GPtpoaBogat1uo4tuzz6tr0H8BQXnl9Uk5P/tSu+tk dZ9Q== X-Gm-Message-State: APjAAAU+p5aKIdyl6Gz6EFbeOC1KEHTnLelyi+J/ijCqv7HZR5KAUAl3 3w57CsDUHs6XKII7fyMDeGRT4Q== X-Received: by 2002:a63:8f49:: with SMTP id r9mr12333824pgn.190.1581510283487; Wed, 12 Feb 2020 04:24:43 -0800 (PST) Received: from kaaira-HP-Pavilion-Notebook ([103.37.201.171]) by smtp.gmail.com with ESMTPSA id l69sm313535pgd.1.2020.02.12.04.24.40 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 12 Feb 2020 04:24:42 -0800 (PST) Date: Wed, 12 Feb 2020 17:54:36 +0530 From: Kaaira Gupta To: Rob Springer , Todd Poynor , Ben Chan , Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH] staging:gasket:gasket_core.c:unified quoted string split across lines in one line Message-ID: <20200212122436.GA25104@kaaira-HP-Pavilion-Notebook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When the driver tries to map a region, but the region has certain permissions, or when it attempts to open gasket with tgid, or when it realeases device node; the logs are displayed in one line only while the code has the strings split in two lines which makes it difficult for developers to search for code based on the log messages. So, this patch fixes three warnings of 'quoted string split across lines' in gasket_core.c by merging the strings in one line. Signed-off-by: Kaaira Gupta --- drivers/staging/gasket/gasket_core.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/staging/gasket/gasket_core.c b/drivers/staging/gasket/gasket_core.c index cd8be80d2076..411aaf248b37 100644 --- a/drivers/staging/gasket/gasket_core.c +++ b/drivers/staging/gasket/gasket_core.c @@ -692,8 +692,7 @@ static bool gasket_mmap_has_permissions(struct gasket_dev *gasket_dev, (vma->vm_flags & (VM_WRITE | VM_READ | VM_EXEC)); if (requested_permissions & ~(bar_permissions)) { dev_dbg(gasket_dev->dev, - "Attempting to map a region with requested permissions " - "0x%x, but region has permissions 0x%x.\n", + "Attempting to map a region with requested permissions 0x%x, but region has permissions 0x%x.\n", requested_permissions, bar_permissions); return false; } @@ -1180,8 +1179,7 @@ static int gasket_open(struct inode *inode, struct file *filp) inode->i_size = 0; dev_dbg(gasket_dev->dev, - "Attempting to open with tgid %u (%s) (f_mode: 0%03o, " - "fmode_write: %d is_root: %u)\n", + "Attempting to open with tgid %u (%s) (f_mode: 0%03o, fmode_write: %d is_root: %u)\n", current->tgid, task_name, filp->f_mode, (filp->f_mode & FMODE_WRITE), is_root); @@ -1258,8 +1256,7 @@ static int gasket_release(struct inode *inode, struct file *file) mutex_lock(&gasket_dev->mutex); dev_dbg(gasket_dev->dev, - "Releasing device node. Call origin: tgid %u (%s) " - "(f_mode: 0%03o, fmode_write: %d, is_root: %u)\n", + "Releasing device node. Call origin: tgid %u (%s) (f_mode: 0%03o, fmode_write: %d, is_root: %u)\n", current->tgid, task_name, file->f_mode, (file->f_mode & FMODE_WRITE), is_root); dev_dbg(gasket_dev->dev, "Current open count (owning tgid %u): %d\n", -- 2.17.1