Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750962AbWBGQpz (ORCPT ); Tue, 7 Feb 2006 11:45:55 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932235AbWBGQpz (ORCPT ); Tue, 7 Feb 2006 11:45:55 -0500 Received: from ns1.coraid.com ([65.14.39.133]:59522 "EHLO coraid.com") by vger.kernel.org with ESMTP id S1750961AbWBGQpz (ORCPT ); Tue, 7 Feb 2006 11:45:55 -0500 Message-ID: Date: Tue, 7 Feb 2006 11:37:24 -0500 To: linux-kernel@vger.kernel.org Cc: ecashin@coraid.com, Greg K-H Subject: [PATCH 2.6.16-rc2-git2-gkh] aoe [2/3]: don't request ATA device ID on ATA error References: From: "Ed L. Cashin" Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1344 Lines: 34 Signed-off-by: "Ed L. Cashin" On an ATA error response, take the device down instead of sending another ATA device identify command. diff -upr 2.6.16-rc2-git2-gkh-orig/drivers/block/aoe/aoecmd.c 2.6.16-rc2-git2-gkh-aoe/drivers/block/aoe/aoecmd.c --- 2.6.16-rc2-git2-gkh-orig/drivers/block/aoe/aoecmd.c 2006-02-06 17:41:05.000000000 -0500 +++ 2.6.16-rc2-git2-gkh-aoe/drivers/block/aoe/aoecmd.c 2006-02-06 17:56:59.000000000 -0500 @@ -517,6 +517,8 @@ aoecmd_ata_rsp(struct sk_buff *skb) ahout = (struct aoe_atahdr *) (f->data + sizeof(struct aoe_hdr)); buf = f->buf; + if (ahout->cmdstat == WIN_IDENTIFY) + d->flags &= ~DEVFL_PAUSE; if (ahin->cmdstat & 0xa9) { /* these bits cleared on success */ printk(KERN_CRIT "aoe: aoecmd_ata_rsp: ata error cmd=%2.2Xh " "stat=%2.2Xh from e%ld.%ld\n", @@ -549,7 +551,6 @@ aoecmd_ata_rsp(struct sk_buff *skb) return; } ataid_complete(d, (char *) (ahin+1)); - d->flags &= ~DEVFL_PAUSE; break; default: printk(KERN_INFO "aoe: aoecmd_ata_rsp: unrecognized " -- "Ed L. Cashin" - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/