Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200212164714.7733-1-pbonzini@redhat.com>
In-Reply-To: <20200212164714.7733-1-pbonzini@redhat.com>
From:   Linus Torvalds <torvalds@linux-foundation.org>
Date:   Wed, 12 Feb 2020 10:53:46 -0800
Message-ID: <CAHk-=wh6KEgPz_7TFqSgg3T29SrCBU+h64t=BWyCKwJOrk3RLQ@mail.gmail.com>
Subject: Re: [GIT PULL] KVM changes for Linux 5.6-rc2
To:     Paolo Bonzini <pbonzini@redhat.com>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        KVM list <kvm@vger.kernel.org>, rkrcmar@kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Feb 12, 2020 at 8:47 AM Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> A mix of cleanups and bugfixes, some of them slightly more invasive than usual
> but still not worth waiting for 5.7.

What? No.

> Oliver Upton (4):
>       KVM: nVMX: Emulate MTF when performing instruction emulation

This was committed today, and it's complete and utter garbage:

   CommitDate: 7 hours ago

It doesn't even compile. Just in the patch itself - so this is not a
merge issue, I see this:

          int (*skip_emulated_instruction)(struct kvm_vcpu *vcpu);
  ..
  @@ -1599,6 +1599,40 @@ static int skip_emulated_instruction(struct
kvm_vcpu *vcpu)
  ..
  +static void vmx_skip_emulated_instruction(struct kvm_vcpu *vcpu)
  +       return skip_emulated_instruction(vcpu);
  ..
  -       .skip_emulated_instruction = skip_emulated_instruction,
  +       .skip_emulated_instruction = vmx_skip_emulated_instruction,

ie note how that vmx_skip_emulated_instruction() is a void function,
and then you have

         return skip_emulated_instruction(vcpu);

in it, and you assign that garbage to ".skip_emulated_instruction"
which is supposed to be returning 'int'.

So this clearly never even got a _whiff_ of build-testing. The thing
is completely broken.

Stop sending me garbage.

You're now on my shit-list, which means that I want to see only (a)
pure fixes and (b) well-tested such. Nothing else will be pulled.

                    Linus