Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200211011631.7619-1-zzyiwei@google.com> <20200210211951.1633c7d0@rorschach.local.home>
 <CAKT=dDm+UKqa7j744iTsvYs+jqrdOHpTqdksRUjDe-6vqkigew@mail.gmail.com>
 <20200210221521.59928416@rorschach.local.home> <CAKT=dDk+CiMQ_-f6Daa_ea2FOW=De6PKmcyiGrm4KEkVbH2fDQ@mail.gmail.com>
 <20200212143751.0114fe78@gandalf.local.home>
In-Reply-To: <20200212143751.0114fe78@gandalf.local.home>
From:   Yiwei Zhang <zzyiwei@google.com>
Date:   Wed, 12 Feb 2020 11:40:18 -0800
Message-ID: <CAKT=dDnnSrkGx1KN8t0-c7cqXCCE=xj=usUT9COfmTDbirx5WQ@mail.gmail.com>
Subject: Re: [PATCH] Add gpu memory tracepoints
To:     Steven Rostedt <rostedt@goodmis.org>
Cc:     mingo@redhat.com, linux-kernel@vger.kernel.org,
        Prahlad Kilambi <prahladk@google.com>,
        Joel Fernandes <joelaf@google.com>,
        android-kernel <android-kernel@google.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Thanks for the info! I'll update the patch accordingly.

Best regards,
Yiwei

On Wed, Feb 12, 2020 at 11:37 AM Steven Rostedt <rostedt@goodmis.org> wrote:
>
> On Wed, 12 Feb 2020 11:26:08 -0800
> Yiwei Zhang <zzyiwei@google.com> wrote:
>
> > Hi Steven,
> >
> > I can move the stuff out from the kernel/trace. Then can we still
> > leave include/trace/events/gpu_mem.h where it is right now? Or do we
> > have to move that out as well? Because we would need a non-drm common
> > header place for the tracepoint so that downstream drivers can find
> > the tracepoint definition.
> >
>
> You can leave the header there. The include/trace/events/ is the place
> to put trace event headers for common code.
>
> It just did not belong in kernel/trace/
>
> Thanks!
>
> -- Steve