Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 12 Feb 2020 17:12:49 -0500
From:   Tejun Heo <tj@kernel.org>
To:     madhuparnabhowmik10@gmail.com
Cc:     lizefan@huawei.com, cgroups@vger.kernel.org,
        linux-kernel@vger.kernel.org, joel@joelfernandes.org,
        rcu@vger.kernel.org, frextrite@gmail.com
Subject: Re: [PATCH] cgroup.c: Use built-in RCU list checking
Message-ID: <20200212221249.GJ80993@mtj.thefacebook.com>
References: <20200118031051.28776-1-madhuparnabhowmik10@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200118031051.28776-1-madhuparnabhowmik10@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, Jan 18, 2020 at 08:40:51AM +0530, madhuparnabhowmik10@gmail.com wrote:
> From: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
> 
> list_for_each_entry_rcu has built-in RCU and lock checking.
> Pass cond argument to list_for_each_entry_rcu() to silence
> false lockdep warning when  CONFIG_PROVE_RCU_LIST is enabled
> by default.
> 
> Even though the function css_next_child() already checks if
> cgroup_mutex or rcu_read_lock() is held using
> cgroup_assert_mutex_or_rcu_locked(), there is a need to pass
> cond to list_for_each_entry_rcu() to avoid false positive
> lockdep warning.
> 
> Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>

Applied to cgroup/for-5.7.

Thanks.

-- 
tejun