Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp6566877ybv; Wed, 12 Feb 2020 15:03:30 -0800 (PST) X-Google-Smtp-Source: APXvYqwc+YqGwqi/ctl/V1uc1h8BQdQyN0U5/KXln0deB1kTdS7SqiQGxray08IlpAi9JM/84Hq5 X-Received: by 2002:aca:f587:: with SMTP id t129mr958736oih.143.1581548610343; Wed, 12 Feb 2020 15:03:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581548610; cv=none; d=google.com; s=arc-20160816; b=DqkrfJPaF54caCNZsq64ygcwyXo+Er89E9YOjupC9Di96BX6Fenpc7y0yN6gf35Wmv T9NaMxN3kVt5WeCUy4wIh0x6xksrFz5NRc6DDa5VcdLFHDsVSfXu87ivbyz/QSU2le0Z Qa4yZlsHFEcwdalKGpxNr8rhYCRN5g6XXWRPJ/CdMFtBjPolnzN1UWEj4wxln3ly3kX1 wivbRAEsI+A0fgztWq935ru3tSMNTQf+y2XPcpzgWECwtjTvhAjUtR5Yf2KC84A80swJ VcDEx7YAwTpll0XEjmz+3rnRV44KDyPXGL+zpE86ewHsdJRFH9dzAPtTmOCB7nDfusMU O6rA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=h0k/SZhy37SnuN8KJidHabKu5pvAsxYyNUGMmuRSfDg=; b=rxld/i1orVuS9hKdh90kvLMwMfRJt4Fj25YOAgo5K7e7HSH8MNtEloFMPnuyNz7nLx HhKZ/Ap/Y6Sc5Dy8pCEd7uYppRFY11GI4wFMJC/0ER0/1I2HZ5aLQ8GfU9wHzl9irM2M w2OJOs3SkDY9pPG+s3ihbSbJGA7cV7SRRRGPOfch/zcLbRosq2h/gAD0ateb0/6IBYzz TZQ6nZVK6aZT+1e8PpT+MPso5Mfw2FBXJzwS3MDG8x1HdUhI8SY8zydObExJAWC5Aw1m 4MD2vGrOS5saBe/wLaXHteBcC4KWYQ2LA5/Oy3eJtkZmW1lYezTsFDNCaIM67GYRTbWw MqBg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=tftmUFzF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b5si147678ots.78.2020.02.12.15.03.16; Wed, 12 Feb 2020 15:03:30 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=tftmUFzF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729223AbgBLXDJ (ORCPT + 99 others); Wed, 12 Feb 2020 18:03:09 -0500 Received: from mail-qt1-f193.google.com ([209.85.160.193]:42377 "EHLO mail-qt1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728447AbgBLXDJ (ORCPT ); Wed, 12 Feb 2020 18:03:09 -0500 Received: by mail-qt1-f193.google.com with SMTP id r5so2966214qtt.9; Wed, 12 Feb 2020 15:03:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=h0k/SZhy37SnuN8KJidHabKu5pvAsxYyNUGMmuRSfDg=; b=tftmUFzF0KyV09ppAzS+euVqTcoxJSUxBn+2PzjFhtOrQnhrlkLo7hs/q/cj7aLfKG vHyAYb64po/qFI9SgO7D2JRpddg/qxZleL5GPfdLH8ZHbm1sRMJp92aBI1/dwLNfIKZH kq9qtNIKy8tSXfaYHBpczb0volZ3yx0mgw/5bYX17wqE5qfrc/DXG0c4t5y59BSXWhkT dEgxxKVyXS8PJDhVnw3G5mn6RYVtlbMolwloM0KjLKS36shfX52NeoBdOBvIucejJeLv bPtRu9V5A1wqcsPkrBRlQEIimcLJNa4anWWLPYkTCfCRi2cPvaZqHuoh/moejqJMgK/9 MX9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to; bh=h0k/SZhy37SnuN8KJidHabKu5pvAsxYyNUGMmuRSfDg=; b=Cd6uDdGfw6XQNow2w+QKz81G2Ck3NFbflLRT6etF8OHVXdxYMVgUYHPALzkJ1vBFJ2 4WanhFc+BpAn15vygnAA9+15VIZkw35bxw9OhUEm9bDMtHpSjhey5WVFcXRjK8zDkSg6 QiauCcVHHrPM+emsJJz7dxPTA1VUoL7jRpr3iVGs30hxcS64T1KU2MZ5m0dQ7uaFTCtH UWIitHH0+1DoqCsAlu/V9CVslZLJKUajFxR/h1x4/IrSGpS1OhR+uGfeqmUhc5+loOgx reuDCJYv/5a//SIMtBiCG07svE4nub8pG+DH1D6pSmWCheVwuJuREq44p6eKZhdRHHoZ nTSg== X-Gm-Message-State: APjAAAUYtmqViCU+ws8B5WP3Hq6xwpdePDsqVd/dTXGcuYG6mP9o5Fqt Xc7dpWdQLxB0mxFdkBT4xJY= X-Received: by 2002:ac8:4d0b:: with SMTP id w11mr21270023qtv.385.1581548587963; Wed, 12 Feb 2020 15:03:07 -0800 (PST) Received: from localhost ([2620:10d:c091:500::1:985a]) by smtp.gmail.com with ESMTPSA id m95sm367585qte.41.2020.02.12.15.03.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Feb 2020 15:03:07 -0800 (PST) Date: Wed, 12 Feb 2020 18:03:07 -0500 From: Tejun Heo To: Michal =?iso-8859-1?Q?Koutn=FD?= Cc: cgroups@vger.kernel.org, Li Zefan , Johannes Weiner , Aleksa Sarai , linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v2 1/3] cgroup/pids: Separate semantics of pids.events related to pids.max Message-ID: <20200212230307.GB88887@mtj.thefacebook.com> References: <20191128172612.10259-1-mkoutny@suse.com> <20200205134426.10570-1-mkoutny@suse.com> <20200205134426.10570-2-mkoutny@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200205134426.10570-2-mkoutny@suse.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 05, 2020 at 02:44:24PM +0100, Michal Koutn? wrote: > Currently, when pids.max limit is breached in the hierarchy, the event > is counted and reported in the cgroup where the forking task resides. > > This decouples the limit and the notification caused by the limit making > it hard to detect when the actual limit was effected. > > Let's introduce new events: > max > The number of times the limit of the cgroup was hit. > > max.imposed > The number of times fork failed in the cgroup because of self > or ancestor limit. Can you please follow the same convention as memory.events and memory.events.local? Thanks. -- tejun