Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
User-Agent: Cyrus-JMAP/3.1.7-802-g7a41c81-fmstable-20200203v1
Mime-Version: 1.0
Message-Id: <288ba2d7-77dc-40a7-90e8-f2781b3fe067@www.fastmail.com>
In-Reply-To: <CACPK8Xdg0ocBzDqtkoo8cSCpUq+QjHQ1PKrsVZd8NPUvPFeFCw@mail.gmail.com>
References: <20200206170234.84288-1-geissonator@gmail.com>
 <CACPK8Xdg0ocBzDqtkoo8cSCpUq+QjHQ1PKrsVZd8NPUvPFeFCw@mail.gmail.com>
Date:   Thu, 13 Feb 2020 11:24:36 +1030
From:   "Andrew Jeffery" <andrew@aj.id.au>
To:     "Joel Stanley" <joel@jms.id.au>,
        "Andrew Geissler" <geissonator@gmail.com>
Cc:     devicetree <devicetree@vger.kernel.org>,
        linux-aspeed <linux-aspeed@lists.ozlabs.org>,
        "OpenBMC Maillist" <openbmc@lists.ozlabs.org>,
        "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        "Andrew Geissler" <geissonator@yahoo.com>,
        "Linux ARM" <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3] ARM: dts: aspeed: witherspoon: Add gpio line names
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On Mon, 10 Feb 2020, at 12:59, Joel Stanley wrote:
> On Thu, 6 Feb 2020 at 17:03, Andrew Geissler <geissonator@gmail.com> wrote:
> >
> > From: Andrew Geissler <geissonator@yahoo.com>
> >
> > Name the GPIOs to help userspace work with them. The names describe the
> > functionality the lines provide, not the net or ball name. This makes it
> > easier to share userspace code across different systems and makes the
> > use of the lines more obvious.
> >
> > Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
> 
> Reviewed-by: Joel Stanley <joel@jms.id.au>
> 
> I will wait for  Andrew before merging, but this looks good to me.

To the best of my knowledge this is the only supported approach.

I haven't checked the mapping of gpio lines to functions, but for
the concept:

Acked-by: Andrew Jeffery <andrew@aj.id.au>

Andrew