Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 12 Feb 2020 19:38:29 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     Johannes Krude <johannes@krude.de>
Cc:     bpf@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        "David S. Miller" <davem@davemloft.net>, trivial@kernel.org
Subject: Re: [PATCH] bpf_prog_offload_info_fill: replace bitwise AND by
 logical AND
Message-ID: <20200212193829.00ddefc0@cakuba.hsd1.ca.comcast.net>
In-Reply-To: <20200212193227.GA3769@phlox.h.transitiv.net>
References: <20200212193227.GA3769@phlox.h.transitiv.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 12 Feb 2020 20:32:27 +0100, Johannes Krude wrote:
> This if guards whether user-space wants a copy of the offload-jited
> bytecode and whether this bytecode exists. By erroneously doing a bitwise
> AND instead of a logical AND on user- and kernel-space buffer-size can lead
> to no data being copied to user-space especially when user-space size is a
> power of two and bigger then the kernel-space buffer.
> 
> Signed-off-by: Johannes Krude <johannes@krude.de>

Thank you for the fix, in the future please provide a Fixes tag and
include the tree name in the PATCH tag, e.g. [PATCH bpf], or [PATCH net]
etc.

Fixes: fcfb126defda ("bpf: add new jited info fields in bpf_dev_offload and bpf_prog_info")

Acked-by: Jakub Kicinski <kuba@kernel.org>