Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp183290ybv; Wed, 12 Feb 2020 22:01:52 -0800 (PST) X-Google-Smtp-Source: APXvYqwcEiQOW9aU86OwiF9eBxQnBicao9VqXSVUy0MVj1FeaKfCzN1/TbiBO6yBW+N4ot673fU9 X-Received: by 2002:aca:ebc2:: with SMTP id j185mr1876201oih.71.1581573712681; Wed, 12 Feb 2020 22:01:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581573712; cv=none; d=google.com; s=arc-20160816; b=IpK/EEYHhC9aQJIYMpGSHlbVUaJ8kOlr33RkrZBq/dlbQ2WDHHspxzWdtD56DEZPCO ZcrCKJFDVYSJit7XS1WYsF6oRtieHdqMNyqNV5lJ7MDGvVH31OgpHhvJd9YG84a9UIh/ 1BSBnzPVRdHH0lpM5txZAalzazDHHJLsbflFCOdUVuELczSHLbHrctSZ213OT/uo2dwb 1NQHpwp9+W9IxfJEzvHIt4wyr00RmsUaz8fsr/GNZs98uIkXY4akl/XkLpgDMjSBmCAO c+LzlLf+XxR6P6jDYrUMGuTM4R2tSRHRLRvDAfqplfilx9AyE0+odj6+DnubUFn5Bi0L xWMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:from:references:cc:to:subject:dkim-signature; bh=ktYBlAeplexnrBT+ZLUVTJfw6OZX7i1G+DwPjCU26/Q=; b=h8KFlMWWjnxW/EGGdpyvwvZWde41gCY0MqxRPzvdvguQ/rPAeV4RsfPkQCzrZVrL+C cc1pgGGnDttVSDsjZntdUXrySTpvZTr6PuYk2KhCHWlKsxhg3/gTgaDzyliT/WfxP3AK Gniiuf2Gw2et7SGkb542gzzozZ0uMJs1lQDn6LvDqfBfsLEqwUvc4E6M2nYN2qjxxAx0 yqSyFia1EwVHB0zhAbn2q9/4FEEbC2gmcdLFyIj817PUaAsrGP1AHn3thX/qg6LzqgTa lBcXDsCuEUSp+N2/W1IwzEuEDgovKXZhsAeqPXSXJeThQ7RG52UXrA2w6ZdRbOdHtCR2 rZGQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@embeddedor.com header.s=default header.b=wiucXXL4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o15si624451otp.314.2020.02.12.22.01.38; Wed, 12 Feb 2020 22:01:52 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@embeddedor.com header.s=default header.b=wiucXXL4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729383AbgBMGBa (ORCPT + 99 others); Thu, 13 Feb 2020 01:01:30 -0500 Received: from gateway34.websitewelcome.com ([192.185.148.142]:36460 "EHLO gateway34.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726368AbgBMGB3 (ORCPT ); Thu, 13 Feb 2020 01:01:29 -0500 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway34.websitewelcome.com (Postfix) with ESMTP id C013C245EF07 for ; Thu, 13 Feb 2020 00:01:27 -0600 (CST) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id 27Z1j4bjQ8vkB27Z1j2UYu; Thu, 13 Feb 2020 00:01:27 -0600 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=embeddedor.com; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=ktYBlAeplexnrBT+ZLUVTJfw6OZX7i1G+DwPjCU26/Q=; b=wiucXXL4+guz+wJAIX/AWBgzvU flRvpMnw5MF4h/MO+Ty9EMUiDGMAV1Zi9UmPQLJBT0tsYe3wc1V1RVrZu9wR1J/Ol3bTyZpzRdd2I o7hWPlPU4leXNK9qDMgCoDhtTlAJNJ9Ls7tSm6p+Nc42L2SVNQ+sp9uIwwQOv49e8su2yQZu+5K89 J5jCThrQuVs7++MRZaF/0Qj7xOYbH4hdbe1s3HWGEr89EB3SDoWsQFkGVwcW0g4dvmIC/JZGYKVKv wmlOWYJDO5LtZ8LSOUcKurXGzCyv964XvR0na5rk/EBAhmLJDza/JDHUjEdvPgT15VbAZ2HeQiM/z /7VBEzgA==; Received: from [200.68.140.15] (port=10311 helo=[192.168.43.131]) by gator4166.hostgator.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.92) (envelope-from ) id 1j27Z1-0025I5-5N; Thu, 13 Feb 2020 00:01:27 -0600 Subject: Re: [PATCH] scsi: advansys: Replace zero-length array with flexible-array member To: Matthew Wilcox Cc: Hannes Reinecke , "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200213000211.GA23171@embeddedor.com> <20200213011406.GI7778@bombadil.infradead.org> From: "Gustavo A. R. Silva" Autocrypt: addr=gustavo@embeddedor.com; keydata= xsFNBFssHAwBEADIy3ZoPq3z5UpsUknd2v+IQud4TMJnJLTeXgTf4biSDSrXn73JQgsISBwG 2Pm4wnOyEgYUyJd5tRWcIbsURAgei918mck3tugT7AQiTUN3/5aAzqe/4ApDUC+uWNkpNnSV tjOx1hBpla0ifywy4bvFobwSh5/I3qohxDx+c1obd8Bp/B/iaOtnq0inli/8rlvKO9hp6Z4e DXL3PlD0QsLSc27AkwzLEc/D3ZaqBq7ItvT9Pyg0z3Q+2dtLF00f9+663HVC2EUgP25J3xDd 496SIeYDTkEgbJ7WYR0HYm9uirSET3lDqOVh1xPqoy+U9zTtuA9NQHVGk+hPcoazSqEtLGBk YE2mm2wzX5q2uoyptseSNceJ+HE9L+z1KlWW63HhddgtRGhbP8pj42bKaUSrrfDUsicfeJf6 m1iJRu0SXYVlMruGUB1PvZQ3O7TsVfAGCv85pFipdgk8KQnlRFkYhUjLft0u7CL1rDGZWDDr NaNj54q2CX9zuSxBn9XDXvGKyzKEZ4NY1Jfw+TAMPCp4buawuOsjONi2X0DfivFY+ZsjAIcx qQMglPtKk/wBs7q2lvJ+pHpgvLhLZyGqzAvKM1sVtRJ5j+ARKA0w4pYs5a5ufqcfT7dN6TBk LXZeD9xlVic93Ju08JSUx2ozlcfxq+BVNyA+dtv7elXUZ2DrYwARAQABzSxHdXN0YXZvIEEu IFIuIFNpbHZhIDxndXN0YXZvQGVtYmVkZGVkb3IuY29tPsLBfQQTAQgAJwUCWywcDAIbIwUJ CWYBgAULCQgHAgYVCAkKCwIEFgIDAQIeAQIXgAAKCRBHBbTLRwbbMZ6tEACk0hmmZ2FWL1Xi l/bPqDGFhzzexrdkXSfTTZjBV3a+4hIOe+jl6Rci/CvRicNW4H9yJHKBrqwwWm9fvKqOBAg9 obq753jydVmLwlXO7xjcfyfcMWyx9QdYLERTeQfDAfRqxir3xMeOiZwgQ6dzX3JjOXs6jHBP cgry90aWbaMpQRRhaAKeAS14EEe9TSIly5JepaHoVdASuxklvOC0VB0OwNblVSR2S5i5hSsh ewbOJtwSlonsYEj4EW1noQNSxnN/vKuvUNegMe+LTtnbbocFQ7dGMsT3kbYNIyIsp42B5eCu JXnyKLih7rSGBtPgJ540CjoPBkw2mCfhj2p5fElRJn1tcX2McsjzLFY5jK9RYFDavez5w3lx JFgFkla6sQHcrxH62gTkb9sUtNfXKucAfjjCMJ0iuQIHRbMYCa9v2YEymc0k0RvYr43GkA3N PJYd/vf9vU7VtZXaY4a/dz1d9dwIpyQARFQpSyvt++R74S78eY/+lX8wEznQdmRQ27kq7BJS R20KI/8knhUNUJR3epJu2YFT/JwHbRYC4BoIqWl+uNvDf+lUlI/D1wP+lCBSGr2LTkQRoU8U 64iK28BmjJh2K3WHmInC1hbUucWT7Swz/+6+FCuHzap/cjuzRN04Z3Fdj084oeUNpP6+b9yW e5YnLxF8ctRAp7K4yVlvA87BTQRbLBwMARAAsHCE31Ffrm6uig1BQplxMV8WnRBiZqbbsVJB H1AAh8tq2ULl7udfQo1bsPLGGQboJSVN9rckQQNahvHAIK8ZGfU4Qj8+CER+fYPp/MDZj+t0 DbnWSOrG7z9HIZo6PR9z4JZza3Hn/35jFggaqBtuydHwwBANZ7A6DVY+W0COEU4of7CAahQo 5NwYiwS0lGisLTqks5R0Vh+QpvDVfuaF6I8LUgQR/cSgLkR//V1uCEQYzhsoiJ3zc1HSRyOP otJTApqGBq80X0aCVj1LOiOF4rrdvQnj6iIlXQssdb+WhSYHeuJj1wD0ZlC7ds5zovXh+FfF l5qH5RFY/qVn3mNIVxeO987WSF0jh+T5ZlvUNdhedGndRmwFTxq2Li6GNMaolgnpO/CPcFpD jKxY/HBUSmaE9rNdAa1fCd4RsKLlhXda+IWpJZMHlmIKY8dlUybP+2qDzP2lY7kdFgPZRU+e zS/pzC/YTzAvCWM3tDgwoSl17vnZCr8wn2/1rKkcLvTDgiJLPCevqpTb6KFtZosQ02EGMuHQ I6Zk91jbx96nrdsSdBLGH3hbvLvjZm3C+fNlVb9uvWbdznObqcJxSH3SGOZ7kCHuVmXUcqoz ol6ioMHMb+InrHPP16aVDTBTPEGwgxXI38f7SUEn+NpbizWdLNz2hc907DvoPm6HEGCanpcA EQEAAcLBZQQYAQgADwUCWywcDAIbDAUJCWYBgAAKCRBHBbTLRwbbMdsZEACUjmsJx2CAY+QS UMebQRFjKavwXB/xE7fTt2ahuhHT8qQ/lWuRQedg4baInw9nhoPE+VenOzhGeGlsJ0Ys52sd XvUjUocKgUQq6ekOHbcw919nO5L9J2ejMf/VC/quN3r3xijgRtmuuwZjmmi8ct24TpGeoBK4 WrZGh/1hAYw4ieARvKvgjXRstcEqM5thUNkOOIheud/VpY+48QcccPKbngy//zNJWKbRbeVn imua0OpqRXhCrEVm/xomeOvl1WK1BVO7z8DjSdEBGzbV76sPDJb/fw+y+VWrkEiddD/9CSfg fBNOb1p1jVnT2mFgGneIWbU0zdDGhleI9UoQTr0e0b/7TU+Jo6TqwosP9nbk5hXw6uR5k5PF 8ieyHVq3qatJ9K1jPkBr8YWtI5uNwJJjTKIA1jHlj8McROroxMdI6qZ/wZ1ImuylpJuJwCDC ORYf5kW61fcrHEDlIvGc371OOvw6ejF8ksX5+L2zwh43l/pKkSVGFpxtMV6d6J3eqwTafL86 YJWH93PN+ZUh6i6Rd2U/i8jH5WvzR57UeWxE4P8bQc0hNGrUsHQH6bpHV2lbuhDdqo+cM9eh GZEO3+gCDFmKrjspZjkJbB5Gadzvts5fcWGOXEvuT8uQSvl+vEL0g6vczsyPBtqoBLa9SNrS VtSixD1uOgytAP7RWS474w== Message-ID: Date: Thu, 13 Feb 2020 00:04:01 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200213011406.GI7778@bombadil.infradead.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 200.68.140.15 X-Source-L: No X-Exim-ID: 1j27Z1-0025I5-5N X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([192.168.43.131]) [200.68.140.15]:10311 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 6 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/12/20 19:14, Matthew Wilcox wrote: > On Wed, Feb 12, 2020 at 06:02:11PM -0600, Gustavo A. R. Silva wrote: >> Also, notice that, dynamic memory allocations won't be affected by >> this change: > > Shouldn't you also convert this: > asc_sg_head = kzalloc(sizeof(asc_scsi_q->sg_head) + > use_sg * sizeof(struct asc_sg_list), GFP_ATOMIC); > to use struct_size()? > It's not a requirement to do that prior to applying the change proposed by this patch. Thanks -- Gustavo