Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 13 Feb 2020 18:27:58 +1100
From:   Aleksa Sarai <cyphar@cyphar.com>
To:     shuah <shuah@kernel.org>
Cc:     linux-kselftest@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Dmitry Safonov <dima@arista.com>
Subject: Re: Linux 5.6-rc1 kselftest build failures
Message-ID: <20200213072758.e2bngq2z6yypvsim@yavin>
References: <ff16537e-febc-1b98-0cf8-1aa23e0c29b0@kernel.org>
 <20200212081414.7bwkndf6qxg2p35a@yavin>
 <5311f218-9bb0-4792-c469-019c7c2db7ee@kernel.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="qh5d5kw7pebtctms"
Content-Disposition: inline
In-Reply-To: <5311f218-9bb0-4792-c469-019c7c2db7ee@kernel.org>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--qh5d5kw7pebtctms
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 2020-02-12, shuah <shuah@kernel.org> wrote:
> On 2/12/20 1:14 AM, Aleksa Sarai wrote:
> > On 2020-02-11, shuah <shuah@kernel.org> wrote:
> > > openat2:
> > >=20
> > > tools/testing/selftests/openat2'
> > > gcc -Wall -O2 -g -fsanitize=3Daddress -fsanitize=3Dundefined openat2_=
test.c
> > > helpers.c  -o tools/testing/selftests/openat2/openat2_test
> > > In file included from /usr/include/fcntl.h:301,
> > >                   from helpers.c:9:
> > > In function =E2=80=98openat=E2=80=99,
> > >      inlined from =E2=80=98touchat=E2=80=99 at helpers.c:49:11:
> > > /usr/include/x86_64-linux-gnu/bits/fcntl2.h:126:4: error: call to
> > > =E2=80=98__openat_missing_mode=E2=80=99 declared with attribute error=
: openat with O_CREAT
> > > or O_TMPFILE in third argument needs 4 arguments
> > >    126 |    __openat_missing_mode ();
> > >        |    ^~~~~~~~~~~~~~~~~~~~~~~~
> >=20
> > Yeah, that's a brain-o -- it looks like you have a newer glibc than
> > me which gives you a warning when you don't set the mode. The fix should
> > be just the following:
> >=20
>=20
> Nice. Do you mind sending a proper patch, I can pull in.

Done[1].

[1]: https://lore.kernel.org/linux-kselftest/20200213072656.15611-1-cyphar@=
cyphar.com/

--=20
Aleksa Sarai
Senior Software Engineer (Containers)
SUSE Linux GmbH
<https://www.cyphar.com/>

--qh5d5kw7pebtctms
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQSxZm6dtfE8gxLLfYqdlLljIbnQEgUCXkT6ewAKCRCdlLljIbnQ
EnCtAQCzI05OXMgl0JIuGJ5egu8Kczl6d3+PRHVJNjo+G6ctzAD8DeeaDhBBGG4S
DRST3Y5gOLhDnlxv5gvFKh6UVQqbxg4=
=toGw
-----END PGP SIGNATURE-----

--qh5d5kw7pebtctms--