Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp261306ybv; Wed, 12 Feb 2020 23:42:15 -0800 (PST) X-Google-Smtp-Source: APXvYqz0NXM5r0V6Pjbly3Rx5MRkcU77avDvJxGLslQy0L4/1FhPq5dHjkXWDjLWUnwpJ0dL3Ce0 X-Received: by 2002:a9d:5a09:: with SMTP id v9mr11829968oth.214.1581579735131; Wed, 12 Feb 2020 23:42:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581579735; cv=none; d=google.com; s=arc-20160816; b=R4MsXTq1IFK+G9yYW5ygXz4GNJZFYdpfh3QP56Lpan7wMotHyBfvH1/5MLozJyfdyM psgRwdkIEcyx7CEK+zoqEQMPxs4dojOSFuFyRpMTUtNCky8ixUoeBDyFIkTobzRzrkNP yVpAhWKYFKrZ/RziyN64Uvh5So3HB8VrkcdkqM9ya2bpdguLwuRJPP2MLkH+zNZhsNie Fz8hX9qyx/OmkPT0LycsGxgxelfGkTxJjUZXSlDC2ipMSW9Y83O2CmB4a/btQc2uJ+CB qN/qjdOhdAF7H0FKR7j+ub5qTF9Lzc7bOW60WtAkjeQrhrlOZAJuBWqrVHJ8Y0bjy86m /ruA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:cc:to:from :subject; bh=v14MZEDeqzn3X8KtCp9S+ZNB8e/7XjaOcSadXa7ORMA=; b=wMGStoua5QbJZnRn960yb/ZvZzbTXLFt4ya1iMsHY0wTV9v5gqLg3ckE/pLm7nyB9k ggX1KKLXgTzKrDZDRn6J9aPUs3xwu+tviIIOhJkWBII2z7cAk6LL9ARdWb4XpFTXp7d3 Q1MiqWAtk4jaUgTqDrtUsLMWAJf5i0uYM1CH9g079CiAW9d+On1unM1XyiGjBXjR/Pbt W6WtiKqFXJFsk6njHdOy3JoKLKzRl79wDJPRMOfTZ16rAUR+iJoHmhEqrCDY3fDE7Uy5 FwGg7ir0XPT1nUAxhbYAOJsj5hjWNrQEDqA5yCkLY4XSCcXibjHCKkEefXZL6W2+9Pej iB4Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=virtuozzo.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s22si816477otq.100.2020.02.12.23.42.02; Wed, 12 Feb 2020 23:42:15 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=virtuozzo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729854AbgBMHjz (ORCPT + 99 others); Thu, 13 Feb 2020 02:39:55 -0500 Received: from relay.sw.ru ([185.231.240.75]:41060 "EHLO relay.sw.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729831AbgBMHjz (ORCPT ); Thu, 13 Feb 2020 02:39:55 -0500 Received: from [192.168.15.156] (helo=localhost.localdomain) by relay.sw.ru with esmtp (Exim 4.92.3) (envelope-from ) id 1j295d-0001TW-OE; Thu, 13 Feb 2020 10:39:13 +0300 Subject: [PATCH v7 2/6] block: Pass op_flags into blk_queue_get_max_sectors() From: Kirill Tkhai To: martin.petersen@oracle.com, bob.liu@oracle.com, axboe@kernel.dk, darrick.wong@oracle.com Cc: agk@redhat.com, snitzer@redhat.com, dm-devel@redhat.com, song@kernel.org, tytso@mit.edu, adilger.kernel@dilger.ca, Chaitanya.Kulkarni@wdc.com, ming.lei@redhat.com, osandov@fb.com, jthumshirn@suse.de, minwoo.im.dev@gmail.com, damien.lemoal@wdc.com, andrea.parri@amarulasolutions.com, hare@suse.com, tj@kernel.org, ajay.joshi@wdc.com, sagi@grimberg.me, dsterba@suse.com, chaitanya.kulkarni@wdc.com, bvanassche@acm.org, dhowells@redhat.com, asml.silence@gmail.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, ktkhai@virtuozzo.com Date: Thu, 13 Feb 2020 10:39:13 +0300 Message-ID: <158157955322.111879.16371696985080169961.stgit@localhost.localdomain> In-Reply-To: <158157930219.111879.12072477040351921368.stgit@localhost.localdomain> References: <158157930219.111879.12072477040351921368.stgit@localhost.localdomain> User-Agent: StGit/0.19 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This preparation patch changes argument type, and now the function takes full op_flags instead of just op code. Signed-off-by: Kirill Tkhai Reviewed-by: Bob Liu --- block/blk-core.c | 4 ++-- include/linux/blkdev.h | 8 +++++--- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/block/blk-core.c b/block/blk-core.c index 089e890ab208..28a6d46eb982 100644 --- a/block/blk-core.c +++ b/block/blk-core.c @@ -1221,10 +1221,10 @@ EXPORT_SYMBOL(submit_bio); static int blk_cloned_rq_check_limits(struct request_queue *q, struct request *rq) { - if (blk_rq_sectors(rq) > blk_queue_get_max_sectors(q, req_op(rq))) { + if (blk_rq_sectors(rq) > blk_queue_get_max_sectors(q, rq->cmd_flags)) { printk(KERN_ERR "%s: over max size limit. (%u > %u)\n", __func__, blk_rq_sectors(rq), - blk_queue_get_max_sectors(q, req_op(rq))); + blk_queue_get_max_sectors(q, rq->cmd_flags)); return -EIO; } diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h index 1e3c08854b09..f4ec7ae214ab 100644 --- a/include/linux/blkdev.h +++ b/include/linux/blkdev.h @@ -988,8 +988,10 @@ static inline struct bio_vec req_bvec(struct request *rq) } static inline unsigned int blk_queue_get_max_sectors(struct request_queue *q, - int op) + unsigned int op_flags) { + int op = op_flags & REQ_OP_MASK; + if (unlikely(op == REQ_OP_DISCARD || op == REQ_OP_SECURE_ERASE)) return min(q->limits.max_discard_sectors, UINT_MAX >> SECTOR_SHIFT); @@ -1028,10 +1030,10 @@ static inline unsigned int blk_rq_get_max_sectors(struct request *rq, if (!q->limits.chunk_sectors || req_op(rq) == REQ_OP_DISCARD || req_op(rq) == REQ_OP_SECURE_ERASE) - return blk_queue_get_max_sectors(q, req_op(rq)); + return blk_queue_get_max_sectors(q, rq->cmd_flags); return min(blk_max_size_offset(q, offset), - blk_queue_get_max_sectors(q, req_op(rq))); + blk_queue_get_max_sectors(q, rq->cmd_flags)); } static inline unsigned int blk_rq_count_bios(struct request *rq)