Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 13 Feb 2020 14:28:49 +0100
Message-ID: <s5hwo8qlipa.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     minyard@acm.org
Cc:     Patrick Vo <patrick.vo@hpe.com>,
        openipmi-developer@lists.sourceforge.net,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ipmi_si: Avoid spurious errors for optional IRQs
In-Reply-To: <20200213130212.GP7842@minyard.net>
References: <20200205093146.1352-1-tiwai@suse.de>
        <s5hpneiyjgb.wl-tiwai@suse.de>
        <20200213130212.GP7842@minyard.net>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 13 Feb 2020 14:02:12 +0100,
Corey Minyard wrote:
> 
> On Thu, Feb 13, 2020 at 09:34:12AM +0100, Takashi Iwai wrote:
> > On Wed, 05 Feb 2020 10:31:46 +0100,
> > Takashi Iwai wrote:
> > > 
> > > Although the IRQ assignment in ipmi_si driver is optional,
> > > platform_get_irq() spews error messages unnecessarily:
> > >   ipmi_si dmi-ipmi-si.0: IRQ index 0 not found
> > > 
> > > Fix this by switching to platform_get_irq_optional().
> > > 
> > > Fixes: 7723f4c5ecdb ("driver core: platform: Add an error message to platform_get_irq*()")
> > > Reported-and-tested-by: Patrick Vo <patrick.vo@hpe.com>
> > > Signed-off-by: Takashi Iwai <tiwai@suse.de>
> > 
> > Any review / ack on this?
> 
> Sorry, lost in the noise.  I've included this for 5.7.  If you want it
> earlier, I can arrange that.

It's fine for 5.7, as it's no urgent fix at all.  Thanks!


Takashi

> 
> Thanks,
> 
> -corey
> 
> > 
> > 
> > thanks,
> > 
> > Takashi
> > 
> > > ---
> > >  drivers/char/ipmi/ipmi_si_platform.c | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/drivers/char/ipmi/ipmi_si_platform.c b/drivers/char/ipmi/ipmi_si_platform.c
> > > index c78127ccbc0d..638c693e17ad 100644
> > > --- a/drivers/char/ipmi/ipmi_si_platform.c
> > > +++ b/drivers/char/ipmi/ipmi_si_platform.c
> > > @@ -194,7 +194,7 @@ static int platform_ipmi_probe(struct platform_device *pdev)
> > >  	else
> > >  		io.slave_addr = slave_addr;
> > >  
> > > -	io.irq = platform_get_irq(pdev, 0);
> > > +	io.irq = platform_get_irq_optional(pdev, 0);
> > >  	if (io.irq > 0)
> > >  		io.irq_setup = ipmi_std_irq_setup;
> > >  	else
> > > @@ -378,7 +378,7 @@ static int acpi_ipmi_probe(struct platform_device *pdev)
> > >  		io.irq = tmp;
> > >  		io.irq_setup = acpi_gpe_irq_setup;
> > >  	} else {
> > > -		int irq = platform_get_irq(pdev, 0);
> > > +		int irq = platform_get_irq_optional(pdev, 0);
> > >  
> > >  		if (irq > 0) {
> > >  			io.irq = irq;
> > > -- 
> > > 2.16.4
> > > 
>