Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp662400ybv; Thu, 13 Feb 2020 07:22:36 -0800 (PST) X-Google-Smtp-Source: APXvYqxXk0IusCeA+8vpBJqKWJB5S4lrIRHIZtxfH1SeqWUI7higqOTuxYIge8dnQCIBQsPLgYxP X-Received: by 2002:a9d:7f83:: with SMTP id t3mr10167524otp.63.1581607356456; Thu, 13 Feb 2020 07:22:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581607356; cv=none; d=google.com; s=arc-20160816; b=q3U5YY1SkQ2drWRBbhrCoFEjeb5upaj5rtLDVJY4OoaFJ4caagP8DJXVOl06Chccs7 B2yU7HbJC2yzX6rDtdy8tlM3M7sBlsqJfNY0yygK6Xqq/ZqejNoPkONQp4bae8rMTVXP 4elRtLf1QdlpQRrNH6bIcBh90vT1ogMPLZafK0yX58r1BlGtg9/HYPKw/7Oe7NHg2u0k pxWYkd0Q4Tuom3nW1Q7kFXoa5uJoUCi4M7LAKR0+KR2Pe8XfiLXQGnVTvC6wod4fKB7W 47+TGaCAuL6O4qVdvsE0kGtRr+prWof5JY2iQYLmB7EAPyb1+cEXFuUv3TXjcsYhbTJD aJHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=dv9IynKtgpAw9kZ/PF47GkXZz0vHdCZaxqumKlBqMJY=; b=RvKRBYP0k+8O4QD0ZD2zwHk2LK120M/ZYxVOydMpSiVFBtwpo0uG6hzVT5DZLtLR2m 5T6O2iGbtTPfznxx05B4xD8Ec3cp4MmWJ11FVnMA627iIdWG/f5EmOWoYCHDqLNFIq82 1acz1x1wB0DU5aTsY7odhqbLiRA/XlxlnoWnkxCjARZ1Uy9GBlRg3Z+5lKeNXj1spp+N ELP+uUkn6bJJ6NT77r2X+xyA2U+oEQ+pPdUQkKf5PCRzvLTww7elaTivDmmVeOzff0/U E+P5x0R6n4C1mslx8WZrOsfcAZzFtrPIDLnQbvSonVWA1t8zRUkB3XIf1SqGHtBDn7Iy p63g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 17si1264072otv.149.2020.02.13.07.22.24; Thu, 13 Feb 2020 07:22:36 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727595AbgBMPWP (ORCPT + 99 others); Thu, 13 Feb 2020 10:22:15 -0500 Received: from foss.arm.com ([217.140.110.172]:47730 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726937AbgBMPWO (ORCPT ); Thu, 13 Feb 2020 10:22:14 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 663CD328; Thu, 13 Feb 2020 07:22:14 -0800 (PST) Received: from [10.1.195.59] (ifrit.cambridge.arm.com [10.1.195.59]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5FE623F68E; Thu, 13 Feb 2020 07:22:12 -0800 (PST) Subject: Re: [PATCH v3 5/7] cpufreq: add function to get the hardware max frequency To: Ionela Voinescu Cc: catalin.marinas@arm.com, will@kernel.org, mark.rutland@arm.com, maz@kernel.org, suzuki.poulose@arm.com, sudeep.holla@arm.com, lukasz.luba@arm.com, rjw@rjwysocki.net, peterz@infradead.org, mingo@redhat.com, vincent.guittot@linaro.org, viresh.kumar@linaro.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org References: <20200211184542.29585-1-ionela.voinescu@arm.com> <20200211184542.29585-6-ionela.voinescu@arm.com> <20200213125918.GA2397@arm.com> From: Valentin Schneider Message-ID: Date: Thu, 13 Feb 2020 15:22:11 +0000 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200213125918.GA2397@arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/13/20 12:59 PM, Ionela Voinescu wrote: >> What about intel_pstate / turbo stuff? IIRC one of Giovanni's issues was that >> turbo freq is not always reported as the max freq. Dunno if we can do >> anything about it; at the very least maybe document the caveat? >> > > Okay, I can add details in the description in regards to potential > reasons to overwrite this function. But basically this is one of the > reasons for making this a weak function. The best information we can > generically get for maximum hardware frequency is cpuinfo.max_freq. > But if platforms have the possibility to obtain this differently from > either hardware or firmware they can overwrite this. > Right, that would be handled by a different implementation of that function, so this wasn't too relevant of a comment. Sorry!