Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp678049ybv; Thu, 13 Feb 2020 07:37:24 -0800 (PST) X-Google-Smtp-Source: APXvYqzbSYpET0aUOsZnxvpR2LI1mOiguYoypooWwOYjYj/RVC31y5voHgSxe1JQ/QgQbxzbyixt X-Received: by 2002:a9d:7a96:: with SMTP id l22mr13746464otn.217.1581608244381; Thu, 13 Feb 2020 07:37:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581608244; cv=none; d=google.com; s=arc-20160816; b=C6qk4F3NfLfXFl/EQjNEAzuA688n/FyXckqahcmjyh9misx0+mUCZoLv/moLi36X5S r8srvvcFFV1TA+LrggLx0BNJ5an7Rho1lKYxHoPKzObPSq6uy0MdotjrYGBEyTyJnRQl B/M2rxqPHhwuytEs/mQlq4xMRxWdb/gvq5iUt8UmcqR9mEWQMnnAkQYuzpZg1IaRkTEc e9KR85Z9zx891tsu243VERsRILsdccZa6+IYdQNQjwfYNK9XzlZBAQdjScgZT6UOTcAz BkyMsufszOcM9trglPE02SD64JMt+6fTBX5a4WRsE/LNuxGwnJthTWHisAz3QEYwzC3R NtTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=IwQHI79iQNnLF0R813K4ZfyJ/4oVZzBfHd4LqqijBNs=; b=v+eDOkHEoD6oG6F9qe1fKUC8OgYPNlFYhPlIb6tJdmxhyyTe43dhGWHqcj66biP+J1 H0YoPv+VX+M0oHX+2Qj0KOu+YaNhj+BVpLjTuZ5C18ALfPmUiB6I61QcjUqM5DpUM7wU ElWYcQiAfNkEUQPxxGWwjC2oYs7RihBCnB9ETs2LfbOrkMLsH/YC82ypSuQZYEWP5x8a 4K+pZH9MQoh2m/pv7ER8htQqt4C+TI98daODSZjGUI2i5eT6LiD3656eFPMc3c9gej4X cBupaIygCaflXdMVt8C3EetGvLsn4zCmf7id/Uq3HVRplI9eiydvvE781U489fLLowlX myCQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=QJ5KUCHp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y6si1372839oih.217.2020.02.13.07.37.11; Thu, 13 Feb 2020 07:37:24 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=QJ5KUCHp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387420AbgBMPg7 (ORCPT + 99 others); Thu, 13 Feb 2020 10:36:59 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:45432 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728534AbgBMPg4 (ORCPT ); Thu, 13 Feb 2020 10:36:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581608215; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IwQHI79iQNnLF0R813K4ZfyJ/4oVZzBfHd4LqqijBNs=; b=QJ5KUCHpoHxzmHxMnCNPYpFg6CmWfK8bDzEQWHDGEjfFj6zn4iNSfRaHQrsaK3O5ia9ivp GuMvw39wG0VqVrX6tEKwoiGsKOiinX8bLmMDMWwYWdhZWsPFT0u9Ev0ZVfUBUsFPRrwipq vfXAsJCFyliiu/v6OsXEusODedkdhUY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-421-2EOjsAokOgC2pnOKYZU8tQ-1; Thu, 13 Feb 2020 10:36:51 -0500 X-MC-Unique: 2EOjsAokOgC2pnOKYZU8tQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D3280100550E; Thu, 13 Feb 2020 15:36:49 +0000 (UTC) Received: from localhost (unknown [10.18.25.174]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A17CD5DA85; Thu, 13 Feb 2020 15:36:46 +0000 (UTC) Date: Thu, 13 Feb 2020 10:36:45 -0500 From: Mike Snitzer To: Maksym Planeta Cc: Zhou Wang , Herbert Xu , "David S. Miller" , Alasdair Kergon , dm-devel@redhat.com, Song Liu , Gao Xiang , Chao Yu , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org, linux-erofs@lists.ozlabs.org Subject: Re: Remove WQ_CPU_INTENSIVE flag from unbound wq's Message-ID: <20200213153645.GA11313@redhat.com> References: <20200213141823.2174236-1-mplaneta@os.inf.tu-dresden.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200213141823.2174236-1-mplaneta@os.inf.tu-dresden.de> User-Agent: Mutt/1.5.21 (2010-09-15) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 13 2020 at 9:18am -0500, Maksym Planeta wrote: > The documentation [1] says that WQ_CPU_INTENSIVE is "meaningless" for > unbound wq. I remove this flag from places where unbound queue is > allocated. This is supposed to improve code readability. > > 1. https://www.kernel.org/doc/html/latest/core-api/workqueue.html#flags > > Signed-off-by: Maksym Planeta What the Documentation says aside, have you cross referenced with the code? And/or have you done benchmarks to verify no changes? Thanks, Mike