Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp678380ybv; Thu, 13 Feb 2020 07:37:43 -0800 (PST) X-Google-Smtp-Source: APXvYqz786x5zfiPvlEk4Q0y9q1t37OEhmwK+/ju6Euw5aTDnH83bHQIH9zey1H58J8Fzoj/+vun X-Received: by 2002:a9d:7083:: with SMTP id l3mr13090735otj.193.1581608262867; Thu, 13 Feb 2020 07:37:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581608262; cv=none; d=google.com; s=arc-20160816; b=TNhChTOc8lPC2JBYQKpu/t9MPj37jNYJUoT/5oWzbN6YbPkbfbyv8XuUnAgmQkiogB 84guBKwnLI/BQuPiGeAPuRX1N6lwxf3elwkESRqBqvcPPpTZ/zISxgKRPRo6yOp3sOBW M8Zw2WypPnyW8dOiJk7nBLSRH8IGDq1Snz8ADOzBIPuXOEknZv2NCA86ZKVJhQvvD4kv WXlBpx1yjKLb+fFS5uHgAMLs3Vc8Ka7uiOXFMcpNs7ue6ViXu0+9N/0TK0STsVSK1s9G PguVSmWZAtib9NykIQPa6EjRaY0CyfbLiyod7kQFwuZJgYDwd/rRBJEK4xOAdXfQKsFL 1lmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=uF3xpcUn7cyus9N/HV2pKPGRTFxwoKLh2NQXoXrE3PU=; b=uZp5EQ00Jdh4Y8Lwm+LcWVOlIWY5ZB2YYppKtB7lTBATY40ahmnXJPxu6ZiWv9SxD3 g5koJnLYDxeFtKUuDGgt3LYNeaWkfTYn8OfveUUL/0/XTXMXiYS81ecV3Bae+4e3MNXP Bjs0ijxSTM7GMMZuESv0L4nXM5wQoPmpr1duUTFGosqyJTb5S0nNaKzKJSSp8y9cEn3P wSdcYaas6aJHw1y0NSwfyW6rnVGfOxvewgCofkEvtXHbu123kE0L+KNgHH3lKaqSnUXd pE4kqE24gHb43ws3cvd/3wQrWz+4a4VGX13seqGSzdv92dVJV99asS1KhtmKz1dM+z07 Jeeg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=JABsgaKn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m24si1311785otf.101.2020.02.13.07.37.30; Thu, 13 Feb 2020 07:37:42 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=JABsgaKn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728697AbgBMP30 (ORCPT + 99 others); Thu, 13 Feb 2020 10:29:26 -0500 Received: from mail.kernel.org ([198.145.29.99]:46382 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728406AbgBMP0i (ORCPT ); Thu, 13 Feb 2020 10:26:38 -0500 Received: from localhost (unknown [104.132.1.104]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AE0FB2467D; Thu, 13 Feb 2020 15:26:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581607597; bh=FmEnygodiDT/cOjpfwNRp3RTu4B00Q6jdwa2zKa5C4Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JABsgaKncGRcPo2H4A3mtAJkll4HulWk33hiuDz/lxUiQhxzEc7n6DdT8+/st3iPx vC7IIWCObpZsOLDUKExsFfdnqSOu2rYQicQpSQ90ujcwtazCtOE/AukIklLliYvGhu EFxeuZrNel+GyXWD1JYZlvzAsA1vkBXcHcs8IdMo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Robert Milkowski , Trond Myklebust , Anna Schumaker Subject: [PATCH 4.19 15/52] NFSv4: try lease recovery on NFS4ERR_EXPIRED Date: Thu, 13 Feb 2020 07:20:56 -0800 Message-Id: <20200213151817.196344386@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200213151810.331796857@linuxfoundation.org> References: <20200213151810.331796857@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Robert Milkowski commit 924491f2e476f7234d722b24171a4daff61bbe13 upstream. Currently, if an nfs server returns NFS4ERR_EXPIRED to open(), we return EIO to applications without even trying to recover. Fixes: 272289a3df72 ("NFSv4: nfs4_do_handle_exception() handle revoke/expiry of a single stateid") Signed-off-by: Robert Milkowski Reviewed-by: Trond Myklebust Signed-off-by: Anna Schumaker Signed-off-by: Greg Kroah-Hartman --- fs/nfs/nfs4proc.c | 5 +++++ 1 file changed, 5 insertions(+) --- a/fs/nfs/nfs4proc.c +++ b/fs/nfs/nfs4proc.c @@ -3089,6 +3089,11 @@ static struct nfs4_state *nfs4_do_open(s exception.retry = 1; continue; } + if (status == -NFS4ERR_EXPIRED) { + nfs4_schedule_lease_recovery(server->nfs_client); + exception.retry = 1; + continue; + } if (status == -EAGAIN) { /* We must have found a delegation */ exception.retry = 1;