Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp679192ybv; Thu, 13 Feb 2020 07:38:33 -0800 (PST) X-Google-Smtp-Source: APXvYqzcVVe3sDEXyZ77u8lQU9e/9CuVHuvT/MjKCE/rIFAmI6VjBUbCFeey/1Y0rvUsrltNvems X-Received: by 2002:a9d:1928:: with SMTP id j40mr13941165ota.68.1581608313551; Thu, 13 Feb 2020 07:38:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581608313; cv=none; d=google.com; s=arc-20160816; b=S5VqawFyW4T8pG3fVLCA+ZBkOUCdd19jsmL/mv7kn8/UlAEh73Ow9UZTwMssB+j3lu 0K7/URrFHNtF+ftfIn6CcAwqBJmXxo1oZ0HQJ0hkPnc2AIqAn1Awnxfx2zEuCM/QE1Aw Z1BuMv9ivJhVngR4Ht6zuxa1y2FjaN5+FlA/s7SZQN5AHAdJwnf22a7fdulFFQdj6qpZ uHDc9ew66tFTEmBTqxDw4NNPx76p6PHFiBNIQLn1lVdRpTbIv0XOb5p82UmZDzAKVVWd jQ7aeljME5FZKecEBMk9XK3N1CfOf/AnnpxMhlRl2mPfQZLlsIEauxUL3kLoiNQJadJW 0IUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=JTLH+v9RHvVIdEQVBzIzKLz1GWgSzV5/+JlQxZ2OH0s=; b=qp5tyW+HZ3rsjmUpJLQKEvy6gK8omQBaAZIJ1RgJQNfBpfgJaMqIbJKkAYKAeIXp5V xjCRMGI17jrNWVMoUilH+GZh8U1Y08EjLVcI57k5OcZjP4vpYKGAAmqryYLn3tbuWL2Y EFVgpfk8NJkzauezCnuRWa2zT03t1it96wtJ/5b7ToL7s1p/LJhUWhhjHd3Ms99TaRBk OKs/OMcQRbEsNRwnsTwxnMSVss9/KoJDckTmoEdWU8vmDCCNHt1nesBwtl/NUR8Udelj p4YGM/jKprqfQEkIZ28s1EKpqv54KyZLq+vbJ6xW3xd7VqMt3LVR2jkps84oPS6xNYmf AiYw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=BqEluBXN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r22si1220573otn.192.2020.02.13.07.38.20; Thu, 13 Feb 2020 07:38:33 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=BqEluBXN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729013AbgBMP3n (ORCPT + 99 others); Thu, 13 Feb 2020 10:29:43 -0500 Received: from mail.kernel.org ([198.145.29.99]:47398 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729268AbgBMP0v (ORCPT ); Thu, 13 Feb 2020 10:26:51 -0500 Received: from localhost (unknown [104.132.1.104]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2134A222C2; Thu, 13 Feb 2020 15:26:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581607611; bh=uEqBD+pRryWe/jG4/xFJ/zSOq1zd6Fja6rU94sP9RLU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BqEluBXNDvUn3XVMp3Q9b/tjk66hcFWY+1Dh9+1Ii8ds18y+8xrr/p4vXYxg4m5V/ 6Or2mnZoFqvs8Uoj5kgwD/TKRhNdlWukAhfGF4jNKqerVltThPjxue/oKmQdMT1dxX 1P/twHa5LQMX/CjQgnnhoLJqM7qmm+g6RNUO3zI0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Gavin Shan , Marc Zyngier Subject: [PATCH 4.19 36/52] KVM: arm/arm64: Fix young bit from mmu notifier Date: Thu, 13 Feb 2020 07:21:17 -0800 Message-Id: <20200213151825.176692550@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200213151810.331796857@linuxfoundation.org> References: <20200213151810.331796857@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Gavin Shan commit cf2d23e0bac9f6b5cd1cba8898f5f05ead40e530 upstream. kvm_test_age_hva() is called upon mmu_notifier_test_young(), but wrong address range has been passed to handle_hva_to_gpa(). With the wrong address range, no young bits will be checked in handle_hva_to_gpa(). It means zero is always returned from mmu_notifier_test_young(). This fixes the issue by passing correct address range to the underly function handle_hva_to_gpa(), so that the hardware young (access) bit will be visited. Fixes: 35307b9a5f7e ("arm/arm64: KVM: Implement Stage-2 page aging") Signed-off-by: Gavin Shan Signed-off-by: Marc Zyngier Link: https://lore.kernel.org/r/20200121055659.19560-1-gshan@redhat.com Signed-off-by: Greg Kroah-Hartman --- virt/kvm/arm/mmu.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/virt/kvm/arm/mmu.c +++ b/virt/kvm/arm/mmu.c @@ -1925,7 +1925,8 @@ int kvm_test_age_hva(struct kvm *kvm, un if (!kvm->arch.pgd) return 0; trace_kvm_test_age_hva(hva); - return handle_hva_to_gpa(kvm, hva, hva, kvm_test_age_hva_handler, NULL); + return handle_hva_to_gpa(kvm, hva, hva + PAGE_SIZE, + kvm_test_age_hva_handler, NULL); } void kvm_mmu_free_memory_caches(struct kvm_vcpu *vcpu)