Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp686516ybv; Thu, 13 Feb 2020 07:46:04 -0800 (PST) X-Google-Smtp-Source: APXvYqy+mbs5BXwdBMon4eM+meCoDLb8ZQsTSkQlk/hYFCS6jCaNEqd1NOiTZaMhWuvMtij+RS8E X-Received: by 2002:a05:6830:9a:: with SMTP id a26mr14195197oto.273.1581608764645; Thu, 13 Feb 2020 07:46:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581608764; cv=none; d=google.com; s=arc-20160816; b=hlpRE0mp9gjjcQGJQxCWGq40q3C70q+OuSF0p4k3O2ONBWM8V9Etw8A4idi3y6qgci yCrNRsun3xWBnhfzGwMb2RBwuGEvCJxbIpzGkWyibDx7Pbb96As6e8ZjnbUkwvwlwVFS /cvv1jR45PizA7j4XB8mz55oseUSQcAXDINyLoNeuAhUg1eU+TqWE0/sFu6mZjpkZIQg p70KmU/OBqL3BYXGa8GQur9AOgUWuCZkLmfoWrxAYvcY14Yv/1ZN7OCgprX0hJt95blo Qr5febbMKCWoqZNVM+PSkJT0+S29PHZxkEqlCOKdLOrBJlzVPCfV5DXuw8fp5mWjwLm2 zF4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=9OqGBrxbsPyGNyUz62VEj9y6ClQfG433v9C6rwJdrvA=; b=uAyIqVpWwWnRqfRH8FVBKNQrA5c6FipSAIpcqM8jY6dWt6FNHzY23ujfwx0NeMZbTI HQZwMV6/2ZZMaoYONjw2hKKQFwPLV7tq6bLR0nSfmAjir/40u3U1KrOUDM5AG0puWBTP ypzu/yrjbaejneoHYV4/Vl2qUFuFKgp08nTJcH+eEXuaSDSD7Yqy0c+wnctjuqmK13eY YBzoKQAjPbtVacIyRRfdbE/3XJFHT33ZEvDFI91xBOlkrtDnoXkfWDoVO4GYo9JY0Qo4 e+MbD+BnT+fRRUM+vwh37/XvVMKjmsEdLqQMSlx4BoLOTXKDxhRx2yDZzhXNUky0Ftsk H2xw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=wFbqLfw8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i13si1207988oth.175.2020.02.13.07.45.51; Thu, 13 Feb 2020 07:46:04 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=wFbqLfw8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729503AbgBMPpn (ORCPT + 99 others); Thu, 13 Feb 2020 10:45:43 -0500 Received: from mail.kernel.org ([198.145.29.99]:50548 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728942AbgBMP10 (ORCPT ); Thu, 13 Feb 2020 10:27:26 -0500 Received: from localhost (unknown [104.132.1.104]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2E4692465D; Thu, 13 Feb 2020 15:27:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581607646; bh=vF3vpiJfV5jRF2elPwqFz17RlyJWH7ft1gujGBsgYYU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=wFbqLfw8ya/9qz6NOA037cwKVFCAJeTDpky+6S3P8EZibrd8tXMYfqbjc001FbOoq ilmnvV2lDg/+bXazIdY8qdq13I/OJJrOvOmag1ESj3hf7ao1YuSgU1Yr9/GCFC+m7G /uslvqefVE3UQjjXVbgEyOYD3hXhPSi46PFinxg4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Sai Prakash Ranjan , Bjorn Andersson , Guenter Roeck , Stephen Boyd , Wim Van Sebroeck Subject: [PATCH 5.4 38/96] watchdog: qcom: Use platform_get_irq_optional() for bark irq Date: Thu, 13 Feb 2020 07:20:45 -0800 Message-Id: <20200213151854.039679791@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200213151839.156309910@linuxfoundation.org> References: <20200213151839.156309910@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sai Prakash Ranjan commit e0b4f4e0cf7fa9d62628d4249c765ec18dffd143 upstream. platform_get_irq() prints an error message when the interrupt is not available. So on platforms where bark interrupt is not specified, following error message is observed on SDM845. [ 2.975888] qcom_wdt 17980000.watchdog: IRQ index 0 not found This is also seen on SC7180, SM8150 SoCs as well. Fix this by using platform_get_irq_optional() instead. Fixes: 36375491a4395654 ("watchdog: qcom: support pre-timeout when the bark irq is available") Signed-off-by: Sai Prakash Ranjan Reviewed-by: Bjorn Andersson Reviewed-by: Guenter Roeck Reviewed-by: Stephen Boyd Link: https://lore.kernel.org/r/20191213064934.4112-1-saiprakash.ranjan@codeaurora.org Signed-off-by: Guenter Roeck Signed-off-by: Wim Van Sebroeck Signed-off-by: Greg Kroah-Hartman --- drivers/watchdog/qcom-wdt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/watchdog/qcom-wdt.c +++ b/drivers/watchdog/qcom-wdt.c @@ -246,7 +246,7 @@ static int qcom_wdt_probe(struct platfor } /* check if there is pretimeout support */ - irq = platform_get_irq(pdev, 0); + irq = platform_get_irq_optional(pdev, 0); if (irq > 0) { ret = devm_request_irq(dev, irq, qcom_wdt_isr, IRQF_TRIGGER_RISING,