Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp690162ybv; Thu, 13 Feb 2020 07:49:48 -0800 (PST) X-Google-Smtp-Source: APXvYqzwkpaUssvyQWV+AGmI8wj/B1bjhymQ/6KQp0a3SEzqi2GqU1fznHv9mqSY10Rn31vksZaF X-Received: by 2002:aca:5dc3:: with SMTP id r186mr3385092oib.137.1581608987949; Thu, 13 Feb 2020 07:49:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581608987; cv=none; d=google.com; s=arc-20160816; b=ROV83Px6t61EFntxDW/ovWAjXfKMFPE2LV4wAuU9aszf+Qjw6E2p/am7emS3SQL8Ik +B6zeUFqDqzEXDfDbEOylMkByHy+mZmlsd7Ewinj86NFFxbH1JmFbb+8P+LA3+57Rb3f 4NzYHTVkOZD4kE+r0qNyb78Sut3Axz0JVGVWYPkdd61hU3OuGaN6N3Udeyr1Wk4ToYwJ owAlKL8lG2svwENgfmG72ZUsflLYB467Vkzd/EgxnZ6SQc8zYsoQlnPlWaCDk3gAX2A8 DzScsGcL9DmzELZzjokiQY3yGIuEWTvHb3y28Q4a8UmryMUyl/G7pSbIBUvaxldCJ0Ec DbfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=EMIPQYnTwgIjkdzlFJVF9Mv99n6P5f3BM3nad+93a8g=; b=vhGioKqD+GDd2Oqtd4mJXhbedcgmR9M4bOsPYRuCSrKJ1Qt4YstEB6RDMs0kzKc2xb UR1c5olLh4i8PibdNReo9sqq3aUuBOy7l6c+FDsTX8+9a8gZuEcO6dXScbHOMWH4BCwW b6qBERwqeByAUAU1daSMtL48UzGE6wRgx7Cy0scKmf/701BYA2ApoVhoiDL94j7M4Owc 0+Z4NP1H8BssufFiXN3d/AzsD4NCX3VSOJj173g/tOZ1lm1ARPO2PJExPgZNSUo3Vgjz MqTAOVeTGNZfHDzpWojpdqpLTkpQiaImvROKR7o6SiW4WvHoMmQ7gwrUxSZbePzqGreI R3tg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=tLeSNH9J; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v24si1267468otn.125.2020.02.13.07.49.34; Thu, 13 Feb 2020 07:49:47 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=tLeSNH9J; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729503AbgBMPs3 (ORCPT + 99 others); Thu, 13 Feb 2020 10:48:29 -0500 Received: from mail.kernel.org ([198.145.29.99]:47914 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729296AbgBMP04 (ORCPT ); Thu, 13 Feb 2020 10:26:56 -0500 Received: from localhost (unknown [104.132.1.104]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 97B4C2465D; Thu, 13 Feb 2020 15:26:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581607615; bh=S7bOtw8DY7CZu+78NqMqNEcEoAyaXmvP+s1qMErXI6Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tLeSNH9J1f9MJonz0D0Jm+ULZbI7LKM5Bpx31fz39BHrG0XuxvbWLc+QLik/P4kzB KdLKfLPUpFoZy0KQrHbRQqgl3G69HLDaSa8oU0xzyQAh9mwUtIcO7WCtu0Nr2atWl7 e4dEonyJB7UBMn04VAMIbljbvoB6XrgTzRavQJls= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "Peter Zijlstra (Intel)" , Josh Poimboeuf , Linus Torvalds , Thomas Gleixner , Ingo Molnar , Dmitry Safonov Subject: [PATCH 4.19 52/52] x86/stackframe, x86/ftrace: Add pt_regs frame annotations Date: Thu, 13 Feb 2020 07:21:33 -0800 Message-Id: <20200213151831.169671579@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200213151810.331796857@linuxfoundation.org> References: <20200213151810.331796857@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Peter Zijlstra commit ea1ed38dba64b64a245ab8ca1406269d17b99485 upstream. When CONFIG_FRAME_POINTER, we should mark pt_regs frames. Signed-off-by: Peter Zijlstra (Intel) Reviewed-by: Josh Poimboeuf Cc: Linus Torvalds Cc: Peter Zijlstra Cc: Thomas Gleixner Signed-off-by: Ingo Molnar [4.19 backport; added user-visible changelog] Signed-off-by: Dmitry Safonov Signed-off-by: Greg Kroah-Hartman --- arch/x86/kernel/ftrace_32.S | 3 +++ arch/x86/kernel/ftrace_64.S | 3 +++ 2 files changed, 6 insertions(+) --- a/arch/x86/kernel/ftrace_32.S +++ b/arch/x86/kernel/ftrace_32.S @@ -9,6 +9,7 @@ #include #include #include +#include #ifdef CC_USING_FENTRY # define function_hook __fentry__ @@ -131,6 +132,8 @@ ENTRY(ftrace_regs_caller) pushl %ecx pushl %ebx + ENCODE_FRAME_POINTER + movl 12*4(%esp), %eax /* Load ip (1st parameter) */ subl $MCOUNT_INSN_SIZE, %eax /* Adjust ip */ #ifdef CC_USING_FENTRY --- a/arch/x86/kernel/ftrace_64.S +++ b/arch/x86/kernel/ftrace_64.S @@ -9,6 +9,7 @@ #include #include #include +#include .code64 .section .entry.text, "ax" @@ -222,6 +223,8 @@ GLOBAL(ftrace_regs_caller_op_ptr) leaq MCOUNT_REG_SIZE+8*2(%rsp), %rcx movq %rcx, RSP(%rsp) + ENCODE_FRAME_POINTER + /* regs go into 4th parameter */ leaq (%rsp), %rcx