Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp692175ybv; Thu, 13 Feb 2020 07:51:57 -0800 (PST) X-Google-Smtp-Source: APXvYqzprrB+PUh+tY8KJbrQlJKxBlCJmFh78YBuGB++j2fs1B7rYscCUl41ik+G53c8RecYgsm4 X-Received: by 2002:a9d:64b:: with SMTP id 69mr13342668otn.237.1581609117713; Thu, 13 Feb 2020 07:51:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581609117; cv=none; d=google.com; s=arc-20160816; b=AmaQTtJHqFRYnofJEac5zrjMThjB88WIKOxCpAXlgOYHb24Odt52ZgtPYRoBMyg97C mIMoVZiyamnIuqww477wKb7rcVTbz+Ag21QprFy8b5qeegsKbCjsuD4JZVNHy+wUh3Fl Thwwavt1Mkh3h+dAId6XR64IBxlZz1V+3Pp2ncFBNEM2dXCy6/gJF/0EHH1rNyIydETa 7H3iRRzsW0AEc1HxcK1r4Yj6+m42GUnuqE9ZtE6nrcym3gvqmUobgi11931g08FCU8R3 Ai0J1TpAckHk+d61jwr38LQp6G1uB/XcxmXmIotq568kUvwfg3Pau588b2Joz62TNchE mE0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Z4Cmh3WD1moHwmZdeYeAh8werBf6bH+psHwKtm2nX44=; b=IMkXc8N61nJlvxJR0EyGVsbEDTD2p3FInZ3may+u3t1BYZrPH0YXYXhDNkdp9/j1Hb lhyNX4LL+AgOm5f2uXelDBpVJZp6aFjc6DgN42NzZwB6pwYSVzOXo1GB0zubsTRvAjrE susEv0cJljXekEFbFWzDow1mqcQZm8wvzCiPUqfl0Vw5fuQOCPGTJr+Iw6Q7mJtNiLSF h5JSYmeB26dLV0b4NMnyrZPkcZgrtcqNrG9PyHbTLsjpL3wQRLAE4o8UxINq9UCH8z0m D9iT4OAXjCkIZMRip+Q1pJTf7X9f7uJRCt6r2dz4TNgsSNGrSlHozgTOIRGF5ToMMkgW /rCg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=POH54u7V; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p191si1287529oic.257.2020.02.13.07.51.44; Thu, 13 Feb 2020 07:51:57 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=POH54u7V; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729182AbgBMP0N (ORCPT + 99 others); Thu, 13 Feb 2020 10:26:13 -0500 Received: from mail.kernel.org ([198.145.29.99]:37896 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728693AbgBMPY0 (ORCPT ); Thu, 13 Feb 2020 10:24:26 -0500 Received: from localhost (unknown [104.132.1.104]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DF26824689; Thu, 13 Feb 2020 15:24:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581607466; bh=FxYiCaXQskh90KrwG3iV7GTqM8cjabD5+J+amsqs1UY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=POH54u7Vr79CHJl7fGsj9PiBOiU9VnNHlV4XCWj74sCtITXqGfCpT2LEULk8fu01y EH/EIj5crObIh5NL+z5pa5Ksls0jVXRrFXjFQK+t9M0Y3lagttU/SBu0E98P2OPYW1 KP66uN+s4T/Azpjw8mqwZvBTcwr7AUsRRrX3q2ZA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Geert Uytterhoeven , Anna Schumaker Subject: [PATCH 4.9 101/116] nfs: NFS_SWAP should depend on SWAP Date: Thu, 13 Feb 2020 07:20:45 -0800 Message-Id: <20200213151921.815202739@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200213151842.259660170@linuxfoundation.org> References: <20200213151842.259660170@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Geert Uytterhoeven commit 474c4f306eefbb21b67ebd1de802d005c7d7ecdc upstream. If CONFIG_SWAP=n, it does not make much sense to offer the user the option to enable support for swapping over NFS, as that will still fail at run time: # swapon /swap swapon: /swap: swapon failed: Function not implemented Fix this by adding a dependency on CONFIG_SWAP. Fixes: a564b8f0398636ba ("nfs: enable swap on NFS") Signed-off-by: Geert Uytterhoeven Signed-off-by: Anna Schumaker Signed-off-by: Greg Kroah-Hartman --- fs/nfs/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/fs/nfs/Kconfig +++ b/fs/nfs/Kconfig @@ -89,7 +89,7 @@ config NFS_V4 config NFS_SWAP bool "Provide swap over NFS support" default n - depends on NFS_FS + depends on NFS_FS && SWAP select SUNRPC_SWAP help This option enables swapon to work on files located on NFS mounts.