Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp709735ybv; Thu, 13 Feb 2020 08:08:31 -0800 (PST) X-Google-Smtp-Source: APXvYqzBPlLmF8N85EP+/19r3klatx8B428Q2BbobZICfcgM2nYd041RrHuJNgHU1hIsZLLUsMjw X-Received: by 2002:aca:6742:: with SMTP id b2mr3522825oiy.86.1581610111649; Thu, 13 Feb 2020 08:08:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581610111; cv=none; d=google.com; s=arc-20160816; b=lPZNBVxjJ0vNowlAiYSLNIb6bt581Ms0iNAqvHqxE+TT5K5aU8H8xzA48T0DIclLkb 53cCpybkVaRokq95Bf02SqXsXuMcatqeRPvmVInYmQCv3r4i4KD6++UsUC4CSyNeUHYd /rHS1aWnqtRH35NAz+AeE6Pd27LHgTHuiFQElJDzL6MI5sltT8J9padvbhrPEmFDAiZc 2QEveWLZsjD6pThOYrCtGD9ujtjHPKrvE+bZEktcnN7T9cF/SyK4JmeW5Mz4OHgL6/7B WpR0/DxQnmqA9925kf1q/zsMNKex5JiS0rhrYaVNB/iXTTWAyCRZt7WAzAPxI53gfyt7 xJzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=dauqs5TA/iIjmw1k3yCCh+8ejBRhpg/iiJree47R1JQ=; b=qtv3R04B1uT+KTmfcDeXC3PhN5sbecWzt0VB7544k53ajBN/SqLMpG9IpbnKOS31v0 pJpPcob0EPnOwRR7ids1aqD/b8e4PeH6qXUkmG3iTO4kjH2G0FzbLXLzlAq8Nh2uqz7G BJOqjo/4zn9y7tYlBCp+8NYFg1PN4nN//DbIiUd3ues4BlYovvc5oynZ1aYaoNN9wIbs gN7K5Rllnflcf+hNKZi9DDdYwnEt6vFJFHLJxo8ATsbYtxpX1OHNXRJeAemVI9HacV1V iJhQirjwK+f0mFNJyVLRxoNqbbeDErF5GYLAwfNRiBvEXZFEotlACqch8yS1N2yYKJWV 9NFQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Jx9xbt1m; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h18si1296986otk.227.2020.02.13.08.08.14; Thu, 13 Feb 2020 08:08:31 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Jx9xbt1m; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388245AbgBMQHg (ORCPT + 99 others); Thu, 13 Feb 2020 11:07:36 -0500 Received: from mail.kernel.org ([198.145.29.99]:34240 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728339AbgBMPXT (ORCPT ); Thu, 13 Feb 2020 10:23:19 -0500 Received: from localhost (unknown [104.132.1.104]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B83AA24699; Thu, 13 Feb 2020 15:23:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581607398; bh=QShqcSf1EUDxBw4zST+eXVUEBHGNuuu/vqFun/0d5Eo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Jx9xbt1m5ejV2wAKB3FcF14cgr69TAiPtFlhmjPCAjiDraaQ7H4YfYtp8jv+Wm61G Fz8QO8DQ7BEjgFADJgSf4z99IN3Row7xc5AI5RW748SYNTB6VPESvoJk4JXdr+eEKf RVKm4KOIZJcQZ6kNlbVjstwsQ/fijOo9vR5rlsjc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Eric Dumazet , Martin KaFai Lau , Yuchung Cheng , Neal Cardwell , Jakub Kicinski Subject: [PATCH 4.9 013/116] tcp: clear tp->data_segs{in|out} in tcp_disconnect() Date: Thu, 13 Feb 2020 07:19:17 -0800 Message-Id: <20200213151847.863022869@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200213151842.259660170@linuxfoundation.org> References: <20200213151842.259660170@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Eric Dumazet [ Upstream commit db7ffee6f3eb3683cdcaeddecc0a630a14546fe3 ] tp->data_segs_in and tp->data_segs_out need to be cleared in tcp_disconnect(). tcp_disconnect() is rarely used, but it is worth fixing it. Fixes: a44d6eacdaf5 ("tcp: Add RFC4898 tcpEStatsPerfDataSegsOut/In") Signed-off-by: Eric Dumazet Cc: Martin KaFai Lau Cc: Yuchung Cheng Cc: Neal Cardwell Acked-by: Neal Cardwell Signed-off-by: Jakub Kicinski Signed-off-by: Greg Kroah-Hartman --- net/ipv4/tcp.c | 2 ++ 1 file changed, 2 insertions(+) --- a/net/ipv4/tcp.c +++ b/net/ipv4/tcp.c @@ -2316,6 +2316,8 @@ int tcp_disconnect(struct sock *sk, int tcp_saved_syn_free(tp); tp->bytes_acked = 0; tp->bytes_received = 0; + tp->data_segs_in = 0; + tp->data_segs_out = 0; WARN_ON(inet->inet_num && !icsk->icsk_bind_hash);