Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp709841ybv; Thu, 13 Feb 2020 08:08:36 -0800 (PST) X-Google-Smtp-Source: APXvYqzdLC04j//5Qngc1ImMfWFpdh4h7lXZt8F3+ugb1RNVjmBnBlZ9buXEAWwHKOZ2GDX2qALY X-Received: by 2002:a9d:268:: with SMTP id 95mr14186019otb.183.1581610116547; Thu, 13 Feb 2020 08:08:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581610116; cv=none; d=google.com; s=arc-20160816; b=vjFTxzWLIb1PpnoUbt/dhR4dfletadfN6e6+th/apHPSkexkGB7qz5phE7pwDFZQrY 3SCau2xKtnkRQzH32iVySLXD0M8twBFPIC5do7xdpY5DUAVqqiOOmbIyl3rgut50YYRR FS8k4+vMUr3NwXXalpnQujrfvlqgPcTJMewVpyMtDEwLHO8zwpWXBZydTCxjVgUTxS11 oZDvk3DeoTH3FSgT7okXiAWL83/3q2OVm8Y1bKxNAUzs3tF1sNavHjb+AHhTInRSdIAB gfamXQ3yWvAYBiApCYFI777OSauQcgp6aLLwir8MlbA55g/EMA/RW9Pa7baLG1H20doo javQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=MZBGr9WvOg9qBWlQM4kAlgcNpeNw3UPGk92D8JtQMe0=; b=q7gJWOvAhuSGVp/nyI76Qjj+t0c68ZSg1k1w//xxK8WHXnQS6jT6GOmYPv5UMt03W/ x24XCPu5UIJoHmIjUsxKb7ce+XWqOGel+cYP7qiAp0qCFCKLhpCTRKvb1WFPPzX0HDfu DJvXkwkuEVV3ghNTPHk2YGlFaN9ixCKADsae9BdOdd1DcsadjAu92K8eyDYQanbvJXfO NRLmYgqXupmvp2pVnSEmLEAR59HS8dORwzGGHlWe75J5tx1iVj7PbiN+MnJ9VXxcPjZq XWPqm4prRwbBlaVULtABg5DBKS2IGRcbzj073YUgw2OAX+JjUe89dJXT0T/9zkBIyZ1q LhCQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="cuxyDbT/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r1si1196946otn.150.2020.02.13.08.08.22; Thu, 13 Feb 2020 08:08:36 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="cuxyDbT/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388341AbgBMQHt (ORCPT + 99 others); Thu, 13 Feb 2020 11:07:49 -0500 Received: from mail.kernel.org ([198.145.29.99]:33858 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728331AbgBMPXR (ORCPT ); Thu, 13 Feb 2020 10:23:17 -0500 Received: from localhost (unknown [104.132.1.104]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6D5C4246C1; Thu, 13 Feb 2020 15:23:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581607397; bh=5P2ZoAS8iW57cEU+808Z4LNRPtVpxp01ip+yBhyB0qU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cuxyDbT/mWys80DYPcjTYm5dtZgMGpVN1Tfr6tdprz5DRFaZIl2H2rU3+k/C/gneA bw45b0uP1XFfBh3/q6Q/j9C+Jp6eCfzBS3fJjYkZVl+pMz4M/2I7QNmgk8FeVW2V9G YGMuWLRAjekfyNWsoBn622/Wp/yFtlU9HgBZWvyA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Eric Dumazet , SeongJae Park , Jakub Kicinski Subject: [PATCH 4.9 011/116] tcp: clear tp->total_retrans in tcp_disconnect() Date: Thu, 13 Feb 2020 07:19:15 -0800 Message-Id: <20200213151847.121055994@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200213151842.259660170@linuxfoundation.org> References: <20200213151842.259660170@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Eric Dumazet [ Upstream commit c13c48c00a6bc1febc73902505bdec0967bd7095 ] total_retrans needs to be cleared in tcp_disconnect(). tcp_disconnect() is rarely used, but it is worth fixing it. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Eric Dumazet Cc: SeongJae Park Signed-off-by: Jakub Kicinski Signed-off-by: Greg Kroah-Hartman --- net/ipv4/tcp.c | 1 + 1 file changed, 1 insertion(+) --- a/net/ipv4/tcp.c +++ b/net/ipv4/tcp.c @@ -2301,6 +2301,7 @@ int tcp_disconnect(struct sock *sk, int tcp_set_ca_state(sk, TCP_CA_Open); tp->is_sack_reneg = 0; tcp_clear_retrans(tp); + tp->total_retrans = 0; inet_csk_delack_init(sk); /* Initialize rcv_mss to TCP_MIN_MSS to avoid division by 0 * issue in __tcp_select_window()