Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 13 Feb 2020 08:27:21 -0800
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Stephen Smalley <sds@tycho.nsa.gov>
Cc:     linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        Will Deacon <will@kernel.org>, Paul Moore <paul@paul-moore.com>
Subject: Re: [PATCH 5.4 85/96] selinux: revert "stop passing MAY_NOT_BLOCK to
 the AVC upon follow_link"
Message-ID: <20200213162721.GA3636914@kroah.com>
References: <20200213151839.156309910@linuxfoundation.org>
 <20200213151911.147099125@linuxfoundation.org>
 <b481f512-d4dd-1c04-f39f-0ba271193d0a@tycho.nsa.gov>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <b481f512-d4dd-1c04-f39f-0ba271193d0a@tycho.nsa.gov>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Feb 13, 2020 at 11:01:41AM -0500, Stephen Smalley wrote:
> On 2/13/20 10:21 AM, Greg Kroah-Hartman wrote:
> > From: Stephen Smalley <sds@tycho.nsa.gov>
> > 
> > commit 1a37079c236d55fb31ebbf4b59945dab8ec8764c upstream.
> > 
> > This reverts commit e46e01eebbbc ("selinux: stop passing MAY_NOT_BLOCK
> > to the AVC upon follow_link"). The correct fix is to instead fall
> > back to ref-walk if audit is required irrespective of the specific
> > audit data type.  This is done in the next commit.
> > 
> > Fixes: e46e01eebbbc ("selinux: stop passing MAY_NOT_BLOCK to the AVC upon follow_link")
> > Reported-by: Will Deacon <will@kernel.org>
> > Signed-off-by: Stephen Smalley <sds@tycho.nsa.gov>
> > Signed-off-by: Paul Moore <paul@paul-moore.com>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> 
> This patch should be accompanied by commit
> 0188d5c025ca8fe756ba3193bd7d150139af5a88 ("selinux: fall back to ref-walk if
> audit is required").  The former is reverting an incorrect fix for
> bda0be7ad994 ("security: make inode_follow_link RCU-walk aware"), the latter
> is providing the correct fix for it.

Thanks for letting me know, now queued up for both trees.

greg k-h