Subject: Re: [PATCH 11/12] LED: Add IDE disk activity LED trigger
From: Richard Purdie <rpurdie@rpsys.net>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Andrew Morton <akpm@osdl.org>
In-Reply-To: <58cb370e0602060853i469d3449j5d2673b407aec460@mail.gmail.com>
References: <1139154893.14624.15.camel@localhost.localdomain>
	 <58cb370e0602060853i469d3449j5d2673b407aec460@mail.gmail.com>
Content-Type: text/plain
Date: Wed, 08 Feb 2006 03:12:58 +0000
Message-Id: <1139368379.6422.180.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1131
Lines: 32

On Mon, 2006-02-06 at 17:53 +0100, Bartlomiej Zolnierkiewicz wrote:
> > +{
> > +       led_trigger_event(ide_led_trigger, LED_OFF);
> 
> It should check for blk_fs_request().
> 
> ->end_request() can be used for other request types.
> 
> > +       ide_end_request(drive, uptodate, nr_sectors);
> > +}
> > +
> >
> >  static void __exit idedisk_exit (void)
> >  {
> > +       led_trigger_unregister_simple(ide_led_trigger);
> >         driver_unregister(&idedisk_driver.gen_driver);
> 
> Shouldn't ordering be reverse to this in idedisk_init()?
> First driver_unregister(), then led_trigger_unregister_simple()?

The other issues should have been addressed in -mm now, thanks. An event
call after unregistering a trigger will not trouble the led trigger code
as it was designed to withstand this. In -mm it now matches the order in
the init function but this is purely cosmetic.

Richard

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/