Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <48174ba52460d317a630df1389fbb76f5a733250.camel@redhat.com>
Subject: Re: [PATCH 03/18] c6x: replace setup_irq() by request_irq()
From:   Mark Salter <msalter@redhat.com>
To:     afzal mohammed <afzal.mohd.ma@gmail.com>,
        linux-c6x-dev@linux-c6x.org, linux-kernel@vger.kernel.org
Cc:     Aurelien Jacquiot <jacquiot.aurelien@gmail.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Enrico Weigelt <info@metux.net>,
        Kate Stewart <kstewart@linuxfoundation.org>,
        Allison Randal <allison@lohutok.net>
Date:   Thu, 13 Feb 2020 12:37:40 -0500
In-Reply-To: <11cbe657937077b56bd28d277c9b9455a6985501.1581478324.git.afzal.mohd.ma@gmail.com>
References: <cover.1581478323.git.afzal.mohd.ma@gmail.com>
         <11cbe657937077b56bd28d277c9b9455a6985501.1581478324.git.afzal.mohd.ma@gmail.com>
Organization: Red Hat, Inc
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.34.3 (3.34.3-1.fc31) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 2020-02-12 at 13:32 +0530, afzal mohammed wrote:
> request_irq() is preferred over setup_irq(). Existing callers of
> setup_irq() reached mostly via 'init_IRQ()' & 'time_init()', while
> memory allocators are ready by 'mm_init()'.
> 
> Per tglx[1], setup_irq() existed in olden days when allocators were not
> ready by the time early interrupts were initialized.
> 
> Hence replace setup_irq() by request_irq().
> 
> Seldom remove_irq() usage has been observed coupled with setup_irq(),
> wherever that has been found, it too has been replaced by free_irq().
> 
> [1] https://lkml.kernel.org/r/alpine.DEB.2.20.1710191609480.1971@nanos
> 
> Signed-off-by: afzal mohammed <afzal.mohd.ma@gmail.com>
> ---
> 
> Since cc'ing cover letter to all maintainers/reviewers would be too
> many, refer for cover letter,
>  https://lkml.kernel.org/r/cover.1581478323.git.afzal.mohd.ma@gmail.com
> 
>  arch/c6x/platforms/timer64.c | 11 +++--------
>  1 file changed, 3 insertions(+), 8 deletions(-)
> 
> diff --git a/arch/c6x/platforms/timer64.c b/arch/c6x/platforms/timer64.c
> index d98d94303498..ceee34c51d4b 100644
> --- a/arch/c6x/platforms/timer64.c
> +++ b/arch/c6x/platforms/timer64.c
> @@ -165,13 +165,6 @@ static irqreturn_t timer_interrupt(int irq, void *dev_id)
>  	return IRQ_HANDLED;
>  }
>  
> -static struct irqaction timer_iact = {
> -	.name		= "timer",
> -	.flags		= IRQF_TIMER,
> -	.handler	= timer_interrupt,
> -	.dev_id		= &t64_clockevent_device,
> -};
> -
>  void __init timer64_init(void)
>  {
>  	struct clock_event_device *cd = &t64_clockevent_device;
> @@ -238,7 +231,9 @@ void __init timer64_init(void)
>  	cd->cpumask		= cpumask_of(smp_processor_id());
>  
>  	clockevents_register_device(cd);
> -	setup_irq(cd->irq, &timer_iact);
> +	if (request_irq(cd->irq, timer_interrupt, IRQF_TIMER, "timer",
> +			&t64_clockevent_device))
> +		pr_err("request_irq() on %s failed\n", "timer");
>  
>  out:
>  	of_node_put(np);

Acked-by: Mark Salter <msalter@redhat.com>