Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 13 Feb 2020 09:57:53 -0800
From:   "Darrick J. Wong" <darrick.wong@oracle.com>
To:     Christoph Hellwig <hch@lst.de>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Regression: hibernation is broken since
 e6bc9de714972cac34daa1dc1567ee48a47a9342
Message-ID: <20200213175753.GS6874@magnolia>
References: <20200213172351.GA6747@dumbo>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200213172351.GA6747@dumbo>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Feb 13, 2020 at 06:23:51PM +0100, Domenico Andreoli wrote:
> Hi,
> 
>   at some point between 5.2 and 5.3 my laptop started to refuse
> hibernating and come back to a full functional state. It's fully 100%
> reproducible, no oopses or any other damage to the state seems to happen.
> 
> It took me a while to follow the trail down to this commit. If I revert
> it from v5.6-rc1, the hibernation is back as in the old times.

Hmm, do you know which hibernation mechanism your computer is using?

--D

> 
> commit e6bc9de714972cac34daa1dc1567ee48a47a9342
> Merge: b6c0d3577246 dc617f29dbe5
> Author: Linus Torvalds <torvalds@linux-foundation.org>
> Date:   Wed Sep 18 17:35:20 2019 -0700
> 
>     Merge tag 'vfs-5.4-merge-1' of git://git.kernel.org/pub/scm/fs/xfs/xfs-linux
> 
>     Pull swap access updates from Darrick Wong:
>      "Prohibit writing to active swap files and swap partitions.
> 
>       There's no non-malicious use case for allowing userspace to scribble
>       on storage that the kernel thinks it owns"
> 
>     * tag 'vfs-5.4-merge-1' of git://git.kernel.org/pub/scm/fs/xfs/xfs-linux:
>       vfs: don't allow writes to swap files
>       mm: set S_SWAPFILE on blockdev swap devices
> 
> 
> Is it possible to do anything?
> 
> Regards,
> Domenico
> 
> -- 
> rsa4096: 3B10 0CA1 8674 ACBA B4FE  FCD2 CE5B CF17 9960 DE13
> ed25519: FFB4 0CC3 7F2E 091D F7DA  356E CC79 2832 ED38 CB05