Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp937645ybv; Thu, 13 Feb 2020 12:22:23 -0800 (PST) X-Google-Smtp-Source: APXvYqx4/iZcQc0eNAeG4MiGL1ryB3FZ3kEcsms7GyBtoQt6SMAcTmH+KSMkkEGcSv2+zitxqePt X-Received: by 2002:a05:6830:1188:: with SMTP id u8mr14808295otq.274.1581625343757; Thu, 13 Feb 2020 12:22:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581625343; cv=none; d=google.com; s=arc-20160816; b=ke1rcmIomDsKwwgWxxqKmrqzCKIlE1RBNlIAWo44G+pOFfwUclhp21C64MtVJdcp1K cnwJ24zOVm7MDSuPCrs4ofpZzRyq+g+bcU0DtBNkykzd62k/yCn1YeA4tncORe1VvQc1 oksSCY0/eyxpanqH32NlpTg9M+K51Z8AQvYmSUDD5RIkL08Puu9UXX8xMsmrBJC4lL/u t7iUGYzPXGullXbfmeF44GRoc3REbXQkWvv45v9BL8SdMfFVsrSATqJ9wvpFhJnd7u/R u9XWrCv6Yft/6qHih1endwvIh7IQIFHaBqWWUQT+Tmi6qhVc/qY1ci6MYxL2gK8NpHJ5 9egg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=dBNU5OFj5NK5u4pmplCiUIpAKhicOwwFYVxpSa74c6g=; b=A7VDho5Y1lBi14Khe/J6lRCfviihibAgPUMZBzaQmEJ4sID2Yki9Ft0IEnpHw0LWYi upTcsafuXgu1J7F1RyK/XXL9b8YOayqU3lgiAj+hykS1sOJk8uKrqBuYzkleh/yZSEnN +k3aO42oruj2L+14cT85jNOG7izrt5F4ofMzWTDVnJBYM6REy+P8XMJBuC34x/a+CNpq qnpaPGB6kdtEfvX7Lw2Bz0Q5XadAgua15k/K0ohfygTsDTO/O2DNwqPYpiscZ5MARgaM 0xiIktOPvXm4f4MOQ2kHewZk+A/B0tLm1AXiUyI88u/TqXIAu+aWiOGQPbYYmGu0iOv6 3kNg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=vzrh8uLm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w207si1582341oia.226.2020.02.13.12.22.11; Thu, 13 Feb 2020 12:22:23 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=vzrh8uLm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728802AbgBMUUm (ORCPT + 99 others); Thu, 13 Feb 2020 15:20:42 -0500 Received: from mail.kernel.org ([198.145.29.99]:34886 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727893AbgBMUUk (ORCPT ); Thu, 13 Feb 2020 15:20:40 -0500 Received: from ziggy.cz (unknown [37.223.145.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BC78C246B3; Thu, 13 Feb 2020 20:20:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581625239; bh=ULAzQjovtig3wxROIAGMSJhoxtzjTDYEmIV29XyjzgM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vzrh8uLmDUB9FLsJXyO7KqwQ+SCs3L5Vsh9YdlABd8VZauAU9TZuHTTai6BPlTwas er0PR84HdefQtXgyaQOLgrvmbovyHQIcZlvQ4n6ds/nYUn+KwMxL1a3RRqz6kBOedB zFWVXWj804vK6FvrSSYgEnMjWEwChh75AXUS06T0= From: matthias.bgg@kernel.org To: robh+dt@kernel.org, mark.rutland@arm.com, ck.hu@mediatek.com, p.zabel@pengutronix.de, airlied@linux.ie, mturquette@baylibre.com, sboyd@kernel.org, ulrich.hecht+renesas@gmail.com, laurent.pinchart@ideasonboard.com, enric.balletbo@collabora.com Cc: devicetree@vger.kernel.org, drinkcat@chromium.org, frank-w@public-files.de, sean.wang@mediatek.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, wens@csie.org, linux-mediatek@lists.infradead.org, rdunlap@infradead.org, matthias.bgg@kernel.org, hsinyi@chromium.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, Matthias Brugger , Greg Kroah-Hartman , Kate Stewart , Matthias Brugger , Richard Fontana , Thomas Gleixner Subject: [PATCH v7 07/13] clk: mediatek: mt2701: switch mmsys to platform device probing Date: Thu, 13 Feb 2020 21:19:47 +0100 Message-Id: <20200213201953.15268-8-matthias.bgg@kernel.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200213201953.15268-1-matthias.bgg@kernel.org> References: <20200213201953.15268-1-matthias.bgg@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Matthias Brugger Switch probing for the MMSYS to support invocation to a plain paltform device. The driver will be probed by the DRM subsystem. Signed-off-by: Matthias Brugger --- Changes in v7: - free clk_data->clks as well - get rid of private data structure Changes in v6: None Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: None drivers/clk/mediatek/clk-mt2701-mm.c | 34 +++++++++++++++++++--------- 1 file changed, 23 insertions(+), 11 deletions(-) diff --git a/drivers/clk/mediatek/clk-mt2701-mm.c b/drivers/clk/mediatek/clk-mt2701-mm.c index 054b597d4a73..eab7dd4735ad 100644 --- a/drivers/clk/mediatek/clk-mt2701-mm.c +++ b/drivers/clk/mediatek/clk-mt2701-mm.c @@ -4,8 +4,10 @@ * Author: Shunli Wang */ +#include #include #include +#include #include "clk-mtk.h" #include "clk-gate.h" @@ -79,21 +81,21 @@ static const struct mtk_gate mm_clks[] = { GATE_DISP1(CLK_MM_TVE_FMM, "mm_tve_fmm", "mm_sel", 14), }; -static const struct of_device_id of_match_clk_mt2701_mm[] = { - { .compatible = "mediatek,mt2701-mmsys", }, - {} -}; - static int clk_mt2701_mm_probe(struct platform_device *pdev) { - struct clk_onecell_data *clk_data; int r; - struct device_node *node = pdev->dev.of_node; + struct device_node *node = pdev->dev.parent->of_node; + struct clk_onecell_data *clk_data; + + clk_data = devm_kzalloc(&pdev->dev, sizeof(*clk_data), GFP_KERNEL); + if (!clk_data) + return -ENOMEM; clk_data = mtk_alloc_clk_data(CLK_MM_NR); - mtk_clk_register_gates(node, mm_clks, ARRAY_SIZE(mm_clks), - clk_data); + platform_set_drvdata(pdev, clk_data); + + mtk_clk_register_gates(node, mm_clks, ARRAY_SIZE(mm_clks), clk_data); r = of_clk_add_provider(node, of_clk_src_onecell_get, clk_data); if (r) @@ -104,12 +106,22 @@ static int clk_mt2701_mm_probe(struct platform_device *pdev) return r; } +static int clk_mt2701_mm_remove(struct platform_device *pdev) +{ + struct clk_onecell_data *clk_data = platform_get_drvdata(pdev); + + kfree(clk_data->clks); + kfree(clk_data); + + return 0; +} + static struct platform_driver clk_mt2701_mm_drv = { .probe = clk_mt2701_mm_probe, + .remove = clk_mt2701_mm_remove, .driver = { .name = "clk-mt2701-mm", - .of_match_table = of_match_clk_mt2701_mm, }, }; -builtin_platform_driver(clk_mt2701_mm_drv); +module_platform_driver(clk_mt2701_mm_drv); -- 2.24.1