Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp1023371ybv; Thu, 13 Feb 2020 14:13:06 -0800 (PST) X-Google-Smtp-Source: APXvYqz0njCQ+14Gp/zvBKa3zdqLHNcJsM6BdSEfeWq9nJNVj6rb55EmZGfQNYYHGjQGe2DALecS X-Received: by 2002:a54:408f:: with SMTP id i15mr4367240oii.64.1581631986386; Thu, 13 Feb 2020 14:13:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581631986; cv=none; d=google.com; s=arc-20160816; b=ziPqE1BTy6po0n2d63Zqq976JTLuO8XnxpULY7Y9Ld+g2cCE33BamTOBnsYN0Fvbor OOKCAre9blsH+ooMxemRBLW4UtdpI7YBZct1ZDEWmyZFBUBUesuNeYYSPQpl8/h8oFx4 fA8D//exsWWbacphlNn1TocQV9yX1QHtgGXcfU23YJGzsG770TEoAEYOy41iR/PVj7H1 k3wf3JeKfJxyOyG6cjWlGFDEI0RUqCJk6AZJnhMWyNUi1WdkYy6q5YjoKjIqHx8Cg3NM vUGpdukD+2ElDsHaqxCoXzHpIqdB+H2A3ZBbXE+BC1/dzPQXLA5slGtwKL/2ub4FBNK3 Hk6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=L8CYIylXszw5T12nzwhCt2wOP17igubFfMw076GDMa8=; b=usKuDjSzwdMnqX3XpA8bcHTNytjMhKbflPQPAAINwCgm6KfqnLkDHrZ6yjbGegnP6+ WjSncF7zZFEuwu6WA/lnrNRn3OOMPxj4T5xlhiC2gaOiQIQaPiPDPfn6QWV7CPW/Wv5G x8MjP2V+D5qNSGC3h7OBrPAiDuiSw8TUtICe7F6QK/SAKNgDRYtujuQEsmeOFVFw76bN xT2TFqpST4fvr/+O63C20o4hUKY136g0YAG3arU7C/fFHSug0O2POfJs6hqwIlOtYIy1 vlCqa3kJAsMftH+QpZ+6TE2mjdt6RWOZw6YI4Tr4WtjGIBeJU3mQ8TPhqikhg8FC4osO MOaA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=RAdpu5qF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j18si1687959oii.42.2020.02.13.14.12.53; Thu, 13 Feb 2020 14:13:06 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=RAdpu5qF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728074AbgBMWLV (ORCPT + 99 others); Thu, 13 Feb 2020 17:11:21 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:26035 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727772AbgBMWLV (ORCPT ); Thu, 13 Feb 2020 17:11:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581631880; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=L8CYIylXszw5T12nzwhCt2wOP17igubFfMw076GDMa8=; b=RAdpu5qFwLkwa57yNe4+SaAIid5CBmLJZZgJ3Dvc+KHjmePuynQXlvrBIBzWomyZAuSeSW fuAtrgmMndVqawuIoplIGGjsRabEPhTRPPP22WQTsWKP/9IEW7iFCsNc2v/xXU37y5Myk8 Rs8Eqs7FH7LTyn29SL/rIe0ziOxz+08= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-318-ClN-4b6NMPa4-IJWdfJHLw-1; Thu, 13 Feb 2020 17:11:04 -0500 X-MC-Unique: ClN-4b6NMPa4-IJWdfJHLw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9746D1005514; Thu, 13 Feb 2020 22:11:03 +0000 (UTC) Received: from treble (ovpn-121-12.rdu2.redhat.com [10.10.121.12]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AFB14272A1; Thu, 13 Feb 2020 22:11:02 +0000 (UTC) Date: Thu, 13 Feb 2020 16:11:00 -0600 From: Josh Poimboeuf To: tip-bot2 for Josh Poimboeuf Cc: linux-tip-commits@vger.kernel.org, Borislav Petkov , Julien Thierry , x86 , LKML Subject: Re: [tip: core/objtool] objtool: Fail the kernel build on fatal errors Message-ID: <20200213221100.odwg5gan3dwcpk6g@treble> References: <158142525822.411.5401976987070210798.tip-bot2@tip-bot2> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <158142525822.411.5401976987070210798.tip-bot2@tip-bot2> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 11, 2020 at 12:47:38PM -0000, tip-bot2 for Josh Poimboeuf wrote: > The following commit has been merged into the core/objtool branch of tip: > > Commit-ID: 644592d328370af4b3e027b7b1ae9f81613782d8 > Gitweb: https://git.kernel.org/tip/644592d328370af4b3e027b7b1ae9f81613782d8 > Author: Josh Poimboeuf > AuthorDate: Mon, 10 Feb 2020 12:32:38 -06:00 > Committer: Borislav Petkov > CommitterDate: Tue, 11 Feb 2020 13:27:03 +01:00 > > objtool: Fail the kernel build on fatal errors > > When objtool encounters a fatal error, it usually means the binary is > corrupt or otherwise broken in some way. Up until now, such errors were > just treated as warnings which didn't fail the kernel build. > > However, objtool is now stable enough that if a fatal error is > discovered, it most likely means something is seriously wrong and it > should fail the kernel build. > > Note that this doesn't apply to "normal" objtool warnings; only fatal > ones. Clang still has some toolchain issues which need to be sorted out, so upgrading the fatal errors is causing their CI to fail. So I think we need to drop this one for now. Boris, are you able to just drop it or should I send a revert? -- Josh