Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp1101595ybv; Thu, 13 Feb 2020 15:56:25 -0800 (PST) X-Google-Smtp-Source: APXvYqyvv4U/NhNshLmHJDtNuKPj2X6VKFWPnuDXn/QHkkqBtEDuH3xYTjjvZyRxu0pL90QEwang X-Received: by 2002:aca:b60a:: with SMTP id g10mr90695oif.102.1581638185425; Thu, 13 Feb 2020 15:56:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581638185; cv=none; d=google.com; s=arc-20160816; b=zhxGyqNIt/hnTuyuGruAapOIHu/08ZS7a3cEoXgyZwfdGP3bYsX3ln5W9v4i93T6RK 9bJs89hAKYR3BgGMhQmLYnpmvV9q78V917cxR7zB5mIlViZBSzluEIlgsaNT2joUdMPl aW/nJH9I5z4o7RuwfbptK0hA6bBIhqtZwVgzO7T25ia+SK7Bq5lPNSx7eb/2TBXcbKz1 RSdwqkM6+CkTz6TwZ6AcCrwiCF0M2lvCvbm6ZTK2DcY1uvoGyy+iINn/fLaj00/biUEa iovFEO3UBUiZLxEjJpCDoHchuzq2elGcWJVFoeKkCaQ77eYtAW2SopQ7uFmWRBLnDwhh G9Aw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=vkuo5wofbL4adtZoqpkWC5MPtgksW15+EN3xvzWlrUs=; b=bpdOmuz7qJlVYyKb0xjSsGDHWW0b2/tnyjgbh0Gh72jHSdq/B9e0HxdtSgdYAFJTml 4BBVjMoaYKvdFH+tsNcAEcryFKdWqW5sA2W1Iya9JZgT1eukB249kGztzBArBAx4rS// 74fooQS1NtMMUNznrDMd2R0t0WDilBSogyA3qAQLM4BM74HEOtZ0YiyccUoe5mMB0oOD BKIcg9NMj+8icVLVxOhjMEkTcPIk6fXdAjp/DeGdakjSvmNSrKnHQQ+XI4biNGMNiHGH HIGaWaEVcvJfZUe8y12dEuaetFwY8EyukRgFi37fK8O+J4iULuXlftnIk9qfKyEbYNS1 lCzA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p19si1957309otk.251.2020.02.13.15.56.13; Thu, 13 Feb 2020 15:56:25 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728017AbgBMX4C (ORCPT + 99 others); Thu, 13 Feb 2020 18:56:02 -0500 Received: from mail.kernel.org ([198.145.29.99]:52736 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727594AbgBMX4C (ORCPT ); Thu, 13 Feb 2020 18:56:02 -0500 Received: from oasis.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DAEF1217BA; Thu, 13 Feb 2020 23:56:00 +0000 (UTC) Date: Thu, 13 Feb 2020 18:55:59 -0500 From: Steven Rostedt To: Joel Fernandes Cc: "Paul E. McKenney" , Peter Zijlstra , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, mingo@kernel.org, gregkh@linuxfoundation.org, gustavo@embeddedor.com, tglx@linutronix.de, josh@joshtriplett.org, mathieu.desnoyers@efficios.com, jiangshanlai@gmail.com Subject: Re: [PATCH v2 3/9] rcu,tracing: Create trace_rcu_{enter,exit}() Message-ID: <20200213185559.65e9f520@oasis.local.home> In-Reply-To: <20200213225853.GB112239@google.com> References: <20200212210749.971717428@infradead.org> <20200212232005.GC115917@google.com> <20200213082716.GI14897@hirez.programming.kicks-ass.net> <20200213135138.GB2935@paulmck-ThinkPad-P72> <20200213164031.GH14914@hirez.programming.kicks-ass.net> <20200213185612.GG2935@paulmck-ThinkPad-P72> <20200213204444.GA94647@google.com> <20200213205442.GK2935@paulmck-ThinkPad-P72> <20200213211930.GG170680@google.com> <20200213214859.GL2935@paulmck-ThinkPad-P72> <20200213225853.GB112239@google.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 13 Feb 2020 17:58:53 -0500 Joel Fernandes wrote: > Oh ok, it was a fair question. Seems Steve nailed it, only the > rcu_nmi_enter() needs NOKPROBE, although as you mentioned in the other > thread, it would be good to get Masami's eyes on it since he introduced the > NOKPROBE. Note, I did go and verify that the issue still exists, and the NOKPROBE looks to still be needed. But as you stated, because Masami added the NOKPROBE I'd feel more comfortable with him looking over my explanation. -- Steve