Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 13 Feb 2020 20:07:24 -0800
From:   Matthew Wilcox <willy@infradead.org>
To:     Yang Shi <yang.shi@linux.alibaba.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>, mhocko@suse.com,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: migrate.c: migrate PG_readahead flag
Message-ID: <20200214040724.GV7778@bombadil.infradead.org>
References: <1581640185-95731-1-git-send-email-yang.shi@linux.alibaba.com>
 <20200213185511.4660aca17553562d764dc7ea@linux-foundation.org>
 <c5936806-dc0b-e0a2-33f0-6d6dce45e0a9@linux.alibaba.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <c5936806-dc0b-e0a2-33f0-6d6dce45e0a9@linux.alibaba.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Feb 13, 2020 at 07:58:40PM -0800, Yang Shi wrote:
> On 2/13/20 6:55 PM, Andrew Morton wrote:
> > On Fri, 14 Feb 2020 08:29:45 +0800 Yang Shi <yang.shi@linux.alibaba.com> wrote:
> > > Currently migration code doesn't migrate PG_readahead flag.
> > > Theoretically this would incur slight performance loss as the
> > > application might have to ramp its readahead back up again.  Even though
> > > such problem happens, it might be hidden by something else since
> > > migration is typically triggered by compaction and NUMA balancing, any
> > > of which should be more noticeable.
> > > 
> > > Migrate the flag after end_page_writeback() since it may clear
> > > PG_reclaim flag, which is the same bit as PG_readahead, for the new
> > > page.
> > > 
> > > --- a/mm/migrate.c
> > > +++ b/mm/migrate.c
> > > @@ -647,6 +647,14 @@ void migrate_page_states(struct page *newpage, struct page *page)
> > >   	if (PageWriteback(newpage))
> > >   		end_page_writeback(newpage);
> > > +	/*
> > > +	 * PG_readahead share the same bit with PG_reclaim, the above
> > > +	 * end_page_writeback() may clear PG_readahead mistakenly, so set
> > > +	 * the bit after that.
> > > +	 */
> > > +	if (PageReadahead(page))
> > > +		SetPageReadahead(newpage);
> > > +
> > >   	copy_page_owner(page, newpage);
> > Why not
> 
> The newpage may not have writeback set, migrating readahead flag should not
> depend on it.

Indeed, if the page has writeback set, then the page does not have the
readahead flag set; it has the reclaim flag set.  The original patch is
correct, afaict.

> >    	if (PageWriteback(newpage)) {
> >    		end_page_writeback(newpage);
> > 		/*
> > 		 * PG_readahead share the same bit with PG_reclaim, the above
> > 		 * end_page_writeback() may clear PG_readahead mistakenly, so
> > 		 * set the bit after that.
> > 		 */
> > 		if (PageReadahead(page))
> > 			SetPageReadahead(newpage);
> > 	}
> > 
> > ?
>