Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 13 Feb 2020 21:26:39 -0800
From:   Andrew Morton <akpm@linux-foundation.org>
To:     Qian Cai <cai@lca.pw>
Cc:     Yang Shi <yang.shi@linux.alibaba.com>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, "Li Xinhai" <lixinhai.lxh@gmail.com>
Subject: Re: [PATCH] mm: mempolicy: use VM_BUG_ON_VMA in
 queue_pages_test_walk()
Message-Id: <20200213212639.90c5eef95e4e3a4211dcf0a9@linux-foundation.org>
In-Reply-To: <89FF2013-1B59-4702-BF1B-A200C6785B37@lca.pw>
References: <d6c1a434-8670-97f4-345c-28c8007a25ce@linux.alibaba.com>
        <89FF2013-1B59-4702-BF1B-A200C6785B37@lca.pw>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 27 Jan 2020 15:23:08 -0500 Qian Cai <cai@lca.pw> wrote:

> 
> 
> > On Jan 27, 2020, at 2:57 PM, Yang Shi <yang.shi@linux.alibaba.com> wrote:
> > 
> > Dumping more information to help debugging. I don't run into related bug personally.
> 
> This is a relatively weak justification for merging. If we are keeping accepting those mindless debugging patches, the workload will be unbearable for all.

I think it's OK.  If this ever triggers the kernel is dead, so the
volume of output isn't a problem.  And if it triggers, the more info
the better.