Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 13 Feb 2020 21:32:07 -0800
From:   Andrew Morton <akpm@linux-foundation.org>
To:     Wei Yang <richardw.yang@linux.intel.com>
Cc:     David Rientjes <rientjes@google.com>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/vmscan.c: only adjust related kswapd cpu affinity
 when online cpu
Message-Id: <20200213213207.34b2aa0e0c2c92a09b700e96@linux-foundation.org>
In-Reply-To: <20200128003942.GC20624@richard>
References: <20200126132052.11921-1-richardw.yang@linux.intel.com>
        <alpine.DEB.2.21.2001261443020.164983@chino.kir.corp.google.com>
        <20200128003942.GC20624@richard>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 28 Jan 2020 08:39:42 +0800 Wei Yang <richardw.yang@linux.intel.com> wrote:

> >Is there ever a situation where the cpu to be onlined would have appeared 
> >in the cpumask of another node and so a different kswapd's cpumask would 
> >now include an off-node cpu?
> 
> No, I don't think so.
> 
> Per my understanding, kswapd_cpu_online() will be invoked when a cpu is
> onlined. And the particular cpu belongs to a particular numa node. So it is
> not necessary to iterate on every nodes.
> 
> And current code use cpumask_and_any() to do the check. If my understanding is
> correct, the check would return true if this node has any online cpu. This is
> likely to be true.
> 
> This is why I want to make the logic clear.

Please resend with a changelog which explains the above?