Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp1692108ybv; Fri, 14 Feb 2020 04:25:02 -0800 (PST) X-Google-Smtp-Source: APXvYqyJrqAbJZqAcikjg5ePL1zER5d/lZUwK5HTjXUbtwL+NeffL251BHeVOjPkaVFFR7acyq7H X-Received: by 2002:a9d:6283:: with SMTP id x3mr1948209otk.367.1581683102562; Fri, 14 Feb 2020 04:25:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581683102; cv=none; d=google.com; s=arc-20160816; b=mLSnqKKeSG5/TtIc4wgu5wAL6BdbsEpn/7+zMUjo9WkXecFYEIGG3ifltO0cMtzpE7 2ACJq+lHNAJM78BcFm7YunMBgQdR9b+lwYIMkQMt0Ha10p0b5paSILhSaXE+U+C0I9w4 Dq+wl6A3Zk7Rjcp6Tt+2pMipejT3LQP7EL4R/QUClqoGDRkhpum2TpESyrncXV2GvXYx do0XN2R5Odui4EcDndHkzzYIBuk59hqceSzibHBN8WW2ZsezgbHNtOhrPM8zC74+qh8q ZxyO8qFxSRtCSJuAXzENszu+25iWk2DsZUcP/tSIFfHS6y7QpspYWw0nZsKLcHYaWxtg b95Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:in-reply-to:cc:references:message-id :date:subject:mime-version:from:content-transfer-encoding :dkim-signature; bh=GBec5/xP6kdWt5EvLc0p6Ucizf6LIlmy8SX4hwOdeo0=; b=IL3VTmMu46zfqkrW7pzhrXDimNs2R9lHUKUPO+mk7p9Zv9StNmOqUO+Bv6QWvlw+gh 4uIQg48Thn0CweVxi/NWhN+Jpf/Uhsc3rhtWEubE2s+WnSVKkeXrbZhdp/b2Se4MZMYS Yzbo47oX6QA5K0IfZcZPZ1T4jgyboi+Rm20VMotxj22zB5fuBnnTjLEmyaMUWAQL/5jC j+M4vOx7Py+871AQ3+qGCwNLUwLQegKPv9VGKaAj7IbP8BdBaMumdP1aolbk18BvAEe2 /cTxqCuIHRCceIEfTmjJ+5H1KNSDX9/Fiyt4n5kJ0J/Vc/H6AUGZxnaIKYctd6Dv5gSS zMoQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lca.pw header.s=google header.b=Zk6U8qVj; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t3si2700250oig.25.2020.02.14.04.24.50; Fri, 14 Feb 2020 04:25:02 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@lca.pw header.s=google header.b=Zk6U8qVj; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728850AbgBNMYU (ORCPT + 99 others); Fri, 14 Feb 2020 07:24:20 -0500 Received: from mail-qv1-f65.google.com ([209.85.219.65]:41215 "EHLO mail-qv1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728083AbgBNMYT (ORCPT ); Fri, 14 Feb 2020 07:24:19 -0500 Received: by mail-qv1-f65.google.com with SMTP id s7so4165062qvn.8 for ; Fri, 14 Feb 2020 04:24:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=content-transfer-encoding:from:mime-version:subject:date:message-id :references:cc:in-reply-to:to; bh=GBec5/xP6kdWt5EvLc0p6Ucizf6LIlmy8SX4hwOdeo0=; b=Zk6U8qVjpqjndZi63Smi4boGwIJzsRK+eiazK5hQBXuugaUTw5Dzc8vq/QN2FyBLhg 7QRB0gAoD0NEOS6pIgpQ1lG1utRdUeX+yJGdKF1uu6AGChvP8B380XZ8SH6DTnfIq+Iv SUyX+Cwip4UL4YkuWHHNdQ0gc0RwzFBWDz/26pQfywczPMxX86mowu4Y/BG1LiOHg4ow hjyrHl/a7eXnKLiYt1VyZAgnBAF87tQNdeZjAyWp6N15jKLuuz0nfV4uGiWFeF981iRy UwvhWoZDMZtzgAjIuaZjPijDxSUEV6JtNaVN/TaSHEOmjaMmyvFXHzqqPNMGmxUBWy/B k66g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:content-transfer-encoding:from:mime-version :subject:date:message-id:references:cc:in-reply-to:to; bh=GBec5/xP6kdWt5EvLc0p6Ucizf6LIlmy8SX4hwOdeo0=; b=sXDj8mJkq4Nk5QLILoUDkeAWjKKEhsxqGQ/i9QkFf9gpZPbkC9J6SZmQ/jYhbo3mGa BByGcFjSVlSqKw2HoAVXy/e/H1C7EJMDbhp64dGwrc0J86P8Kjy3KUjOEcpXOn2F05pn 5ZiNGeFupbabBRq3OKKEt4XbLSMZelxshTMD2WVZ3rT7V8MAMhuGg3edOlXoauqbEPAo 3H2g3wDr+0P9+/RcvX4VCKpVEaYNbTeOzk+U2O2KAwoXHkzfj9xBCilivavLjtSmNIqE IS2SgDhXRp6pHtZqK+FanToL8eVSonDhGCudmaTHzF5UXln3bDogJ7d1055S3zimgYZ0 25DQ== X-Gm-Message-State: APjAAAXMnNVDnXwIxSQqBRVFxi80gqYUwiYCMzJtWSbQBGY/+4xvhfci rlkoUKnGJmP4c3sbTq/sT9Qmgg== X-Received: by 2002:a05:6214:1090:: with SMTP id o16mr1874639qvr.105.1581683057171; Fri, 14 Feb 2020 04:24:17 -0800 (PST) Received: from [192.168.1.183] (pool-71-184-117-43.bstnma.fios.verizon.net. [71.184.117.43]) by smtp.gmail.com with ESMTPSA id y21sm3086872qto.15.2020.02.14.04.24.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Feb 2020 04:24:16 -0800 (PST) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: Qian Cai Mime-Version: 1.0 (1.0) Subject: Re: [PATCH] mm: mempolicy: use VM_BUG_ON_VMA in queue_pages_test_walk() Date: Fri, 14 Feb 2020 07:24:15 -0500 Message-Id: <5AF60E86-F9CB-47AD-9E2C-87EE025911DF@lca.pw> References: <20200213212639.90c5eef95e4e3a4211dcf0a9@linux-foundation.org> Cc: Yang Shi , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Li Xinhai In-Reply-To: <20200213212639.90c5eef95e4e3a4211dcf0a9@linux-foundation.org> To: Andrew Morton X-Mailer: iPhone Mail (17D50) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Feb 14, 2020, at 12:26 AM, Andrew Morton wr= ote: >=20 > I think it's OK. If this ever triggers the kernel is dead, so the > volume of output isn't a problem. And if it triggers, the more info > the better. Well, I could think of millions of ways to just add more info for those theo= retical assertion places where we will eventually be running out of review b= andwidth if people start to =E2=80=9Cabuse=E2=80=9D it. Anyway, if maintaine= rs are willing to take risks on that path, I=E2=80=99ll not complain.=