Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 14 Feb 2020 09:57:54 -0300
From:   Arnaldo Carvalho de Melo <acme@redhat.com>
To:     zhe.he@windriver.com
Cc:     rostedt@goodmis.org, tstoyanov@vmware.com, hewenliang4@huawei.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tools lib traceevent: Take care of return value of
 asprintf
Message-ID: <20200214125754.GA2974@redhat.com>
References: <1581665486-20386-1-git-send-email-zhe.he@windriver.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <1581665486-20386-1-git-send-email-zhe.he@windriver.com>
User-Agent: Mutt/1.5.20 (2009-12-10)
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Em Fri, Feb 14, 2020 at 03:31:26PM +0800, zhe.he@windriver.com escreveu:
> From: He Zhe <zhe.he@windriver.com>
>=20
> According to the API, if memory allocation wasn't possible, or some oth=
er
> error occurs, asprintf will return -1, and the contents of strp below a=
re
> undefined.
>=20
> int asprintf(char **strp, const char *fmt, ...);
>=20
> This patch takes care of return value of asprintf to make it less error
> prone and prevent the following build warning.
>=20
> ignoring return value of =E2=80=98asprintf=E2=80=99, declared with attr=
ibute warn_unused_result [-Wunused-result]

Sure this fixes problems, but can you make it more compact, i.e. no need
to add most if not all those 'int ret;' lines, just check the asprintf
result directly, i.e.:

                             if (asprintf(&str, val ? "TRUE" : "FALSE") <=
 0)
                                     str =3D NULL;

saving the return value for that function is interesting when you need
to know how many bytes it printed to do some extra calculation, but if
all you need is to know if it failed, checking against < 0 is enough,
no?

- Arnaldo

=20
> Signed-off-by: He Zhe <zhe.he@windriver.com>
> ---
>  tools/lib/traceevent/parse-filter.c | 42 +++++++++++++++++++++++++++++=
--------
>  1 file changed, 33 insertions(+), 9 deletions(-)
>=20
> diff --git a/tools/lib/traceevent/parse-filter.c b/tools/lib/traceevent=
/parse-filter.c
> index 20eed71..279b572 100644
> --- a/tools/lib/traceevent/parse-filter.c
> +++ b/tools/lib/traceevent/parse-filter.c
> @@ -1912,6 +1912,7 @@ static char *op_to_str(struct tep_event_filter *f=
ilter, struct tep_filter_arg *a
>  	int left_val =3D -1;
>  	int right_val =3D -1;
>  	int val;
> +	int ret;
> =20
>  	switch (arg->op.type) {
>  	case TEP_FILTER_OP_AND:
> @@ -1958,7 +1959,9 @@ static char *op_to_str(struct tep_event_filter *f=
ilter, struct tep_filter_arg *a
>  				default:
>  					break;
>  				}
> -				asprintf(&str, val ? "TRUE" : "FALSE");
> +				ret =3D asprintf(&str, val ? "TRUE" : "FALSE");
> +				if (ret < 0)
> +					str =3D NULL;
>  				break;
>  			}
>  		}
> @@ -1976,7 +1979,9 @@ static char *op_to_str(struct tep_event_filter *f=
ilter, struct tep_filter_arg *a
>  			break;
>  		}
> =20
> -		asprintf(&str, "(%s) %s (%s)", left, op, right);
> +		ret =3D asprintf(&str, "(%s) %s (%s)", left, op, right);
> +		if (ret < 0)
> +			str =3D NULL;
>  		break;
> =20
>  	case TEP_FILTER_OP_NOT:
> @@ -1992,10 +1997,14 @@ static char *op_to_str(struct tep_event_filter =
*filter, struct tep_filter_arg *a
>  			right_val =3D 0;
>  		if (right_val >=3D 0) {
>  			/* just return the opposite */
> -			asprintf(&str, right_val ? "FALSE" : "TRUE");
> +			ret =3D asprintf(&str, right_val ? "FALSE" : "TRUE");
> +			if (ret < 0)
> +				str =3D NULL;
>  			break;
>  		}
> -		asprintf(&str, "%s(%s)", op, right);
> +		ret =3D asprintf(&str, "%s(%s)", op, right);
> +		if (ret < 0)
> +			str =3D NULL;
>  		break;
> =20
>  	default:
> @@ -2010,8 +2019,11 @@ static char *op_to_str(struct tep_event_filter *=
filter, struct tep_filter_arg *a
>  static char *val_to_str(struct tep_event_filter *filter, struct tep_fi=
lter_arg *arg)
>  {
>  	char *str =3D NULL;
> +	int ret;
> =20
> -	asprintf(&str, "%lld", arg->value.val);
> +	ret =3D asprintf(&str, "%lld", arg->value.val);
> +	if (ret < 0)
> +		str =3D NULL;
> =20
>  	return str;
>  }
> @@ -2027,6 +2039,7 @@ static char *exp_to_str(struct tep_event_filter *=
filter, struct tep_filter_arg *
>  	char *rstr;
>  	char *op;
>  	char *str =3D NULL;
> +	int ret;
> =20
>  	lstr =3D arg_to_str(filter, arg->exp.left);
>  	rstr =3D arg_to_str(filter, arg->exp.right);
> @@ -2069,7 +2082,9 @@ static char *exp_to_str(struct tep_event_filter *=
filter, struct tep_filter_arg *
>  		break;
>  	}
> =20
> -	asprintf(&str, "%s %s %s", lstr, op, rstr);
> +	ret =3D asprintf(&str, "%s %s %s", lstr, op, rstr);
> +	if (ret < 0)
> +		str =3D NULL;
>  out:
>  	free(lstr);
>  	free(rstr);
> @@ -2083,6 +2098,7 @@ static char *num_to_str(struct tep_event_filter *=
filter, struct tep_filter_arg *
>  	char *rstr;
>  	char *str =3D NULL;
>  	char *op =3D NULL;
> +	int ret;
> =20
>  	lstr =3D arg_to_str(filter, arg->num.left);
>  	rstr =3D arg_to_str(filter, arg->num.right);
> @@ -2113,7 +2129,9 @@ static char *num_to_str(struct tep_event_filter *=
filter, struct tep_filter_arg *
>  		if (!op)
>  			op =3D "<=3D";
> =20
> -		asprintf(&str, "%s %s %s", lstr, op, rstr);
> +		ret =3D asprintf(&str, "%s %s %s", lstr, op, rstr);
> +		if (ret < 0)
> +			str =3D NULL;
>  		break;
> =20
>  	default:
> @@ -2131,6 +2149,7 @@ static char *str_to_str(struct tep_event_filter *=
filter, struct tep_filter_arg *
>  {
>  	char *str =3D NULL;
>  	char *op =3D NULL;
> +	int ret;
> =20
>  	switch (arg->str.type) {
>  	case TEP_FILTER_CMP_MATCH:
> @@ -2148,8 +2167,10 @@ static char *str_to_str(struct tep_event_filter =
*filter, struct tep_filter_arg *
>  		if (!op)
>  			op =3D "!~";
> =20
> -		asprintf(&str, "%s %s \"%s\"",
> +		ret =3D asprintf(&str, "%s %s \"%s\"",
>  			 arg->str.field->name, op, arg->str.val);
> +		if (ret < 0)
> +			str =3D NULL;
>  		break;
> =20
>  	default:
> @@ -2162,10 +2183,13 @@ static char *str_to_str(struct tep_event_filter=
 *filter, struct tep_filter_arg *
>  static char *arg_to_str(struct tep_event_filter *filter, struct tep_fi=
lter_arg *arg)
>  {
>  	char *str =3D NULL;
> +	int ret;
> =20
>  	switch (arg->type) {
>  	case TEP_FILTER_ARG_BOOLEAN:
> -		asprintf(&str, arg->boolean.value ? "TRUE" : "FALSE");
> +		ret =3D asprintf(&str, arg->boolean.value ? "TRUE" : "FALSE");
> +		if (ret < 0)
> +			str =3D NULL;
>  		return str;
> =20
>  	case TEP_FILTER_ARG_OP:
> --=20
> 2.7.4