Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 14 Feb 2020 14:17:41 +0100
From:   Maxime Ripard <maxime@cerno.tech>
To:     Alexandre GRIVEAUX <agriveaux@deutnet.info>
Cc:     robh+dt@kernel.org, mark.rutland@arm.com, wens@csie.org,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: sun5i: Add dts for inet86v_rev2
Message-ID: <20200214131741.u46urhpwzzjpflfb@gilmour.lan>
References: <20200210103552.3210406-1-agriveaux@deutnet.info>
 <20200211131517.e7lpjtz2njekadee@gilmour.lan>
 <864838c2-1b1d-433a-ca04-0d91c8b5b8ca@deutnet.info>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="ar2jus4mu24srbt4"
Content-Disposition: inline
In-Reply-To: <864838c2-1b1d-433a-ca04-0d91c8b5b8ca@deutnet.info>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--ar2jus4mu24srbt4
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Wed, Feb 12, 2020 at 10:45:03AM +0100, Alexandre GRIVEAUX wrote:
> Le 11/02/2020 =E0 14:15, Maxime Ripard a =E9crit=A0:
> > On Mon, Feb 10, 2020 at 11:35:52AM +0100, agriveaux@deutnet.info wrote:
> >> From: Alexandre GRIVEAUX <agriveaux@deutnet.info>
> >>
> >> Add Inet 86V Rev 2 support, based upon Inet 86VS.
> >>
> >> Missing things:
> >> - Accelerometer (MXC6225X)
> >> - Touchpanel (Sitronix SL1536)
> >> - Nand (29F32G08CBACA)
> >> - Camera (HCWY0308)
> >>
> >> Signed-off-by: Alexandre GRIVEAUX <agriveaux@deutnet.info>
> > Please read the documentation I sent you yesterday. In particular,
> > when submitting multiple versions, you should remove have the version
> > number in the title and a changelog.
> >
> > Also, please ask questions if you're unsure about something, or
> > discuss something you do not agree with instead of ignoring the
> > comment.
> >
> > Maxime
>
>
> Seem I misusing 'git send-email' because i already changed the subject
> line (same apply to u-boot):
>
> git send-email --from agriveaux@deutnet.info --to
> robh+dt@kernel.org,mark.rutland@arm.com,mripard@kernel.org,wens@csie.org
> --cc
> linux-kernel@vger.kernel.org,devicetree@vger.kernel.org,agriveaux@deutnet=
=2Einfo
> --subject '[v2] ARM: dts: sun5i: Add dts for inet86v_rev2' --compose
> /tmp/linux/0001-ARM-dts-sun5i-Add-dts-for-inet86v_rev2.patch
>
> It's the first time i use git send-email, previously i used mutt to send
> patchsets (on mips mostly).
>
>
> Effectively i've forgot the changelog...

A simpler way, especially for a single patch, would be to use

git send-email -v2 --to $recipients --annotate $COMMIT^..$COMMIT

You can even keep the change log in the commit log itself by using ---
as a separator, so something like:

ARM: dts: my super title

Some nice awesome change

---

Changes from v1:
  - Whatever.

> At why do we need another device tree:
>
> inet86vs use a GSL1680 touchpanel controller and 4GB nand [0]
>
> inet86vsuse a Sitonix SL1536 touchpanel controller and 8GB nand (can
> have 16GB nand)[1]

NAND size will be discovered so it's not really a concern. For the
touchscreen, you should make that clear in your commit log.

Maxime

--ar2jus4mu24srbt4
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXkad9QAKCRDj7w1vZxhR
xZpWAP9pFTRWCaqwBVNYBKiE2xBXLEgGjm4qKL3sDt2A4qc+jQEA7egdAvStILOP
lE8wqwqZROoKZ3bdJi2AwXA9ZxiyjwU=
=ZA/T
-----END PGP SIGNATURE-----

--ar2jus4mu24srbt4--