Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp1773397ybv; Fri, 14 Feb 2020 05:50:27 -0800 (PST) X-Google-Smtp-Source: APXvYqyQkYKxCAiDeXh+YcDZhx8PntQd4alUVMyvUurdtOTjEdN0LcUBCQZT3ZHvJgQD1dQYSPbS X-Received: by 2002:a9d:6c8d:: with SMTP id c13mr2333861otr.277.1581688226997; Fri, 14 Feb 2020 05:50:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581688226; cv=none; d=google.com; s=arc-20160816; b=lzrQAXpYXRbl05ekfRlokuZIEiJyAOVKQVMxw1z/u++6qE9IEZ2RiZ7g1Jpy5qnOJh nfyo1cVAbsXl4T3G4pAws8Jk59ZGHot6givNQurTyaZP61ajKFupj6Ts1CFb3Rhcz8YN EDeZhFapynQiOHCPaxOTW7lmP9wrnYth00pXqbwClVY0zAOyPg5MOh9AQ0Cpdc4vb4eK ePtwkzg3Ghktt8lEa/bYKsvkBQ4a+qQb8GEqFvuxeuVavpeMwnKwt3FG8vUHsYai+BL4 vOFKbwmKWoipwHTJzSsbecKftqQ+rZ9EaNi4JOyVi1UARwbKOOw82F/K27ff+NIM499z RaLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=uqyI02njoot2XmCZIdNUmhXwHE9v/zz94Gp6DG53kCk=; b=RWroROooNgJ+vnpOwKfz0IC+4Ze2EfpZgiTE7vR5GEYeXCdGyknxqxhofmCj3EjlWl jPPZidfbJ91iWI6zsEA46tXxmofu3CFTFKQqXKPbZXD5a3wKIrcxWZZ7Vwwy1JMy7C1E QszagGJZ8DHf9RgUNd7l+ZPFuTB96+4xGrD0vCSWrpduLlIiNuX51yInQSxiBZU5cqo8 sALfzNje5Zc+6aBEfqLm1E7Xwx04sdxu4l9Um4jG6qHS62yiOhrUHat2ivCS750vs7bP CpI5U7r6+jQvGeRISzQfEqByheQZTMiKs5kXJl3mljAp4LGvrKa71Cy7ho2q2bbCrSb0 0DhQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ttyMlQud; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c10si3803119ots.106.2020.02.14.05.50.14; Fri, 14 Feb 2020 05:50:26 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ttyMlQud; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729273AbgBNNuB (ORCPT + 99 others); Fri, 14 Feb 2020 08:50:01 -0500 Received: from mail-vs1-f68.google.com ([209.85.217.68]:44960 "EHLO mail-vs1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728405AbgBNNuB (ORCPT ); Fri, 14 Feb 2020 08:50:01 -0500 Received: by mail-vs1-f68.google.com with SMTP id p6so5913353vsj.11; Fri, 14 Feb 2020 05:50:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uqyI02njoot2XmCZIdNUmhXwHE9v/zz94Gp6DG53kCk=; b=ttyMlQudUD/NIBwpvMZWuApIZRSf94LFlCQcay2XSvF2z8dXuaO5svAqb7WazigmfP eZTC6ziq4bwq//prNhF+xxbc9pQ6cHgUifdA8udDHgIWVZ8rqePb7c3AM3WG8S0QvcKQ dN1ygtCuxKRefH8ocoasDfWJTZfENfGPcqGvBOY+yo0W7OwUOqNEnPq+q9YKQ+onvd+q 2yGMYHdJAdUIOydiE2fBf4Qd5OXQTEej3aceCsOpiy/ezZEpUjYdXcS7In2MhGkZ7QJj 8xPjjfPTo2CKhaq6avDY0SH58louqdjtPdLzAl1xUdXhTXAPO1XHXQOoJ9vsTYKyyNo5 NCuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uqyI02njoot2XmCZIdNUmhXwHE9v/zz94Gp6DG53kCk=; b=gOMN66P5tQfKNDCpLjX37KHw7BifLEwNyZjq2qImRS/+fguERvJvCczvHzrMplHrow I0Xm4hf4md+dScofE628al0vCPKxbQi4w2utSJcVE4zmyn5X0LmWxaxTHUTxSIQvGWA3 ltsr6juZXHkDQ1PZLOL1sxpp6JhEYQK7Ov9NZPoa7GD9NT+XWMFtGbvWK3jsLJfPQYJO H3eT4NuLBVQflg8FlmeXqqGv/HairVnQzFNUXGakYL7X7YWTHugNMnj5ENpFHCgCL5ef MgzVCMaIQ+IvnZj4rSEvQLajk08FoHogsFg7PHnVS424qLZ+I7OfrGz82cTC42EwZCwm Wsig== X-Gm-Message-State: APjAAAVdB3vy+teut919kbGj5bSKsO9O0m3YdDDLRxU3o7i2EXKygNRP TDf3KXM6fa+2eHJhOiHy9Ci1exF7LVbVsxlDsuQ= X-Received: by 2002:a67:ce93:: with SMTP id c19mr1413233vse.64.1581688199935; Fri, 14 Feb 2020 05:49:59 -0800 (PST) MIME-Version: 1.0 References: <20200214114618.29704-1-vadivel.muruganx.ramuthevar@linux.intel.com> <20200214121145.GF4827@sirena.org.uk> <20200214131518.GJ4827@sirena.org.uk> In-Reply-To: <20200214131518.GJ4827@sirena.org.uk> From: Simon Goldschmidt Date: Fri, 14 Feb 2020 14:49:48 +0100 Message-ID: Subject: Re: [PATCH v9 0/2] spi: cadence-quadpsi: Add support for the Cadence QSPI controller To: Mark Brown Cc: "Ramuthevar,Vadivel MuruganX" , linux-kernel , linux-spi@vger.kernel.org, Vignesh R , Mark Rutland , Rob Herring , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , dan.carpenter@oracle.com, cheol.yong.kim@intel.com, qi-ming.wu@intel.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 14, 2020 at 2:15 PM Mark Brown wrote: > > On Fri, Feb 14, 2020 at 01:50:44PM +0100, Simon Goldschmidt wrote: > > > So please correct me if I'm wrong, but to me it seems like if this driver won't > > work on altera, and after merging it the currently working driver will be > > removed, altera will be broken. > > I'm not seeing anything in the driver that removes whatever the current > support is? Unless it's just adding a duplicate driver for the same > compatible strings which is obviously a bad idea but at least means that > unless people enable the driver there's no risk of it colliding with the > existing one. It does add a duplicate driver for the same compatible strings. The current working driver is in 'drivers/mtd/spi-nor/cadence-quadspi.c'. In fact, the compatible string "cdns,qspi-nor" copied from the old driver to this new driver is *only* used for altera. TI has its own compatible string, the new Intel platform adds its own as well. As long as that one doesn't get removed, I have nothing against this driver here. I'm only concerned that this will get forgotten. And given that I added altera guys to the loop in one of the previous versions, I just was surprised they aren't on CC in this version. I'm not familiar with whom to CC for Linux drivers, so sorry for the noise if I'm overreacting here, just tell me. Regards, Simon