Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp1788474ybv; Fri, 14 Feb 2020 06:06:25 -0800 (PST) X-Google-Smtp-Source: APXvYqxpO4nko5c4P16OhhcKgVEokehRMdMaPPYMA/9nGHE2W9TWmx9T2pgDh1jEmK6U5IMWMkc5 X-Received: by 2002:a9d:5885:: with SMTP id x5mr2353643otg.132.1581689185633; Fri, 14 Feb 2020 06:06:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581689185; cv=none; d=google.com; s=arc-20160816; b=M00cvfsN12qVyBv49lgMdbRfWiCUyHwDOu3FUirpnxUtjwfH8Uf9MXjXzNunt51+BQ 3mYN/X6oDae11ylzBefh18LoIJYlDHGVIeRGAlhcaaaYDRH4ntqrG/ZmUQTCj85dnTpC /byEMavLa7yOMQBwmNumJHGDzKNdofdkFPBwik1rHNfmQI6nm9Z6lSwCmrbvVjPt0mQ2 9xLlbM3XoqQF7qdLdCzLrxoBWAdcJFweltKVgEpT5swlyh6jrdNM3RO3zYnEzi8pnwVS OthHWM3XTkbd9mNl2qhls3CCbAnxnEYOxQ6kONtTydyLqIZS//IrmPfTFegZu+5Bc/pi 866Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:dkim-signature:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=FOw4bWZEh/AbWKd98TO0Ip7GRAKPee6mZCFYh4kd40w=; b=dJUFYw/8rsoAdi5ObWdZIsnsMxiobrrTG8iQYIzwPHEFeaw130b7GKekKS9I/zbPVy Q5S2i0/R6a8b9vsgv2+a2EwQSOlNZAH8/3G33eH2eicBb9DXUnCRkeWh1tHx3IbmHsW7 HwvpjmNuIxIb/RfaxUBDso9U/RX2f+B01IJO3dIw1Ti/BzpCbCl/ZmvuucwvvfzZCc44 Ktz11z0IVQldku9ZApzukqMdTWvCPWaSMWuL4AUaKf5ZxuOrtgmrP0DW1BA02QMK/yWX 1ZCHlQt5rsgyLTLM7z3qbW6e3oVK1vA6EZrB8OV3HtZ9Qs/1ls8gPyy2SlyvmohFQDYq F8mA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=QI6Ew9ps; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n1si2792079oic.225.2020.02.14.06.05.50; Fri, 14 Feb 2020 06:06:25 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=QI6Ew9ps; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729335AbgBNOFI (ORCPT + 99 others); Fri, 14 Feb 2020 09:05:08 -0500 Received: from hqnvemgate26.nvidia.com ([216.228.121.65]:19624 "EHLO hqnvemgate26.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729294AbgBNOFI (ORCPT ); Fri, 14 Feb 2020 09:05:08 -0500 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Fri, 14 Feb 2020 06:04:53 -0800 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Fri, 14 Feb 2020 06:05:07 -0800 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Fri, 14 Feb 2020 06:05:07 -0800 Received: from [10.21.133.51] (172.20.13.39) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 14 Feb 2020 14:05:04 +0000 Subject: Re: [alsa-devel] [PATCH 4/9] ASoC: tegra: add Tegra210 based I2S driver To: Dmitry Osipenko , Sameer Pujar CC: , , , , , , , , , , , , , , References: <1579530198-13431-1-git-send-email-spujar@nvidia.com> <1579530198-13431-5-git-send-email-spujar@nvidia.com> <0c571858-d72c-97c2-2d6a-ead6fdde06eb@nvidia.com> <444731da-c4cd-8578-a732-c803eef31ef0@gmail.com> <598fe377-5b95-d30a-eb64-89a645166d42@gmail.com> <3f51939d-cf4b-f69b-728a-7eb99bbae458@nvidia.com> <34ac1fd3-ae0f-07f2-555f-a55087a2c9dc@nvidia.com> <1a84b393-938f-8bed-d08e-cc3bb6ed4844@gmail.com> <0fc814c2-0dc6-7741-b954-463381ff7fb9@nvidia.com> <9f73afdf-1e9a-cdbd-f972-a022d503ef51@nvidia.com> <264d3354-8a2e-ee12-44ae-aff69213d551@nvidia.com> <075e476a-36bb-5fee-15bc-76af4474a797@gmail.com> <3b42c858-733b-0d17-f457-8043d97f5058@gmail.com> From: Jon Hunter Message-ID: <62b8ffbc-aa32-ae44-6cb4-b176b8ba9b0e@nvidia.com> Date: Fri, 14 Feb 2020 14:05:02 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <3b42c858-733b-0d17-f457-8043d97f5058@gmail.com> X-Originating-IP: [172.20.13.39] X-ClientProxiedBy: HQMAIL107.nvidia.com (172.20.187.13) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1581689093; bh=FOw4bWZEh/AbWKd98TO0Ip7GRAKPee6mZCFYh4kd40w=; h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=QI6Ew9ps6koVrDmIS4lwL+Pl6aXPVaJAaivfgwoF8faY4OsNX+S91a24nV6/HZcH0 x4z16S42vrq91k5KA4wW6nxUmq1PH9BQso2+95cd3aVczvqbIHKD3RiZ6YjI6L0xez tS2AvbiMQSRsUHdLtb9rKZjfE/aiRO6q0MXMwHw5u09kdx76ScVdRz8sG3lS6NS7yX j1oMBmq1rDwScwRul3uDTm2Dhl9Z+uiPksmBfnrsb5GKcyJOzPD1fH2HgP/4mxkNQk sl66OawXc9aDMOAWMkGseZWc03IyOsKWBrt/Rr0BPoZjVIV3L24MmqxqU+7wlBeVNc X4TdHMw1quYBA== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29/01/2020 03:41, Dmitry Osipenko wrote: ... > The !RPM case isn't supported by Tegra anymore in upstream kernel. I'm > trying to help to make yours driver better and gave you reasons to > remove the unneeded code, while you're keep saying that "there is no > harm to retain it", which is not a reason to clutter up the code. I > don't feel that it's worthwhile to continue arguing here. On further review, it does look like a reasonable argument to get rid of this now completely. Like you see less clutter and the soc-core should ensure that the card is shutdown before unloading. OK, so fine with me. Jon -- nvpublic