Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp1841925ybv; Fri, 14 Feb 2020 06:59:49 -0800 (PST) X-Google-Smtp-Source: APXvYqznT4R7rSBtA6c1ey7x+VjYYrAKZKcD54N5UJzggrkokDxFuFL5mD4SB/Q1L2LtzmnhqHW+ X-Received: by 2002:a9d:6418:: with SMTP id h24mr2614444otl.172.1581692389716; Fri, 14 Feb 2020 06:59:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581692389; cv=none; d=google.com; s=arc-20160816; b=GKkDf0FSpdeN3oH1S1dPcXz6wrjuNOGsXHqp4pX+PT3gL+6mRjfnD4W5Fd/OvXSOf0 uQxEcLlWSIBCYI6OBMubmWt4XtrBLww1D9mXyZJBnjHw+gZMP6PH3nXq5k9nkPemjPpo DSdCTkwKvif+DUbZ7sn7u/3s5A9FkRW6K8f2RxUDbMkHCt6MeKy1SvwENS0NFzgCXSpy +t5xPUGHS30HV3agzpPC4bbGZWRYDdaohecx0v5GuZKIuZW1iv8LjS54i6mgZBztrlAA jqqCc451A5dMzydOvAmuY+PoDX94r0B+fbTWOu5KZflshO3hqfbR2JcyaKPkkKvp9FSF yFYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=u7fA1CllHbvc+k7yPy7P2HtFYB9o3VeiX1x/C0OkSGs=; b=ZWtCokF5zbyvpLUHfyiacx7siaLxixMVXtfeWDKFgmtHsswD1HBNFVIooIvpN7ArGD 8MNgRQ+4WLGuTpbyFt6owzihO0DoCAV83R+mC+kNtLb0Y54JO7vxvKWRpltsyldU4lvD W/H/AVR/ZCgq+0KXXkJaeVFimfpaskCr5OvUAtUuY+fg5Of/LArSBF09JtSMCW/2FzhM CSGWiuoaQDRSjKEW8m3yDnJ+6oibff/1u4KUyz6MqK3gO9SKQIghUqzUS/e3fID8YvrK GKzme7Lab2A0kR8kk3DiVAqMl9DEqNDNVEnjVzBiF+xfyQ2cp2jo0BU8CpJz1kKdsLeM +F+w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=rrFRAEx5; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r12si3026798otq.156.2020.02.14.06.59.38; Fri, 14 Feb 2020 06:59:49 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=rrFRAEx5; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729451AbgBNO5s (ORCPT + 99 others); Fri, 14 Feb 2020 09:57:48 -0500 Received: from mail.kernel.org ([198.145.29.99]:50952 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729241AbgBNO5s (ORCPT ); Fri, 14 Feb 2020 09:57:48 -0500 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D481624654; Fri, 14 Feb 2020 14:57:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581692267; bh=2K+sV3mhy23v6Bq9vMnU/WU2vw9ePyOV5iKw3thp48A=; h=From:To:Cc:Subject:Date:From; b=rrFRAEx5RHOLyG1IgXafbX5FY6M1AdYoSrNOgU8IwpdqmGbiscDh7atSMJsDh8WzL JZEopblx7bJMnlcoH30Rfvi2E98soWbCyeFlNn+9iP2VJpmbWtrnq2gELYUpP68JpL 9gLR0sHW3tSThQ+gtPaV+IqGvCdjy+I2aH/8/Cj0= Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=why.lan) by disco-boy.misterjones.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j2cPZ-0057sw-7b; Fri, 14 Feb 2020 14:57:45 +0000 From: Marc Zyngier To: linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Lorenzo Pieralisi , Jason Cooper , Robert Richter , Thomas Gleixner , Zenghui Yu , Eric Auger , James Morse , Julien Thierry , Suzuki K Poulose Subject: [PATCH v4 00/20] irqchip/gic-v4: GICv4.1 architecture support Date: Fri, 14 Feb 2020 14:57:16 +0000 Message-Id: <20200214145736.18550-1-maz@kernel.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, lorenzo.pieralisi@arm.com, jason@lakedaemon.net, rrichter@marvell.com, tglx@linutronix.de, yuzenghui@huawei.com, eric.auger@redhat.com, james.morse@arm.com, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This (now shorter) series expands the existing GICv4 support to deal with the new GICv4.1 architecture, which comes with a set of major improvements compared to v4.0: - One architectural doorbell per vcpu, instead of one doorbell per VLPI - Doorbell entirely managed by the HW, with an "at most once" delivery guarantee per non-residency phase and only when requested by the hypervisor - A shared memory scheme between ITSs and redistributors, allowing for an optimised residency sequence (the use of VMOVP becomes less frequent) - Support for direct virtual SGI delivery (the injection path still involves the hypervisor), at the cost of losing the active state on SGIs. It shouldn't be a big deal, but some guest operating systems might notice (Linux definitely won't care). On the other hand, public documentation is not available yet, so that's a bit annoying... The series is roughly organised in 3 parts: (1) v4.1 doorbell management (2) Virtual SGI support (3) Plumbing of virtual SGIs in KVM Notes: - The whole thing is tested on a FVP model, which can be obtained free of charge on ARM's developer website. It requires you to create an account, unfortunately... You'll need a fix for the devicetree that is in the kernel tree (should be merged before the 5.6 release). - This series has uncovered a behaviour that looks like a HW bug on the Cavium ThunderX (aka TX1) platform. I'd very much welcome some clarification from the Marvell/Cavium folks on Cc, as well as an official erratum number if this happens to be an actual bug. [v3 update] People have ignored for two months now, and it is fairly obvious that support for this machine is slowly bit-rotting. Maybe I'll drop the patch and instead start the process of removing all TX1 support from the kernel (we'd certainly be better off without it). [v4 update] TX1 is now broken in mainline, and nobody cares. Make of this what you want. * From v3 [3]: - Rebased on v5.6-rc1 - Considerably smaller thanks to the initial patches being merged - Small bug fix after the v5.6 merge window * From v2 [2]: - Another bunch of fixes thanks to Zenghui Yu's very careful review - HW-accelerated SGIs are now optional thanks to new architected discovery/selection bits exposed by KVM and used by the guest kernel - Rebased on v5.5-rc2 * From v1 [1]: - A bunch of minor reworks after Zenghui Yu's review - A workaround for what looks like a new and unexpected TX1 bug - A subtle reorder of the series so that some patches can go in early [1] https://lore.kernel.org/lkml/20190923182606.32100-1-maz@kernel.org/ [2] https://lore.kernel.org/lkml/20191027144234.8395-1-maz@kernel.org/ [3] https://lore.kernel.org/r/20191224111055.11836-1-maz@kernel.org/ Marc Zyngier (20): irqchip/gic-v4.1: Skip absent CPUs while iterating over redistributors irqchip/gic-v3: Use SGIs without active state if offered irqchip/gic-v4.1: Advertise support v4.1 to KVM irqchip/gic-v4.1: Map the ITS SGIR register page irqchip/gic-v4.1: Plumb skeletal VSGI irqchip irqchip/gic-v4.1: Add initial SGI configuration irqchip/gic-v4.1: Plumb mask/unmask SGI callbacks irqchip/gic-v4.1: Plumb get/set_irqchip_state SGI callbacks irqchip/gic-v4.1: Plumb set_vcpu_affinity SGI callbacks irqchip/gic-v4.1: Move doorbell management to the GICv4 abstraction layer irqchip/gic-v4.1: Add VSGI allocation/teardown irqchip/gic-v4.1: Add VSGI property setup irqchip/gic-v4.1: Eagerly vmap vPEs KVM: arm64: GICv4.1: Let doorbells be auto-enabled KVM: arm64: GICv4.1: Add direct injection capability to SGI registers KVM: arm64: GICv4.1: Allow SGIs to switch between HW and SW interrupts KVM: arm64: GICv4.1: Plumb SGI implementation selection in the distributor KVM: arm64: GICv4.1: Reload VLPI configuration on distributor enable/disable KVM: arm64: GICv4.1: Allow non-trapping WFI when using HW SGIs KVM: arm64: GICv4.1: Expose HW-based SGIs in debugfs arch/arm/include/asm/kvm_host.h | 1 + arch/arm64/include/asm/kvm_emulate.h | 3 +- arch/arm64/include/asm/kvm_host.h | 1 + drivers/irqchip/irq-gic-v3-its.c | 301 ++++++++++++++++++++++++- drivers/irqchip/irq-gic-v3.c | 12 +- drivers/irqchip/irq-gic-v4.c | 134 ++++++++++- include/kvm/arm_vgic.h | 4 + include/linux/irqchip/arm-gic-common.h | 2 + include/linux/irqchip/arm-gic-v3.h | 19 +- include/linux/irqchip/arm-gic-v4.h | 20 +- virt/kvm/arm/arm.c | 8 + virt/kvm/arm/vgic/vgic-debug.c | 14 +- virt/kvm/arm/vgic/vgic-mmio-v3.c | 68 +++++- virt/kvm/arm/vgic/vgic-mmio.c | 88 +++++++- virt/kvm/arm/vgic/vgic-v3.c | 6 +- virt/kvm/arm/vgic/vgic-v4.c | 139 ++++++++++-- virt/kvm/arm/vgic/vgic.h | 1 + 17 files changed, 763 insertions(+), 58 deletions(-) -- 2.20.1