Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161005AbWBHGmh (ORCPT ); Wed, 8 Feb 2006 01:42:37 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1161004AbWBHGmh (ORCPT ); Wed, 8 Feb 2006 01:42:37 -0500 Received: from 216-99-217-87.dsl.aracnet.com ([216.99.217.87]:21635 "EHLO sorel.sous-sol.org") by vger.kernel.org with ESMTP id S1030575AbWBHGmf (ORCPT ); Wed, 8 Feb 2006 01:42:35 -0500 Message-Id: <20060208064854.827463000@sorel.sous-sol.org> References: <20060208064503.924238000@sorel.sous-sol.org> Date: Tue, 07 Feb 2006 22:45:07 -0800 From: Chris Wright To: linux-kernel@vger.kernel.org, stable@kernel.org Cc: Justin Forbes , Zwane Mwaikambo , "Theodore Ts'o" , Randy Dunlap , Dave Jones , Chuck Wolber , torvalds@osdl.org, akpm@osdl.org, alan@lxorguk.ukuu.org.uk Subject: [PATCH 04/23] seclvl settime fix Content-Disposition: inline; filename=seclvl-settime-fix.patch Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1209 Lines: 37 -stable review patch. If anyone has any objections, please let us know. ------------------ Don't try to "validate" a non-existing timeval. settime() with a NULL timeval is silly but legal. Noticed by Dave Jones Signed-off-by: Linus Torvalds [chrisw: seclvl only] Signed-off-by: Chris Wright --- security/seclvl.c | 2 +- 1 files changed, 1 insertion(+), 1 deletion(-) Index: linux-2.6.15.3/security/seclvl.c =================================================================== --- linux-2.6.15.3.orig/security/seclvl.c +++ linux-2.6.15.3/security/seclvl.c @@ -369,7 +369,7 @@ static int seclvl_capable(struct task_st static int seclvl_settime(struct timespec *tv, struct timezone *tz) { struct timespec now; - if (seclvl > 1) { + if (tv && seclvl > 1) { now = current_kernel_time(); if (tv->tv_sec < now.tv_sec || (tv->tv_sec == now.tv_sec && tv->tv_nsec < now.tv_nsec)) { -- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/