Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030464AbWBHJCa (ORCPT ); Wed, 8 Feb 2006 04:02:30 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030586AbWBHJCa (ORCPT ); Wed, 8 Feb 2006 04:02:30 -0500 Received: from ns.virtualhost.dk ([195.184.98.160]:57700 "EHLO virtualhost.dk") by vger.kernel.org with ESMTP id S1030464AbWBHJC3 (ORCPT ); Wed, 8 Feb 2006 04:02:29 -0500 Date: Wed, 8 Feb 2006 10:04:57 +0100 From: Jens Axboe To: Tejun Heo Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] block: kill not-so-popular simple flag testing macros Message-ID: <20060208090457.GF4338@suse.de> References: <20060208085728.GA21065@htj.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060208085728.GA21065@htj.dyndns.org> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 683 Lines: 24 On Wed, Feb 08 2006, Tejun Heo wrote: > This patch kills the following request flag testing macros. > > blk_noretry_request() > blk_rq_started() > blk_pm_suspend_request() > blk_pm_resume_request() > blk_sorted_rq() > blk_barrier_rq() > blk_fua_rq() > > All above macros test for single request flag and not used widely and > seem to contribute more to obscurity than readability. Agreed, I've queued it up post-2.6.16 -- Jens Axboe - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/