Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030188AbWBHOIs (ORCPT ); Wed, 8 Feb 2006 09:08:48 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965163AbWBHOIs (ORCPT ); Wed, 8 Feb 2006 09:08:48 -0500 Received: from verein.lst.de ([213.95.11.210]:19181 "EHLO mail.lst.de") by vger.kernel.org with ESMTP id S965148AbWBHOIq (ORCPT ); Wed, 8 Feb 2006 09:08:46 -0500 Date: Wed, 8 Feb 2006 15:08:39 +0100 From: Christoph Hellwig To: Heiko Carstens Cc: Andrew Morton , linux-kernel@vger.kernel.org, Horst Hummel , Stefan Weinhuber , hch@lst.de Subject: Re: [patch 05/10] s390: add missing validation for dasd discipline specific ioctls Message-ID: <20060208140839.GA16366@lst.de> References: <20060208123709.GF1656@osiris.boeblingen.de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060208123709.GF1656@osiris.boeblingen.de.ibm.com> User-Agent: Mutt/1.3.28i X-Spam-Score: -4.901 () BAYES_00 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 832 Lines: 17 On Wed, Feb 08, 2006 at 01:37:09PM +0100, Heiko Carstens wrote: > From: Horst Hummel > > Because of missing discipline validition dasd ioctls calls may not return > when called on a device handled by a different discipline. > (e.g calling ECKD specific BIODASDGATTR on an FBA device). > This addresses one of the issues Christoph has with the dasd driver. Nack. the right way to do this is to have per-discipline ioctl methods, even if we can't remove the dasd_ioctl_register interface yet due to other disagreements. Just resurect those parts of my patch. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/